[PATCH v2 1/3] dt-bindings: media: tegra-cec: Document Tegra186 and Tegra194

[PATCH v2 1/3] dt-bindings: media: tegra-cec: Document Tegra186 and Tegra194

[Thierry Reding]

From: Thierry Reding <treding@nvidia.com>

The Tegra186 and Tegra194 contain a CEC controller that is identical to
that found in earlier generations. Document the compatible strings for
these newer chips.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
Changes in v2:
- new patch adding missing compatible strings

 Documentation/devicetree/bindings/media/tegra-cec.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/tegra-cec.txt b/Documentation/devicetree/bindings/media/tegra-cec.txt
index c503f06f3b84..da3590f0b7a1 100644
--- a/Documentation/devicetree/bindings/media/tegra-cec.txt
+++ b/Documentation/devicetree/bindings/media/tegra-cec.txt
@@ -8,6 +8,8 @@ Required properties:
 	"nvidia,tegra114-cec"
 	"nvidia,tegra124-cec"
 	"nvidia,tegra210-cec"
+	"nvidia,tegra186-cec"
+	"nvidia,tegra194-cec"
   - reg : Physical base address of the IP registers and length of memory
 	  mapped region.
   - interrupts : HDMI CEC interrupt number to the CPU.
-- 
2.19.1

[PATCH v2 2/3] media: tegra-cec: Support Tegra186 and Tegra194

[Thierry Reding]

From: Thierry Reding <treding@nvidia.com>

The CEC controller found on Tegra186 and Tegra194 is the same as on
earlier generations.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 drivers/media/platform/tegra-cec/tegra_cec.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/media/platform/tegra-cec/tegra_cec.c b/drivers/media/platform/tegra-cec/tegra_cec.c
index aba488cd0e64..8a1e10d008d0 100644
--- a/drivers/media/platform/tegra-cec/tegra_cec.c
+++ b/drivers/media/platform/tegra-cec/tegra_cec.c
@@ -472,6 +472,8 @@ static const struct of_device_id tegra_cec_of_match[] = {
 	{ .compatible = "nvidia,tegra114-cec", },
 	{ .compatible = "nvidia,tegra124-cec", },
 	{ .compatible = "nvidia,tegra210-cec", },
+	{ .compatible = "nvidia,tegra186-cec", },
+	{ .compatible = "nvidia,tegra194-cec", },
 	{},
 };
 
-- 
2.19.1

[PATCH v2 3/3] media: tegra-cec: Export OF device ID match table

[Thierry Reding]

From: Thierry Reding <treding@nvidia.com>

Exporting the OF device ID match table allows udev to automatically load
the module upon receiving an "ADD" uevent for the CEC controller device.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 drivers/media/platform/tegra-cec/tegra_cec.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/platform/tegra-cec/tegra_cec.c b/drivers/media/platform/tegra-cec/tegra_cec.c
index 8a1e10d008d0..4e9f91528f77 100644
--- a/drivers/media/platform/tegra-cec/tegra_cec.c
+++ b/drivers/media/platform/tegra-cec/tegra_cec.c
@@ -476,6 +476,7 @@ static const struct of_device_id tegra_cec_of_match[] = {
 	{ .compatible = "nvidia,tegra194-cec", },
 	{},
 };
+MODULE_DEVICE_TABLE(of, tegra_cec_of_match);
 
 static struct platform_driver tegra_cec_driver = {
 	.driver = {
-- 
2.19.1

Re: [PATCH v2 1/3] dt-bindings: media: tegra-cec: Document Tegra186 and Tegra194

[Rob Herring]

On Tue, Dec 11, 2018 at 10:48:39AM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> The Tegra186 and Tegra194 contain a CEC controller that is identical to
> that found in earlier generations. Document the compatible strings for
> these newer chips.

If identical, why don't you have a fallback compatible?

> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> Changes in v2:
> - new patch adding missing compatible strings
> 
>  Documentation/devicetree/bindings/media/tegra-cec.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/tegra-cec.txt b/Documentation/devicetree/bindings/media/tegra-cec.txt
> index c503f06f3b84..da3590f0b7a1 100644
> --- a/Documentation/devicetree/bindings/media/tegra-cec.txt
> +++ b/Documentation/devicetree/bindings/media/tegra-cec.txt
> @@ -8,6 +8,8 @@ Required properties:
>  	"nvidia,tegra114-cec"
>  	"nvidia,tegra124-cec"
>  	"nvidia,tegra210-cec"
> +	"nvidia,tegra186-cec"
> +	"nvidia,tegra194-cec"
>    - reg : Physical base address of the IP registers and length of memory
>  	  mapped region.
>    - interrupts : HDMI CEC interrupt number to the CPU.
> -- 
> 2.19.1
> 

Re: [PATCH v2 1/3] dt-bindings: media: tegra-cec: Document Tegra186 and Tegra194

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 541 bytes --]

On Tue, Dec 18, 2018 at 10:42:30AM -0600, Rob Herring wrote:
> On Tue, Dec 11, 2018 at 10:48:39AM +0100, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> > 
> > The Tegra186 and Tegra194 contain a CEC controller that is identical to
> > that found in earlier generations. Document the compatible strings for
> > these newer chips.
> 
> If identical, why don't you have a fallback compatible?

That's a good point. I think it would be fine to always fall back to the
nvidia,tegra20-cec compatible.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]