From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46AE1C67839 for ; Thu, 13 Dec 2018 20:55:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 17A1B2086D for ; Thu, 13 Dec 2018 20:55:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 17A1B2086D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=iki.fi Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-media-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726813AbeLMUzZ (ORCPT ); Thu, 13 Dec 2018 15:55:25 -0500 Received: from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:36892 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726435AbeLMUzZ (ORCPT ); Thu, 13 Dec 2018 15:55:25 -0500 Received: from valkosipuli.localdomain (valkosipuli.retiisi.org.uk [IPv6:2001:1bc8:1a6:d3d5::80:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by hillosipuli.retiisi.org.uk (Postfix) with ESMTPS id 1DBEE634C7E; Thu, 13 Dec 2018 22:55:08 +0200 (EET) Received: from sailus by valkosipuli.localdomain with local (Exim 4.89) (envelope-from ) id 1gXY0i-0000kx-4G; Thu, 13 Dec 2018 22:55:08 +0200 Date: Thu, 13 Dec 2018 22:55:08 +0200 From: sakari.ailus@iki.fi To: Maxime Ripard Cc: Kishon Vijay Abraham I , Boris Brezillon , Thomas Petazzoni , Laurent Pinchart , linux-media@vger.kernel.org, Archit Taneja , Andrzej Hajda , Chen-Yu Tsai , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, Krzysztof Witos , Rafal Ciepiela Subject: Re: [PATCH v3 03/10] phy: Add MIPI D-PHY configuration options Message-ID: <20181213205507.3pstxrnwpcrkjsiz@valkosipuli.retiisi.org.uk> References: <96a74b72be8db491dea720fdd7394bcd09880c84.1544190837.git-series.maxime.ripard@bootlin.com> <20181213205428.i52epss7lmgdyzj2@valkosipuli.retiisi.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20181213205428.i52epss7lmgdyzj2@valkosipuli.retiisi.org.uk> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Thu, Dec 13, 2018 at 10:54:28PM +0200, sakari.ailus@iki.fi wrote: > Hi Maxime, > > One more small note. > > On Fri, Dec 07, 2018 at 02:55:30PM +0100, Maxime Ripard wrote: > > ... > > > + /** > > + * @wakeup: > > + * > > + * Time, in picoseconds, that a transmitter drives a Mark-1 > > + * state prior to a Stop state in order to initiate an exit > > + * from ULPS. > > + * > > + * Minimum value: 1000000000 ps > > + */ > > + unsigned int wakeup; > > This is very close to the higher limit of the type's value range. How about > using ns or µs for this one? Same for init actually. -- Sakari Ailus