Re: [PATCH 2/3] media: tc358746: add Toshiba TC358746 Parallel to CSI-2 bridge driver

From: kbuild test robot <lkp@intel.com>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: kbuild-all@01.org, hans.verkuil@cisco.com,
	sakari.ailus@linux.intel.com, mchehab@kernel.org,
	robh+dt@kernel.org, mark.rutland@arm.com,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	graphics@pengutronix.de
Subject: Re: [PATCH 2/3] media: tc358746: add Toshiba TC358746 Parallel to CSI-2 bridge driver
Date: Wed, 19 Dec 2018 09:24:25 +0800	[thread overview]
Message-ID: <201812190957.chBdknsj%fengguang.wu@intel.com> (raw)
In-Reply-To: <20181218141240.3056-3-m.felsch@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 3475 bytes --]

Hi Marco,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[cannot apply to v4.20-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Marco-Felsch/media-add-Toshiba-TC358746-Bridge-support/20181219-041919
base:   git://linuxtv.org/media_tree.git master
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 8.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=8.1.0 make.cross ARCH=ia64 

All warnings (new ones prefixed by >>):

   drivers/media/i2c/tc358746.c: In function 'tc358746_sleep_mode':
>> drivers/media/i2c/tc358746.c:790:30: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551613' to '4294967293' [-Woverflow]
     i2c_wr16_and_or(sd, SYSCTL, ~SYSCTL_SLEEP_MASK,
   drivers/media/i2c/tc358746.c: In function 'tc358746_enable_stream':
   drivers/media/i2c/tc358746.c:809:32: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709518847' to '4294934527' [-Woverflow]
      i2c_wr16_and_or(sd, PP_MISC, ~PP_MISC_FRMSTOP_MASK,
   drivers/media/i2c/tc358746.c:811:32: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551551' to '4294967231' [-Woverflow]
      i2c_wr16_and_or(sd, CONFCTL, ~CONFCTL_PPEN_MASK, 0);
   drivers/media/i2c/tc358746.c:812:32: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709535231' to '4294950911' [-Woverflow]
      i2c_wr16_and_or(sd, PP_MISC, ~PP_MISC_RSTPTR_MASK,
   drivers/media/i2c/tc358746.c:820:32: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551551' to '4294967231' [-Woverflow]
      i2c_wr16_and_or(sd, CONFCTL, ~CONFCTL_PPEN_MASK,
   drivers/media/i2c/tc358746.c: In function 'tc358746_set_pll':
   drivers/media/i2c/tc358746.c:866:32: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551599' to '4294967279' [-Woverflow]
      i2c_wr16_and_or(sd, PLLCTL1, ~PLLCTL1_CKEN_MASK,
   drivers/media/i2c/tc358746.c: In function 'tc358746_set_csi_color_space':
   drivers/media/i2c/tc358746.c:882:4: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709551374' to '4294967054' [-Woverflow]
       ~(DATAFMT_PDFMT_MASK | DATAFMT_UDT_EN_MASK),
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/media/i2c/tc358746.c:884:31: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709550847' to '4294966527' [-Woverflow]
     i2c_wr16_and_or(sd, CONFCTL, ~CONFCTL_PDATAF_MASK,

vim +790 drivers/media/i2c/tc358746.c

   787	
   788	static inline void tc358746_sleep_mode(struct v4l2_subdev *sd, int enable)
   789	{
 > 790		i2c_wr16_and_or(sd, SYSCTL, ~SYSCTL_SLEEP_MASK,
   791				enable ? SYSCTL_SLEEP_MASK : 0);
   792	}
   793	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 52418 bytes --]