Hi Marco,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on next-20181220]
[cannot apply to v4.20-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Marco-Felsch/media-add-Toshiba-TC358746-Bridge-support/20181219-041919
base:   git://linuxtv.org/media_tree.git master
config: sparc64-allyesconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=sparc64 

All warnings (new ones prefixed by >>):

   drivers/media//i2c/tc358746.c: In function 'tc358746_sleep_mode':
>> drivers/media//i2c/tc358746.c:790:30: warning: large integer implicitly truncated to unsigned type [-Woverflow]
     i2c_wr16_and_or(sd, SYSCTL, ~SYSCTL_SLEEP_MASK,
                                 ^
   drivers/media//i2c/tc358746.c: In function 'tc358746_enable_stream':
   drivers/media//i2c/tc358746.c:809:32: warning: large integer implicitly truncated to unsigned type [-Woverflow]
      i2c_wr16_and_or(sd, PP_MISC, ~PP_MISC_FRMSTOP_MASK,
                                   ^
   drivers/media//i2c/tc358746.c:811:32: warning: large integer implicitly truncated to unsigned type [-Woverflow]
      i2c_wr16_and_or(sd, CONFCTL, ~CONFCTL_PPEN_MASK, 0);
                                   ^
   drivers/media//i2c/tc358746.c:812:32: warning: large integer implicitly truncated to unsigned type [-Woverflow]
      i2c_wr16_and_or(sd, PP_MISC, ~PP_MISC_RSTPTR_MASK,
                                   ^
   drivers/media//i2c/tc358746.c:820:32: warning: large integer implicitly truncated to unsigned type [-Woverflow]
      i2c_wr16_and_or(sd, CONFCTL, ~CONFCTL_PPEN_MASK,
                                   ^
   drivers/media//i2c/tc358746.c: In function 'tc358746_set_pll':
   drivers/media//i2c/tc358746.c:866:32: warning: large integer implicitly truncated to unsigned type [-Woverflow]
      i2c_wr16_and_or(sd, PLLCTL1, ~PLLCTL1_CKEN_MASK,
                                   ^
   drivers/media//i2c/tc358746.c: In function 'tc358746_set_csi_color_space':
   drivers/media//i2c/tc358746.c:882:4: warning: large integer implicitly truncated to unsigned type [-Woverflow]
       ~(DATAFMT_PDFMT_MASK | DATAFMT_UDT_EN_MASK),
       ^
   drivers/media//i2c/tc358746.c:884:31: warning: large integer implicitly truncated to unsigned type [-Woverflow]
     i2c_wr16_and_or(sd, CONFCTL, ~CONFCTL_PDATAF_MASK,
                                  ^

vim +790 drivers/media//i2c/tc358746.c

   787	
   788	static inline void tc358746_sleep_mode(struct v4l2_subdev *sd, int enable)
   789	{
 > 790		i2c_wr16_and_or(sd, SYSCTL, ~SYSCTL_SLEEP_MASK,
   791				enable ? SYSCTL_SLEEP_MASK : 0);
   792	}
   793	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation