From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB9D7C43387 for ; Mon, 7 Jan 2019 11:32:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 73BCF21736 for ; Mon, 7 Jan 2019 11:32:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726961AbfAGLcu (ORCPT ); Mon, 7 Jan 2019 06:32:50 -0500 Received: from mga18.intel.com ([134.134.136.126]:55159 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726879AbfAGLcu (ORCPT ); Mon, 7 Jan 2019 06:32:50 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jan 2019 03:32:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,450,1539673200"; d="scan'208";a="133596205" Received: from bachmicx-mobl.ger.corp.intel.com (HELO kekkonen.fi.intel.com) ([10.252.57.24]) by fmsmga004.fm.intel.com with ESMTP; 07 Jan 2019 03:32:48 -0800 Received: by kekkonen.fi.intel.com (Postfix, from userid 1000) id DB7BF21D0B; Mon, 7 Jan 2019 13:32:43 +0200 (EET) Date: Mon, 7 Jan 2019 13:32:43 +0200 From: Sakari Ailus To: Akinobu Mita Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, Guennadi Liakhovetski , Mauro Carvalho Chehab Subject: Re: [PATCH 12/12] media: mt9m001: set all mbus format field when G_FMT and S_FMT ioctls Message-ID: <20190107113243.dte4yqioqy33cwe5@kekkonen.localdomain> References: <1545498774-11754-1-git-send-email-akinobu.mita@gmail.com> <1545498774-11754-13-git-send-email-akinobu.mita@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1545498774-11754-13-git-send-email-akinobu.mita@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Mita-san, On Sun, Dec 23, 2018 at 02:12:54AM +0900, Akinobu Mita wrote: > This driver doesn't set all members of mbus format field when the > VIDIOC_SUBDEV_{S,G}_FMT ioctls are called. > > This is detected by v4l2-compliance. > > Cc: Guennadi Liakhovetski > Cc: Sakari Ailus > Cc: Mauro Carvalho Chehab > Signed-off-by: Akinobu Mita > --- > drivers/media/i2c/mt9m001.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/media/i2c/mt9m001.c b/drivers/media/i2c/mt9m001.c > index f4afbc9..82b89d5 100644 > --- a/drivers/media/i2c/mt9m001.c > +++ b/drivers/media/i2c/mt9m001.c > @@ -342,6 +342,9 @@ static int mt9m001_get_fmt(struct v4l2_subdev *sd, > mf->code = mt9m001->fmt->code; > mf->colorspace = mt9m001->fmt->colorspace; > mf->field = V4L2_FIELD_NONE; > + mf->ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT; > + mf->quantization = V4L2_QUANTIZATION_DEFAULT; > + mf->xfer_func = V4L2_XFER_FUNC_DEFAULT; Instead of setting the fields individually, would it be feasible to just assign mt9m001->fmt to mf? > > return 0; > } > @@ -402,6 +405,10 @@ static int mt9m001_set_fmt(struct v4l2_subdev *sd, > } > > mf->colorspace = fmt->colorspace; > + mf->field = V4L2_FIELD_NONE; > + mf->ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT; > + mf->quantization = V4L2_QUANTIZATION_DEFAULT; > + mf->xfer_func = V4L2_XFER_FUNC_DEFAULT; Ditto. > > if (format->which == V4L2_SUBDEV_FORMAT_ACTIVE) > return mt9m001_s_fmt(sd, fmt, mf); -- Sakari Ailus sakari.ailus@linux.intel.com