From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: hverkuil@xs4all.nl, mchehab@kernel.org,
laurent.pinchart@ideasonboard.com
Subject: [PATCH v2 3/3] videobuf2-core.h: Document the alloc memop size argument as page aligned
Date: Tue, 8 Jan 2019 10:58:36 +0200 [thread overview]
Message-ID: <20190108085836.9376-4-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20190108085836.9376-1-sakari.ailus@linux.intel.com>
The size argument of the alloc memop, which allocates buffer memory, is
page aligned. Document it as such in the only caller as well as ops
documentation.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
---
drivers/media/common/videobuf2/videobuf2-core.c | 1 +
include/media/videobuf2-core.h | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/common/videobuf2/videobuf2-core.c b/drivers/media/common/videobuf2/videobuf2-core.c
index 0234ddbfa4de..64ecb9a65a47 100644
--- a/drivers/media/common/videobuf2/videobuf2-core.c
+++ b/drivers/media/common/videobuf2/videobuf2-core.c
@@ -205,6 +205,7 @@ static int __vb2_buf_mem_alloc(struct vb2_buffer *vb)
* NOTE: mmapped areas should be page aligned
*/
for (plane = 0; plane < vb->num_planes; ++plane) {
+ /* Memops alloc requires size to be page aligned. */
unsigned long size = PAGE_ALIGN(vb->planes[plane].length);
/* Did it wrap around? */
diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h
index e86981d615ae..68b9fe660e4f 100644
--- a/include/media/videobuf2-core.h
+++ b/include/media/videobuf2-core.h
@@ -54,7 +54,8 @@ struct vb2_threadio_data;
* will then be passed as @buf_priv argument to other ops in this
* structure. Additional gfp_flags to use when allocating the
* are also passed to this operation. These flags are from the
- * gfp_flags field of vb2_queue.
+ * gfp_flags field of vb2_queue. The size argument to this function
+ * shall be *page aligned*.
* @put: inform the allocator that the buffer will no longer be used;
* usually will result in the allocator freeing the buffer (if
* no other users of this buffer are present); the @buf_priv
--
2.11.0
prev parent reply other threads:[~2019-01-08 8:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 8:58 [PATCH v2 0/3] Videobuf2 corner case fixes Sakari Ailus
2019-01-08 8:58 ` [PATCH v2 1/3] videobuf2-core: Prevent size alignment wrapping buffer size to 0 Sakari Ailus
2019-01-08 12:52 ` Mauro Carvalho Chehab
2019-01-08 12:59 ` Mauro Carvalho Chehab
2019-01-08 13:01 ` Mauro Carvalho Chehab
2019-01-08 13:38 ` Sakari Ailus
2019-01-08 14:23 ` Mauro Carvalho Chehab
2019-01-09 8:41 ` Sakari Ailus
2019-01-08 13:40 ` Sakari Ailus
2019-01-08 14:30 ` Mauro Carvalho Chehab
2019-01-08 16:05 ` Laurent Pinchart
2019-01-09 12:13 ` Mauro Carvalho Chehab
2019-01-09 13:56 ` Sakari Ailus
2019-01-08 8:58 ` [PATCH v2 2/3] videobuf2-dma-sg: Prevent size from overflowing Sakari Ailus
2019-01-08 13:09 ` Mauro Carvalho Chehab
2019-01-08 13:29 ` Sakari Ailus
2019-01-08 13:44 ` Mauro Carvalho Chehab
2019-01-08 13:57 ` Sakari Ailus
2019-01-08 8:58 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190108085836.9376-4-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).