From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Sean Paul <sean@poorly.run>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-media@vger.kernel.org,
Archit Taneja <architt@codeaurora.org>,
Andrzej Hajda <a.hajda@samsung.com>, Chen-Yu Tsai <wens@csie.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
Krzysztof Witos <kwitos@cadence.com>,
Rafal Ciepiela <rafalc@cadence.com>
Subject: Re: [PATCH v4 6/9] drm/bridge: cdns: Separate DSI and D-PHY configuration
Date: Mon, 21 Jan 2019 16:43:28 +0100 [thread overview]
Message-ID: <20190121154328.ydvz4fr5l77do3eh@flea> (raw)
In-Reply-To: <20190117133338.GA114153@art_vandelay>
[-- Attachment #1: Type: text/plain, Size: 1038 bytes --]
On Thu, Jan 17, 2019 at 08:33:38AM -0500, Sean Paul wrote:
> > @@ -768,49 +769,90 @@ static int cdns_dsi_mode2cfg(struct cdns_dsi *dsi,
> >
> > dsi_cfg->hsa = dpi_to_dsi_timing(tmp, bpp,
> > DSI_HSA_FRAME_OVERHEAD);
> > - dsi_htotal += dsi_cfg->hsa + DSI_HSA_FRAME_OVERHEAD;
> > - dsi_hss_hsa_hse_hbp += dsi_cfg->hsa + DSI_HSA_FRAME_OVERHEAD;
> > }
> >
> > dsi_cfg->hact = dpi_to_dsi_timing(mode_valid_check ?
> > mode->hdisplay : mode->crtc_hdisplay,
> > bpp, 0);
> > - dsi_htotal += dsi_cfg->hact;
> > + dsi_cfg->hfp = dpi_to_dsi_timing(mode_to_dpi_hfp(mode), bpp,
> > + DSI_HFP_FRAME_OVERHEAD);
>
> We're throwing away the mode_valid_check switch here to flip between crtc_h*
> value and h* value. Is that intentional? We're using it above for hdisplay, so
> it's a bit confusing.
ah, right, thanks for spotting this.
I'll resend a version with those changes, thanks!
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2019-01-21 15:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 9:33 [PATCH v4 0/9] phy: Add configuration interface for MIPI D-PHY devices Maxime Ripard
2019-01-09 9:33 ` [PATCH v4 1/9] phy: dphy: Remove unused header Maxime Ripard
2019-01-09 9:33 ` [PATCH v4 2/9] phy: dphy: Change units of wakeup and init parameters Maxime Ripard
2019-01-09 9:33 ` [PATCH v4 3/9] phy: dphy: Clarify lanes parameter documentation Maxime Ripard
2019-01-09 9:33 ` [PATCH v4 4/9] sun6i: dsi: Convert to generic phy handling Maxime Ripard
2019-02-07 8:16 ` Paul Kocialkowski
2019-01-09 9:33 ` [PATCH v4 5/9] phy: Move Allwinner A31 D-PHY driver to drivers/phy/ Maxime Ripard
2019-01-09 9:33 ` [PATCH v4 6/9] drm/bridge: cdns: Separate DSI and D-PHY configuration Maxime Ripard
2019-01-16 8:36 ` Kishon Vijay Abraham I
2019-01-17 13:33 ` Sean Paul
2019-01-21 15:43 ` Maxime Ripard [this message]
2019-01-09 9:33 ` [PATCH v4 7/9] dt-bindings: phy: Move the Cadence D-PHY bindings Maxime Ripard
2019-01-09 12:39 ` Sakari Ailus
2019-01-09 9:33 ` [PATCH v4 8/9] phy: Add Cadence D-PHY support Maxime Ripard
2019-01-09 12:41 ` Sakari Ailus
2019-01-17 13:53 ` Sean Paul
2019-01-21 13:39 ` Maxime Ripard
2019-01-09 9:33 ` [PATCH v4 9/9] drm/bridge: cdns: Convert to phy framework Maxime Ripard
2019-01-16 8:37 ` Kishon Vijay Abraham I
2019-01-17 13:53 ` Sean Paul
2019-01-09 12:28 ` [PATCH v4 0/9] phy: Add configuration interface for MIPI D-PHY devices Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121154328.ydvz4fr5l77do3eh@flea \
--to=maxime.ripard@bootlin.com \
--cc=a.hajda@samsung.com \
--cc=architt@codeaurora.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kishon@ti.com \
--cc=kwitos@cadence.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=rafalc@cadence.com \
--cc=sean@poorly.run \
--cc=thomas.petazzoni@bootlin.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).