From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: Yong Deng <yong.deng@magewell.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Michael Trimarchi <michael@amarulasolutions.com>,
linux-amarula@amarulasolutions.com, devicetree@vger.kernel.org,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH v7 2/5] media: sun6i: Add A64 CSI block support
Date: Fri, 25 Jan 2019 16:42:45 +0100 [thread overview]
Message-ID: <20190125154245.5wx2mwhzsjeaahi3@flea> (raw)
In-Reply-To: <20190124180736.28408-3-jagan@amarulasolutions.com>
[-- Attachment #1: Type: text/plain, Size: 2937 bytes --]
On Thu, Jan 24, 2019 at 11:37:33PM +0530, Jagan Teki wrote:
> CSI block in Allwinner A64 has similar features as like in H3,
> but the default CSI_SCLK rate cannot work properly to drive the
> connected sensor interface.
>
> The tested mod cock rate is 300 MHz and BSP vfe media driver is also
> using the same rate. Unfortunately there is no valid information about
> clock rate in manual or any other sources except the BSP driver. so more
> faith on BSP code, because same has tested in mainline.
>
> So, add support for A64 CSI block by setting updated mod clock rate.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
> index ee882b66a5ea..cd2d33242c17 100644
> --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
> +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
> @@ -15,6 +15,7 @@
> #include <linux/ioctl.h>
> #include <linux/module.h>
> #include <linux/of.h>
> +#include <linux/of_device.h>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> #include <linux/regmap.h>
> @@ -154,6 +155,7 @@ bool sun6i_csi_is_format_supported(struct sun6i_csi *csi,
> int sun6i_csi_set_power(struct sun6i_csi *csi, bool enable)
> {
> struct sun6i_csi_dev *sdev = sun6i_csi_to_dev(csi);
> + struct device *dev = sdev->dev;
> struct regmap *regmap = sdev->regmap;
> int ret;
>
> @@ -161,15 +163,20 @@ int sun6i_csi_set_power(struct sun6i_csi *csi, bool enable)
> regmap_update_bits(regmap, CSI_EN_REG, CSI_EN_CSI_EN, 0);
>
> clk_disable_unprepare(sdev->clk_ram);
> + if (of_device_is_compatible(dev->of_node, "allwinner,sun50i-a64-csi"))
> + clk_rate_exclusive_put(sdev->clk_mod);
> clk_disable_unprepare(sdev->clk_mod);
> reset_control_assert(sdev->rstc_bus);
> return 0;
> }
>
> + if (of_device_is_compatible(dev->of_node, "allwinner,sun50i-a64-csi"))
> + clk_set_rate_exclusive(sdev->clk_mod, 300000000);
> +
> ret = clk_prepare_enable(sdev->clk_mod);
> if (ret) {
> dev_err(sdev->dev, "Enable csi clk err %d\n", ret);
> - return ret;
> + goto clk_mod_put;
> }
>
> ret = clk_prepare_enable(sdev->clk_ram);
> @@ -192,6 +199,9 @@ int sun6i_csi_set_power(struct sun6i_csi *csi, bool enable)
> clk_disable_unprepare(sdev->clk_ram);
> clk_mod_disable:
> clk_disable_unprepare(sdev->clk_mod);
> +clk_mod_put:
> + if (of_device_is_compatible(dev->of_node, "allwinner,sun50i-a64-csi"))
> + clk_rate_exclusive_put(sdev->clk_mod);
> return ret;
The sequence in the error path and in the disable path aren't the same, why?
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2019-01-25 15:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 18:07 [PATCH v7 0/5] media/sun6i: Allwinner A64 CSI support Jagan Teki
2019-01-24 18:07 ` [PATCH v7 1/5] dt-bindings: media: sun6i: Add A64 CSI compatible Jagan Teki
2019-01-25 15:41 ` Maxime Ripard
2019-01-24 18:07 ` [PATCH v7 2/5] media: sun6i: Add A64 CSI block support Jagan Teki
2019-01-25 15:42 ` Maxime Ripard [this message]
2019-01-28 7:31 ` Jagan Teki
2019-01-24 18:07 ` [PATCH v7 3/5] arm64: dts: allwinner: a64: Add A64 CSI controller Jagan Teki
2019-01-25 15:43 ` Maxime Ripard
2019-01-24 18:07 ` [PATCH v7 4/5] arm64: dts: allwinner: a64: Add pinmux setting for CSI MCLK on PE1 Jagan Teki
2019-01-24 18:07 ` [DO NOT MERGE] [PATCH v7 5/5] arm64: dts: allwinner: bananapi-m64: Add HDF5640 camera module Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190125154245.5wx2mwhzsjeaahi3@flea \
--to=maxime.ripard@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=jagan@amarulasolutions.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=michael@amarulasolutions.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
--cc=yong.deng@magewell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).