linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@iki.fi>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: "Yong Deng" <yong.deng@magewell.com>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Maxime Ripard" <maxime.ripard@bootlin.com>,
	"Chen-Yu Tsai" <wens@csie.org>,
	linux-media@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	"Niklas Söderlund" <niklas.soderlund@ragnatech.se>
Subject: Re: compile error at sun6i_video
Date: Tue, 5 Feb 2019 11:52:16 +0200	[thread overview]
Message-ID: <20190205095216.f2fg5vjvqqhgs6as@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <878syukax3.wl-kuninori.morimoto.gx@renesas.com>

Hi Morimoto-san,

On Tue, Feb 05, 2019 at 03:38:29PM +0900, Kuninori Morimoto wrote:
> 
> Hi MultiMedia ML
> 
> I got below compile error at SH.
> 
>   ...
>   CC      drivers/tty/tty_io.o
> /opt/RB02197/home/morimoto/save/WORK/linux/drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c: In function 'sun6i_video_start_streaming':
> /opt/RB02197/home/morimoto/save/WORK/linux/drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c:141:29: error: passing argument 1 of 'media_pipeline_start' from incompatible pointer type [-Werror=incompatible-pointer-types]
>   ret = media_pipeline_start(&video->vdev.entity, &video->vdev.pipe);
>                              ^~~~~~~~~~~~~~~~~~~
> In file included from /opt/RB02197/home/morimoto/save/WORK/linux/include/media/media-device.h:26,
>                  from /opt/RB02197/home/morimoto/save/WORK/linux/include/media/v4l2-device.h:24,
>                  from /opt/RB02197/home/morimoto/save/WORK/linux/drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c:10:
> /opt/RB02197/home/morimoto/save/WORK/linux/include/media/media-entity.h:1030:84: note: expected 'struct media_pad *' but argument is of type 'struct media_entity *'
>  __must_check int media_pipeline_start(struct media_pad *pad,
>                                                                                     ^  
> /opt/RB02197/home/morimoto/save/WORK/linux/drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c:205:22: error: passing argument 1 of 'media_pipeline_stop' from incompatible pointer type [-Werror=incompatible-pointer-types]
>   media_pipeline_stop(&video->vdev.entity);
>                       ^~~~~~~~~~~~~~~~~~~
> In file included from /opt/RB02197/home/morimoto/save/WORK/linux/include/media/media-device.h:26,
>                  from /opt/RB02197/home/morimoto/save/WORK/linux/include/media/v4l2-device.h:24,
>                  from /opt/RB02197/home/morimoto/save/WORK/linux/drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c:10:
> /opt/RB02197/home/morimoto/save/WORK/linux/include/media/media-entity.h:1055:44: note: expected 'struct media_pad *' but argument is of type 'struct media_entity *'
>  void media_pipeline_stop(struct media_pad *pad);
>                           ~~~~~~~~~~~~~~~~~~^~~
> /opt/RB02197/home/morimoto/save/WORK/linux/drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c: In function 'sun6i_video_stop_streaming':
> /opt/RB02197/home/morimoto/save/WORK/linux/drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c:229:22: error: passing argument 1 of 'media_pipeline_stop' from incompatible pointer type [-Werror=incompatible-pointer-types]
>   media_pipeline_stop(&video->vdev.entity);
>                       ^~~~~~~~~~~~~~~~~~~
> In file included from /opt/RB02197/home/morimoto/save/WORK/linux/include/media/media-device.h:26,
>                  from /opt/RB02197/home/morimoto/save/WORK/linux/include/media/v4l2-device.h:24,
>                  from /opt/RB02197/home/morimoto/save/WORK/linux/drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c:10:
> /opt/RB02197/home/morimoto/save/WORK/linux/include/media/media-entity.h:1055:44: note: expected 'struct media_pad *' but argument is of type 'struct media_entity *'
>  void media_pipeline_stop(struct media_pad *pad);
>                           ~~~~~~~~~~~~~~~~~~^~~

Do you have the patches Niklas's v4l2/mux (or my vc) branch in your tree?
They change a few things on the way and drivers need to be converted.
Drivers that have been added since the patches were written do need to be
converted as well, and I suppose the sun6i_video driver is one of them.

Cc Niklas.

-- 
Kind regards,

Sakari Ailus

  reply	other threads:[~2019-02-05  9:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-05  6:38 compile error at sun6i_video Kuninori Morimoto
2019-02-05  9:52 ` Sakari Ailus [this message]
2019-02-06  0:50   ` Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190205095216.f2fg5vjvqqhgs6as@valkosipuli.retiisi.org.uk \
    --to=sakari.ailus@iki.fi \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=maxime.ripard@bootlin.com \
    --cc=mchehab@kernel.org \
    --cc=niklas.soderlund@ragnatech.se \
    --cc=wens@csie.org \
    --cc=yong.deng@magewell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).