From: Marco Felsch <m.felsch@pengutronix.de> To: mchehab@kernel.org, sakari.ailus@linux.intel.com, hans.verkuil@cisco.com, jacopo+renesas@jmondi.org, robh+dt@kernel.org Cc: laurent.pinchart@ideasonboard.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Michael Tretter <m.tretter@pengutronix.de> Subject: [PATCH v6 08/13] media: tvp5150: initialize subdev before parsing device tree Date: Mon, 15 Apr 2019 14:44:08 +0200 Message-ID: <20190415124413.18456-9-m.felsch@pengutronix.de> (raw) In-Reply-To: <20190415124413.18456-1-m.felsch@pengutronix.de> From: Michael Tretter <m.tretter@pengutronix.de> There are several debug prints in the tvp5150_parse_dt() function, which do not print the prefix, because the v4l2_subdev is not initialized, yet. Initialize the v4l2_subdev before parsing the device tree to fix the debug messages. Signed-off-by: Michael Tretter <m.tretter@pengutronix.de> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> --- drivers/media/i2c/tvp5150.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c index 9331609425bf..305a5e256b31 100644 --- a/drivers/media/i2c/tvp5150.c +++ b/drivers/media/i2c/tvp5150.c @@ -1973,6 +1973,9 @@ static int tvp5150_probe(struct i2c_client *c, core->regmap = map; sd = &core->sd; + v4l2_i2c_subdev_init(sd, c, &tvp5150_ops); + sd->internal_ops = &tvp5150_internal_ops; + sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; if (IS_ENABLED(CONFIG_OF) && np) { res = tvp5150_parse_dt(core, np); @@ -1985,10 +1988,6 @@ static int tvp5150_probe(struct i2c_client *c, core->mbus_type = V4L2_MBUS_BT656; } - v4l2_i2c_subdev_init(sd, c, &tvp5150_ops); - sd->internal_ops = &tvp5150_internal_ops; - sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; - res = tvp5150_mc_init(core); if (res) goto err_cleanup_dt; -- 2.20.1
next prev parent reply index Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-15 12:44 [PATCH v6 00/13] TVP5150 new features Marco Felsch 2019-04-15 12:44 ` [PATCH v6 01/13] dt-bindings: connector: analog: add tv norms property Marco Felsch 2019-05-06 10:01 ` Hans Verkuil 2019-05-06 10:06 ` Hans Verkuil 2019-05-14 18:11 ` Mauro Carvalho Chehab 2019-08-09 6:00 ` Marco Felsch 2019-05-16 16:27 ` Laurent Pinchart 2019-08-09 5:58 ` Marco Felsch 2019-08-15 12:33 ` Laurent Pinchart 2019-08-15 12:50 ` Marco Felsch 2019-08-15 13:02 ` Laurent Pinchart 2019-08-15 13:35 ` Marco Felsch 2019-04-15 12:44 ` [PATCH v6 02/13] media: v4l2-fwnode: add v4l2_fwnode_connector Marco Felsch 2019-05-06 9:50 ` Hans Verkuil 2019-05-14 18:17 ` Mauro Carvalho Chehab 2019-08-09 7:20 ` Marco Felsch 2019-05-16 16:36 ` Laurent Pinchart 2019-08-09 7:55 ` Marco Felsch 2019-08-15 12:38 ` Laurent Pinchart 2019-08-15 13:04 ` Marco Felsch 2019-08-15 13:10 ` Laurent Pinchart 2019-08-15 13:37 ` Marco Felsch 2019-04-15 12:44 ` [PATCH v6 03/13] media: v4l2-fwnode: add initial connector parsing support Marco Felsch 2019-05-06 10:10 ` Hans Verkuil 2019-05-14 18:20 ` Mauro Carvalho Chehab 2019-05-16 16:51 ` Laurent Pinchart 2019-08-09 12:16 ` Marco Felsch 2019-08-15 12:48 ` Laurent Pinchart 2019-08-15 13:14 ` Marco Felsch 2019-08-09 8:59 ` Marco Felsch 2019-04-15 12:44 ` [PATCH v6 04/13] partial revert of "[media] tvp5150: add HW input connectors support" Marco Felsch 2019-04-15 12:44 ` [PATCH v6 05/13] media: tvp5150: add input source selection of_graph support Marco Felsch 2019-05-06 10:09 ` Jacopo Mondi 2019-05-14 18:25 ` Mauro Carvalho Chehab 2019-05-16 18:03 ` Laurent Pinchart 2019-08-13 8:54 ` Marco Felsch 2019-08-15 12:51 ` Laurent Pinchart 2019-08-15 13:22 ` Marco Felsch 2019-08-15 13:26 ` Laurent Pinchart 2019-04-15 12:44 ` [PATCH v6 06/13] media: dt-bindings: tvp5150: Add input port connectors DT bindings Marco Felsch 2019-05-14 18:27 ` Mauro Carvalho Chehab 2019-05-16 18:05 ` Laurent Pinchart 2019-08-13 8:56 ` Marco Felsch 2019-04-15 12:44 ` [PATCH v6 07/13] media: tvp5150: add FORMAT_TRY support for get/set selection handlers Marco Felsch 2019-05-06 13:36 ` Jacopo Mondi 2019-08-09 5:33 ` Marco Felsch 2019-05-14 18:48 ` Mauro Carvalho Chehab 2019-08-09 5:34 ` Marco Felsch 2019-04-15 12:44 ` Marco Felsch [this message] 2019-05-14 20:20 ` [PATCH v6 08/13] media: tvp5150: initialize subdev before parsing device tree Mauro Carvalho Chehab 2019-08-09 5:42 ` Marco Felsch 2019-04-15 12:44 ` [PATCH v6 09/13] media: tvp5150: add s_power callback Marco Felsch 2019-05-14 20:13 ` Mauro Carvalho Chehab 2019-08-09 5:39 ` Marco Felsch 2019-04-15 12:44 ` [PATCH v6 10/13] media: dt-bindings: tvp5150: cleanup bindings stlye Marco Felsch 2019-04-15 12:44 ` [PATCH v6 11/13] media: dt-bindings: tvp5150: add optional tvnorms documentation Marco Felsch 2019-04-15 12:44 ` [PATCH v6 12/13] media: tvp5150: add support to limit tv norms on connector Marco Felsch 2019-05-16 18:07 ` Laurent Pinchart 2019-08-13 9:10 ` Marco Felsch 2019-08-15 12:53 ` Laurent Pinchart 2019-08-15 13:26 ` Marco Felsch 2019-04-15 12:44 ` [PATCH v6 13/13] media: tvp5150: make debug output more readable Marco Felsch 2019-05-06 13:39 ` Jacopo Mondi 2019-05-14 20:18 ` Mauro Carvalho Chehab 2019-08-09 5:42 ` Marco Felsch 2019-05-06 5:47 ` [PATCH v6 00/13] TVP5150 new features Marco Felsch 2019-05-14 17:18 ` Mauro Carvalho Chehab 2019-05-14 20:20 ` Mauro Carvalho Chehab 2019-05-14 20:58 ` Marco Felsch 2019-05-14 23:41 ` Mauro Carvalho Chehab
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190415124413.18456-9-m.felsch@pengutronix.de \ --to=m.felsch@pengutronix.de \ --cc=devicetree@vger.kernel.org \ --cc=hans.verkuil@cisco.com \ --cc=jacopo+renesas@jmondi.org \ --cc=kernel@pengutronix.de \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-media@vger.kernel.org \ --cc=m.tretter@pengutronix.de \ --cc=mchehab@kernel.org \ --cc=robh+dt@kernel.org \ --cc=sakari.ailus@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-Media Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-media/0 linux-media/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-media linux-media/ https://lore.kernel.org/linux-media \ linux-media@vger.kernel.org public-inbox-index linux-media Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-media AGPL code for this site: git clone https://public-inbox.org/public-inbox.git