linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: David Airlie <airlied@linux.ie>
Cc: dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org,
	Maxime Ripard <maxime.ripard@bootlin.com>
Subject: Re: [PATCH 0/9] R-Car DU: Add missing RGB pixel formats
Date: Sat, 20 Apr 2019 16:09:06 +0300	[thread overview]
Message-ID: <20190420130906.GA4964@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20190328070723.26553-1-laurent.pinchart+renesas@ideasonboard.com>

Hi Dave,

On Thu, Mar 28, 2019 at 09:07:14AM +0200, Laurent Pinchart wrote:
> Hello,
> 
> This patch series adds support for 16 missing RGB formats to the DU
> driver. To do is, the formats are first added to the VSP1 driver.
> Patches 1/9 to 3/9 define those formats in the V4L2 API, patches 4/9 to
> 6/9 add them to the VSP driver, and patches 7/9 to 9/9 finally add them
> to the DU driver.

This series touches both V4L2 and DRM drivers. I think it would be
easier to merge it through the V4L2 tree, as the changes on the DRM side
as minimal (see patches 7/9 to 9/9). Would that be OK with you ? I will
of course make sure to avoid conflict with the R-Car DU patches already
merged in your tree.

> There's nothing very special here, but those patches are likely very
> error-prone due to the many instances of very similar constructs. I
> would thus appreciate careful review.
> 
> The new V4L2 4CCs match (or at least should match if I haven't made any
> mistake) the DRM 4CCs, but the names of the format macros differ in
> order to stick to the V4L2 naming scheme.
> 
> Laurent Pinchart (9):
>   v4l: Add definitions for missing 32-bit RGB formats
>   v4l: Add definitions for missing 16-bit RGB4444 formats
>   v4l: Add definitions for missing 16-bit RGB555 formats
>   media: vsp1: Add support for missing 32-bit RGB formats
>   media: vsp1: Add support for missing 16-bit RGB444 formats
>   media: vsp1: Add support for missing 16-bit RGB555 formats
>   drm: rcar-du: Add support for missing 32-bit RGB formats
>   drm: rcar-du: Add support for missing 16-bit RGB4444 formats
>   drm: rcar-du: Add support for missing 16-bit RGB1555 formats
> 
>  .../media/uapi/v4l/pixfmt-packed-rgb.rst      | 436 ++++++++++++++++++
>  drivers/gpu/drm/rcar-du/rcar_du_kms.c         |  80 ++++
>  drivers/media/platform/vsp1/vsp1_pipe.c       |  70 +++
>  include/uapi/linux/videodev2.h                |  16 +
>  4 files changed, 602 insertions(+)

-- 
Regards,

Laurent Pinchart

      parent reply	other threads:[~2019-04-20 13:09 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-28  7:07 [PATCH 0/9] R-Car DU: Add missing RGB pixel formats Laurent Pinchart
2019-03-28  7:07 ` [PATCH 1/9] v4l: Add definitions for missing 32-bit RGB formats Laurent Pinchart
2019-03-28 13:15   ` Jacopo Mondi
2019-04-02 12:12     ` Laurent Pinchart
2019-04-04 16:02       ` Jacopo Mondi
2019-03-28  7:07 ` [PATCH 2/9] v4l: Add definitions for missing 16-bit RGB4444 formats Laurent Pinchart
2019-04-04 16:00   ` Jacopo Mondi
2019-04-18  5:57     ` Laurent Pinchart
2019-07-09 12:56   ` Hans Verkuil
2019-03-28  7:07 ` [PATCH 3/9] v4l: Add definitions for missing 16-bit RGB555 formats Laurent Pinchart
2019-04-04 15:57   ` Jacopo Mondi
2019-04-18  6:25     ` Laurent Pinchart
2019-04-18  6:27   ` [PATCH v1.1 " Laurent Pinchart
2019-04-23 11:53     ` Jacopo Mondi
2019-03-28  7:07 ` [PATCH 4/9] media: vsp1: Add support for missing 32-bit RGB formats Laurent Pinchart
2019-04-04 17:39   ` Jacopo Mondi
2019-04-18  6:06     ` Laurent Pinchart
2019-04-23 13:21       ` Jacopo Mondi
2019-04-23 14:10         ` Laurent Pinchart
2019-03-28  7:07 ` [PATCH 5/9] media: vsp1: Add support for missing 16-bit RGB444 formats Laurent Pinchart
2019-04-23 13:38   ` Jacopo Mondi
2019-03-28  7:07 ` [PATCH 6/9] media: vsp1: Add support for missing 16-bit RGB555 formats Laurent Pinchart
2019-04-23 13:55   ` Jacopo Mondi
2019-04-23 14:46     ` Laurent Pinchart
2019-04-23 16:56       ` Jacopo Mondi
2019-04-23 19:29         ` Laurent Pinchart
2019-03-28  7:07 ` [PATCH 7/9] drm: rcar-du: Add support for missing 32-bit RGB formats Laurent Pinchart
2019-04-23 14:05   ` Jacopo Mondi
2019-03-28  7:07 ` [PATCH 8/9] drm: rcar-du: Add support for missing 16-bit RGB4444 formats Laurent Pinchart
2019-04-23 14:06   ` Jacopo Mondi
2019-03-28  7:07 ` [PATCH 9/9] drm: rcar-du: Add support for missing 16-bit RGB1555 formats Laurent Pinchart
2019-04-23 14:09   ` Jacopo Mondi
2019-04-20 13:09 ` Laurent Pinchart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190420130906.GA4964@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=maxime.ripard@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).