From: Boris Brezillon <boris.brezillon@collabora.com>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
Ezequiel Garcia <ezequiel@collabora.com>,
Nicolas Dufresne <nicolas@ndufresne.ca>,
Jonas Karlman <jonas@kwiboo.se>,
devicetree@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH v3 01/10] rockchip/vpu: rename from rockchip to hantro
Date: Wed, 5 Jun 2019 13:22:42 +0200 [thread overview]
Message-ID: <20190605132242.102fcdd2@collabora.com> (raw)
In-Reply-To: <20190531085523.10892-2-p.zabel@pengutronix.de>
On Fri, 31 May 2019 10:55:14 +0200
Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Rename the driver and all relevant identifiers from Rockchip to Hantro,
> as other Hantro IP based VPU implementations can be supported by the
> same driver.
> The RK3288 decoder is Hantro G1 based, the encoder is Hantro H1.
>
> This patch just renames, no functional changes.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> ---
> MAINTAINERS | 4 +-
> drivers/staging/media/Kconfig | 2 +-
> drivers/staging/media/Makefile | 2 +-
> .../media/{rockchip/vpu => hantro}/Kconfig | 11 +-
> drivers/staging/media/hantro/Makefile | 13 +
> .../media/{rockchip/vpu => hantro}/TODO | 0
> .../vpu/rockchip_vpu.h => hantro/hantro.h} | 136 +++++-----
> .../hantro_drv.c} | 251 +++++++++---------
> .../hantro_g1_mpeg2_dec.c} | 55 ++--
> .../hantro_h1_jpeg_enc.c} | 44 +--
> drivers/staging/media/hantro/hantro_hw.h | 102 +++++++
> .../hantro_jpeg.c} | 18 +-
> drivers/staging/media/hantro/hantro_jpeg.h | 13 +
> .../hantro_mpeg2.c} | 14 +-
> .../hantro_v4l2.c} | 234 ++++++++--------
> .../hantro_v4l2.h} | 16 +-
> .../{rockchip/vpu => hantro}/rk3288_vpu_hw.c | 64 ++---
> .../vpu => hantro}/rk3288_vpu_regs.h | 2 +-
> .../{rockchip/vpu => hantro}/rk3399_vpu_hw.c | 64 ++---
> .../vpu => hantro}/rk3399_vpu_hw_jpeg_enc.c | 32 +--
> .../vpu => hantro}/rk3399_vpu_hw_mpeg2_dec.c | 37 ++-
> .../vpu => hantro}/rk3399_vpu_regs.h | 2 +-
> drivers/staging/media/rockchip/vpu/Makefile | 14 -
> .../media/rockchip/vpu/rockchip_vpu_hw.h | 103 -------
> .../media/rockchip/vpu/rockchip_vpu_jpeg.h | 14 -
> 25 files changed, 616 insertions(+), 631 deletions(-)
> rename drivers/staging/media/{rockchip/vpu => hantro}/Kconfig (59%)
> create mode 100644 drivers/staging/media/hantro/Makefile
> rename drivers/staging/media/{rockchip/vpu => hantro}/TODO (100%)
> rename drivers/staging/media/{rockchip/vpu/rockchip_vpu.h => hantro/hantro.h} (69%)
> rename drivers/staging/media/{rockchip/vpu/rockchip_vpu_drv.c => hantro/hantro_drv.c} (74%)
> rename drivers/staging/media/{rockchip/vpu/rk3288_vpu_hw_mpeg2_dec.c => hantro/hantro_g1_mpeg2_dec.c} (87%)
> rename drivers/staging/media/{rockchip/vpu/rk3288_vpu_hw_jpeg_enc.c => hantro/hantro_h1_jpeg_enc.c} (76%)
> create mode 100644 drivers/staging/media/hantro/hantro_hw.h
> rename drivers/staging/media/{rockchip/vpu/rockchip_vpu_jpeg.c => hantro/hantro_jpeg.c} (95%)
> create mode 100644 drivers/staging/media/hantro/hantro_jpeg.h
> rename drivers/staging/media/{rockchip/vpu/rockchip_vpu_mpeg2.c => hantro/hantro_mpeg2.c} (79%)
> rename drivers/staging/media/{rockchip/vpu/rockchip_vpu_v4l2.c => hantro/hantro_v4l2.c} (69%)
> rename drivers/staging/media/{rockchip/vpu/rockchip_vpu_v4l2.h => hantro/hantro_v4l2.h} (53%)
> rename drivers/staging/media/{rockchip/vpu => hantro}/rk3288_vpu_hw.c (68%)
> rename drivers/staging/media/{rockchip/vpu => hantro}/rk3288_vpu_regs.h (99%)
Didn't notice that in my initial review, but rk3288_vpu_regs.h should
be split in 2: hantro_{g1,h1}_regs.h (g1 being the decoder part and h1
the encoder).
> rename drivers/staging/media/{rockchip/vpu => hantro}/rk3399_vpu_hw.c (69%)
> rename drivers/staging/media/{rockchip/vpu => hantro}/rk3399_vpu_hw_jpeg_enc.c (86%)
> rename drivers/staging/media/{rockchip/vpu => hantro}/rk3399_vpu_hw_mpeg2_dec.c (92%)
> rename drivers/staging/media/{rockchip/vpu => hantro}/rk3399_vpu_regs.h (99%)
Same here, rk3399_vpu_regs.h should be split into hantro_{g2,h2}_regs.h
(I still need to make sure this is actually a g2/h2 combo we have on
this SoC). That's also true for the
rk3399_vpu_hw_{mpeg2_dec,jpeg_enc}.c files: they should be renamed
hantro_{g2_mpeg2_dec,h2_jpeg_enc}.c
> delete mode 100644 drivers/staging/media/rockchip/vpu/Makefile
> delete mode 100644 drivers/staging/media/rockchip/vpu/rockchip_vpu_hw.h
> delete mode 100644 drivers/staging/media/rockchip/vpu/rockchip_vpu_jpeg.h
next prev parent reply other threads:[~2019-06-05 11:22 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 8:55 [PATCH v3 00/10] Rename Rockchip VPU driver to Hantro, add initial i.MX8M support Philipp Zabel
2019-05-31 8:55 ` [PATCH v3 01/10] rockchip/vpu: rename from rockchip to hantro Philipp Zabel
2019-06-05 11:22 ` Boris Brezillon [this message]
2019-06-06 15:06 ` Boris Brezillon
2019-06-11 11:51 ` Philipp Zabel
2019-05-31 8:55 ` [PATCH v3 02/10] media: hantro: print video device name in addition to device node Philipp Zabel
2019-05-31 8:55 ` [PATCH v3 03/10] media: hantro: add PM runtime resume callback Philipp Zabel
2019-05-31 8:55 ` [PATCH v3 04/10] media: hantro: make irq names configurable Philipp Zabel
2019-06-01 9:07 ` Boris Brezillon
2019-05-31 8:55 ` [PATCH v3 05/10] media: hantro: add support for named register ranges Philipp Zabel
2019-06-01 9:14 ` Boris Brezillon
2019-05-31 8:55 ` [PATCH v3 06/10] media: hantro: add support for separate control block Philipp Zabel
2019-06-01 9:16 ` Boris Brezillon
2019-05-31 8:55 ` [PATCH v3 07/10] media: dt-bindings: Document i.MX8MQ and i.MX8MM VPU bindings Philipp Zabel
2019-06-01 9:18 ` Boris Brezillon
2019-06-11 12:44 ` Philipp Zabel
2019-05-31 8:55 ` [PATCH v3 08/10] media: hantro: add initial i.MX8MQ support Philipp Zabel
2019-06-03 12:45 ` Hans Verkuil
2019-06-03 20:02 ` Boris Brezillon
2019-06-04 10:42 ` Hans Verkuil
2019-06-11 11:55 ` Philipp Zabel
2019-12-01 2:16 ` Adam Ford
2019-05-31 8:55 ` [PATCH v3 09/10] media: hantro: add initial i.MX8MM support (untested) Philipp Zabel
2019-06-03 12:54 ` Hans Verkuil
2019-06-03 18:59 ` Nicolas Dufresne
2019-06-03 18:59 ` Nicolas Dufresne
2019-06-11 11:52 ` Philipp Zabel
2019-05-31 8:55 ` [PATCH v3 10/10] media: hantro: allow arbitrary number of clocks Philipp Zabel
2019-06-01 9:23 ` Boris Brezillon
2019-06-03 12:40 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190605132242.102fcdd2@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=jonas@kwiboo.se \
--cc=kernel@pengutronix.de \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).