From: Rob Herring <robh@kernel.org>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: dongchun.zhu@mediatek.com, mchehab@kernel.org,
mark.rutland@arm.com, matthias.bgg@gmail.com,
bingbu.cao@intel.com, srv_heupstream@mediatek.com,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, sj.huang@mediatek.com,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
louis.kuo@mediatek.com, menghui.lin@mediatek.com,
shengnan.wang@mediatek.com
Subject: Re: [PATCH 3/3] media: dt-bindings: media: i2c: Add bindings for ov02a10
Date: Fri, 14 Jun 2019 10:56:03 -0600 [thread overview]
Message-ID: <20190614165603.GA30462@bogus> (raw)
In-Reply-To: <20190531161658.2y2amfngbhfbllj7@valkosipuli.retiisi.org.uk>
On Fri, May 31, 2019 at 07:16:58PM +0300, Sakari Ailus wrote:
> Hi Dongchun,
>
> Thanks for the patch.
>
> On Thu, May 23, 2019 at 06:22:04PM +0800, dongchun.zhu@mediatek.com wrote:
> > From: Dongchun Zhu <dongchun.zhu@mediatek.com>
> >
> > Add device tree binding documentation for the OV02A10 CMOS image sensor.
> >
> > Signed-off-by: Dongchun Zhu <dongchun.zhu@mediatek.com>
> > ---
> > .../devicetree/bindings/media/i2c/ov02a10.txt | 43 ++++++++++++++++++++++
> > 1 file changed, 43 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/media/i2c/ov02a10.txt
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/ov02a10.txt b/Documentation/devicetree/bindings/media/i2c/ov02a10.txt
> > new file mode 100644
> > index 0000000..fdc2904
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/i2c/ov02a10.txt
> > @@ -0,0 +1,43 @@
> > +* Omnivision OV02A10 MIPI CSI-2 sensor
> > +
> > +Required Properties:
> > +- compatible: shall be "ovti,ov02a10"
> > +- clocks: reference to the xvclk input clock
> > +- clock-names: shall be "xvclk"
> > +- avdd-supply: Analog voltage supply, 2.8 volts
> > +- dovdd-supply: Digital I/O voltage supply, 1.8 volts
> > +- dvdd-supply: Digital core voltage supply, 1.8 volts
> > +- reset-gpios: Low active reset gpio
> > +
> > +The device node shall contain one 'port' child node with an
> > +'endpoint' subnode for its digital output video port,
> > +in accordance with the video interface bindings defined in
> > +Documentation/devicetree/bindings/media/video-interfaces.txt.
> > +The endpoint optional property 'data-lanes' shall be "<1>".
>
> If the sensor only supports a single lane configuration (one lane), you can
> omit that property altogether. Is that the only possible configuration for
> the sensor?
>
> Please also wrap the text at 80 characters, not 65 or so.
>
> > +
> > +Example:
> > +&i2c4 {
> > + sensor_sub: sensor_sub {
>
> camera-sensor@3d {
>
> > + compatible = "ovti,ov02a10";
> > + reg = <0x3d>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&camera_pins_cam1_mclk_on>;
> > +
> > + clocks = <&topckgen CLK_TOP_MUX_CAMTG2>,
> > + <&topckgen CLK_TOP_UNIVP_192M_D8>;
> > + clock-names = "xvclk", "freq_mux";
> > +
> > + avdd-supply = <&mt6358_vcama1_reg>;
> > + dvdd-supply = <&mt6358_vcn18_reg>;
> > + dovdd-supply = <&mt6358_vcamio_reg>;
> > + pwdn-gpios = <&pio 107 1>;
> > + reset-gpios = <&pio 109 1>;
> > +
> > + port@0 {
Also, drop the unit-address as there is no 'reg' property. Building your
dts file will 'W=1' will tell you this.
> > + ov02a10_core: endpoint {
> > + remote-endpoint = <&ov02a10_0>;
> > + data-lanes = <1>;
> > + };
>
> Tabs for indentation, please.
>
> > + };
> > + };
> > +};
>
> --
> Kind regards,
>
> Sakari Ailus
prev parent reply other threads:[~2019-06-14 16:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 10:22 [PATCH 0/3] media: suppport ov02a10 sensor driver dongchun.zhu
2019-05-23 10:22 ` [PATCH 1/3] media: i2c: ov02a10: Add ov02a10 camera " dongchun.zhu
2019-05-26 8:53 ` Nicolas Boichat
2019-06-13 2:44 ` Dongchun Zhu
2019-05-28 6:20 ` Bingbu Cao
2019-06-13 3:22 ` Dongchun Zhu
2019-05-31 17:03 ` Sakari Ailus
2019-06-11 14:09 ` Dongchun Zhu
2019-06-26 9:58 ` Sakari Ailus
2019-05-23 10:22 ` [PATCH 2/3] media: i2c: ov02a10: Add CONFIG_VIDEO_OV02A10 dongchun.zhu
2019-05-23 10:22 ` [PATCH 3/3] media: dt-bindings: media: i2c: Add bindings for ov02a10 dongchun.zhu
2019-05-31 16:16 ` Sakari Ailus
2019-06-13 3:30 ` Dongchun Zhu
2019-06-14 16:56 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614165603.GA30462@bogus \
--to=robh@kernel.org \
--cc=bingbu.cao@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dongchun.zhu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=louis.kuo@mediatek.com \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=menghui.lin@mediatek.com \
--cc=sakari.ailus@iki.fi \
--cc=shengnan.wang@mediatek.com \
--cc=sj.huang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).