From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4EDFC48BE4 for ; Thu, 20 Jun 2019 15:26:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 998032084A for ; Thu, 20 Jun 2019 15:26:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727014AbfFTP0v (ORCPT ); Thu, 20 Jun 2019 11:26:51 -0400 Received: from mga03.intel.com ([134.134.136.65]:4413 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726428AbfFTP0v (ORCPT ); Thu, 20 Jun 2019 11:26:51 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jun 2019 08:26:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,397,1557212400"; d="scan'208";a="311692885" Received: from waelreed-mobl1.ger.corp.intel.com (HELO kekkonen.fi.intel.com) ([10.252.63.228]) by orsmga004.jf.intel.com with ESMTP; 20 Jun 2019 08:26:45 -0700 Received: by kekkonen.fi.intel.com (Postfix, from userid 1000) id B5D8D21D88; Thu, 20 Jun 2019 18:26:41 +0300 (EEST) Date: Thu, 20 Jun 2019 18:26:41 +0300 From: Sakari Ailus To: Hugues Fruchet Cc: Alexandre Torgue , Mauro Carvalho Chehab , Hans Verkuil , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Benjamin Gaignard , Yannick Fertre , Philippe CORNU , Mickael GUENE Subject: Re: [PATCH v2 1/3] media: stm32-dcmi: improve sensor subdev naming Message-ID: <20190620152640.chd4u4u5hd56ausk@kekkonen.localdomain> References: <1560242912-17138-1-git-send-email-hugues.fruchet@st.com> <1560242912-17138-2-git-send-email-hugues.fruchet@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1560242912-17138-2-git-send-email-hugues.fruchet@st.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Hugues, On Tue, Jun 11, 2019 at 10:48:30AM +0200, Hugues Fruchet wrote: > Add a new "sensor" field to dcmi struct instead of > reusing entity->subdev to address sensor subdev. The purpose of the struct binding image source's async subdev as well as related information is to allow associating the two. This patch breaks that. If your device can support a single sensor, it might not be a big deal. The end result remains somewhat inconsistent as subdev specific information is spread across struct stm32_dcmi and struct dcmi_graph_entity. In general you don't need to know the sensor as you can always find it using media_entity_remote_pad(). This driver is a little different though as it could presumably continue to work without MC. Was that the intent? On a side note: struct dcmi_graph_entity does NOT have struct v4l2_async_subdev as its first member. Please fix that and prepend the fix to this set. -- Kind regards, Sakari Ailus sakari.ailus@linux.intel.com