linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Ezequiel Garcia <ezequiel@collabora.com>
Cc: kbuild-all@01.org, linux-media@vger.kernel.org,
	Hans Verkuil <hans.verkuil@cisco.com>,
	kernel@collabora.com, Ezequiel Garcia <ezequiel@collabora.com>
Subject: Re: [PATCH] media: hantro: Use vb2_get_buffer
Date: Sat, 22 Jun 2019 05:03:02 +0800	[thread overview]
Message-ID: <201906220553.1Vvz2iJ2%lkp@intel.com> (raw)
In-Reply-To: <20190618231237.27466-1-ezequiel@collabora.com>

[-- Attachment #1: Type: text/plain, Size: 2042 bytes --]

Hi Ezequiel,

I love your patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on next-20190621]
[cannot apply to v5.2-rc5]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Ezequiel-Garcia/media-hantro-Use-vb2_get_buffer/20190622-022557
base:   git://linuxtv.org/media_tree.git master
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   drivers/staging//media/hantro/hantro_drv.c: In function 'hantro_get_ref':
>> drivers/staging//media/hantro/hantro_drv.c:54:8: error: implicit declaration of function 'vb2_get_buffer'; did you mean 'vb2_expbuf'? [-Werror=implicit-function-declaration]
     buf = vb2_get_buffer(q, index);
           ^~~~~~~~~~~~~~
           vb2_expbuf
>> drivers/staging//media/hantro/hantro_drv.c:54:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
     buf = vb2_get_buffer(q, index);
         ^
   cc1: some warnings being treated as errors

vim +54 drivers/staging//media/hantro/hantro_drv.c

    45	
    46	dma_addr_t hantro_get_ref(struct vb2_queue *q, u64 ts)
    47	{
    48		struct vb2_buffer *buf;
    49		int index;
    50	
    51		index = vb2_find_timestamp(q, ts, 0);
    52		if (index < 0)
    53			return 0;
  > 54		buf = vb2_get_buffer(q, index);
    55		return vb2_dma_contig_plane_dma_addr(buf, 0);
    56	}
    57	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 70710 bytes --]

  reply	other threads:[~2019-06-21 21:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-10 20:55 [PATCH v2 0/5] media: Access videobuf2 buffers via an accessor Ezequiel Garcia
2019-06-10 20:55 ` [PATCH v2 1/5] media: vb2: Introduce a vb2_get_buffer accessor Ezequiel Garcia
2019-06-11 12:27   ` Marek Szyprowski
2019-06-10 20:55 ` [PATCH v2 2/5] media: mtk-jpeg: Use vb2_get_buffer Ezequiel Garcia
2019-06-10 20:55 ` [PATCH v2 3/5] media: mtk-vcodec: " Ezequiel Garcia
2019-06-10 20:55 ` [PATCH v2 4/5] media: sti: " Ezequiel Garcia
2019-06-10 20:55 ` [PATCH v2 5/5] media: rockchip: " Ezequiel Garcia
2019-06-14  7:40   ` Hans Verkuil
2019-06-18 23:12     ` [PATCH] media: hantro: " Ezequiel Garcia
2019-06-21 21:03       ` kbuild test robot [this message]
2019-06-22  4:14       ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201906220553.1Vvz2iJ2%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=ezequiel@collabora.com \
    --cc=hans.verkuil@cisco.com \
    --cc=kbuild-all@01.org \
    --cc=kernel@collabora.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).