From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
To: linux-media@vger.kernel.org
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Fabien Dessenne <fabien.dessenne@st.com>
Subject: [PATCH 09/16] bdisp: set device_caps in struct video_device
Date: Wed, 26 Jun 2019 09:44:14 +0200 [thread overview]
Message-ID: <20190626074421.38739-10-hverkuil-cisco@xs4all.nl> (raw)
In-Reply-To: <20190626074421.38739-1-hverkuil-cisco@xs4all.nl>
Instead of filling in the struct v4l2_capability device_caps
field, fill in the struct video_device device_caps field.
That way the V4L2 core knows what the capabilities of the
video device are.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: Fabien Dessenne <fabien.dessenne@st.com>
---
drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c
index 79f7db1a9d18..e90f1ba30574 100644
--- a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c
+++ b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c
@@ -692,11 +692,6 @@ static int bdisp_querycap(struct file *file, void *fh,
strscpy(cap->card, bdisp->pdev->name, sizeof(cap->card));
snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:%s%d",
BDISP_NAME, bdisp->id);
-
- cap->device_caps = V4L2_CAP_STREAMING | V4L2_CAP_VIDEO_M2M;
-
- cap->capabilities = cap->device_caps | V4L2_CAP_DEVICE_CAPS;
-
return 0;
}
@@ -1059,6 +1054,7 @@ static int bdisp_register_device(struct bdisp_dev *bdisp)
bdisp->vdev.lock = &bdisp->lock;
bdisp->vdev.vfl_dir = VFL_DIR_M2M;
bdisp->vdev.v4l2_dev = &bdisp->v4l2_dev;
+ bdisp->vdev.device_caps = V4L2_CAP_STREAMING | V4L2_CAP_VIDEO_M2M;
snprintf(bdisp->vdev.name, sizeof(bdisp->vdev.name), "%s.%d",
BDISP_NAME, bdisp->id);
--
2.20.1
next prev parent reply other threads:[~2019-06-26 7:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 7:44 [PATCH 00/16] media/platform: set device_caps in struct video_device Hans Verkuil
2019-06-26 7:44 ` [PATCH 01/16] am437x/davinci: " Hans Verkuil
2019-07-01 7:30 ` Lad, Prabhakar
2019-06-26 7:44 ` [PATCH 02/16] coda: " Hans Verkuil
2019-06-26 7:49 ` Philipp Zabel
2019-06-26 7:44 ` [PATCH 03/16] s3c-camif/s5p-g2d/s5p-jpeg: " Hans Verkuil
2019-06-26 7:44 ` [PATCH 04/16] fsl-viu: " Hans Verkuil
2019-06-26 7:44 ` [PATCH 05/16] m2m-deinterlace: " Hans Verkuil
2019-06-26 7:44 ` [PATCH 06/16] mx2_emmaprp: " Hans Verkuil
2019-06-26 7:44 ` [PATCH 07/16] marvell-ccic: " Hans Verkuil
2019-06-26 7:44 ` [PATCH 08/16] pxa_camera: " Hans Verkuil
2019-06-26 7:44 ` Hans Verkuil [this message]
2019-06-26 8:06 ` [PATCH 09/16] bdisp: " Fabien DESSENNE
2019-06-26 7:44 ` [PATCH 10/16] via-camera: " Hans Verkuil
2019-06-26 7:44 ` [PATCH 11/16] xilinx: " Hans Verkuil
2019-06-26 9:44 ` Laurent Pinchart
2019-06-26 7:44 ` [PATCH 12/16] sh_veu/sh_vou: " Hans Verkuil
2019-06-26 10:25 ` Jacopo Mondi
2019-06-26 7:44 ` [PATCH 13/16] vsp1: " Hans Verkuil
2019-06-26 9:16 ` Laurent Pinchart
2019-06-26 7:44 ` [PATCH 14/16] omap_vout: " Hans Verkuil
2019-06-26 7:44 ` [PATCH 15/16] ti-vpe: " Hans Verkuil
2019-06-26 14:34 ` Benoit Parrot
2019-06-26 7:44 ` [PATCH 16/16] omap3isp: " Hans Verkuil
2019-06-26 9:25 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190626074421.38739-10-hverkuil-cisco@xs4all.nl \
--to=hverkuil-cisco@xs4all.nl \
--cc=fabien.dessenne@st.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).