linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] regmap: select CONFIG_REGMAP while REGMAP_SCCB is set
@ 2019-07-04  9:35 YueHaibing
  2019-07-04 12:24 ` Applied "regmap: select CONFIG_REGMAP while REGMAP_SCCB is set" to the regmap tree Mark Brown
  2019-07-04 13:49 ` [PATCH] regmap: select CONFIG_REGMAP while REGMAP_SCCB is set Akinobu Mita
  0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2019-07-04  9:35 UTC (permalink / raw)
  To: broonie, gregkh, rafael, akinobu.mita, wsa+renesas, sakari.ailus,
	mchehab+samsung, jacopo, khoroshilov
  Cc: linux-kernel, linux-media, YueHaibing

REGMAP_SCCB is selected by ov772x and ov9650 drivers,
but CONFIG_REGMAP may not, so building will fails:

rivers/media/i2c/ov772x.c: In function ov772x_probe:
drivers/media/i2c/ov772x.c:1360:22: error: variable ov772x_regmap_config has initializer but incomplete type
  static const struct regmap_config ov772x_regmap_config = {
                      ^~~~~~~~~~~~~
drivers/media/i2c/ov772x.c:1361:4: error: const struct regmap_config has no member named reg_bits

Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 5bbf32217bf9 ("media: ov772x: use SCCB regmap")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/base/regmap/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig
index c8bbf53..a498413 100644
--- a/drivers/base/regmap/Kconfig
+++ b/drivers/base/regmap/Kconfig
@@ -4,7 +4,7 @@
 # subsystems should select the appropriate symbols.
 
 config REGMAP
-	default y if (REGMAP_I2C || REGMAP_SPI || REGMAP_SPMI || REGMAP_W1 || REGMAP_AC97 || REGMAP_MMIO || REGMAP_IRQ || REGMAP_I3C)
+	default y if (REGMAP_I2C || REGMAP_SPI || REGMAP_SPMI || REGMAP_W1 || REGMAP_AC97 || REGMAP_MMIO || REGMAP_IRQ || REGMAP_SCCB || REGMAP_I3C)
 	select IRQ_DOMAIN if REGMAP_IRQ
 	bool
 
-- 
2.7.4



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Applied "regmap: select CONFIG_REGMAP while REGMAP_SCCB is set" to the regmap tree
  2019-07-04  9:35 [PATCH] regmap: select CONFIG_REGMAP while REGMAP_SCCB is set YueHaibing
@ 2019-07-04 12:24 ` Mark Brown
  2019-07-04 13:49 ` [PATCH] regmap: select CONFIG_REGMAP while REGMAP_SCCB is set Akinobu Mita
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2019-07-04 12:24 UTC (permalink / raw)
  To: YueHaibing
  Cc: akinobu.mita, broonie, gregkh, Hulk Robot, jacopo, khoroshilov,
	linux-kernel, linux-media, Mark Brown, mchehab+samsung, rafael,
	sakari.ailus, wsa+renesas

The patch

   regmap: select CONFIG_REGMAP while REGMAP_SCCB is set

has been applied to the regmap tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git for-5.3

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

From eff5a850017193ae879948944be05cc814c29621 Mon Sep 17 00:00:00 2001
From: YueHaibing <yuehaibing@huawei.com>
Date: Thu, 4 Jul 2019 17:35:53 +0800
Subject: [PATCH] regmap: select CONFIG_REGMAP while REGMAP_SCCB is set

REGMAP_SCCB is selected by ov772x and ov9650 drivers,
but CONFIG_REGMAP may not, so building will fails:

rivers/media/i2c/ov772x.c: In function ov772x_probe:
drivers/media/i2c/ov772x.c:1360:22: error: variable ov772x_regmap_config has initializer but incomplete type
  static const struct regmap_config ov772x_regmap_config = {
                      ^~~~~~~~~~~~~
drivers/media/i2c/ov772x.c:1361:4: error: const struct regmap_config has no member named reg_bits

Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 5bbf32217bf9 ("media: ov772x: use SCCB regmap")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Link: https://lore.kernel.org/r/20190704093553.49904-1-yuehaibing@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/base/regmap/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig
index c8bbf5322720..a4984136c19d 100644
--- a/drivers/base/regmap/Kconfig
+++ b/drivers/base/regmap/Kconfig
@@ -4,7 +4,7 @@
 # subsystems should select the appropriate symbols.
 
 config REGMAP
-	default y if (REGMAP_I2C || REGMAP_SPI || REGMAP_SPMI || REGMAP_W1 || REGMAP_AC97 || REGMAP_MMIO || REGMAP_IRQ || REGMAP_I3C)
+	default y if (REGMAP_I2C || REGMAP_SPI || REGMAP_SPMI || REGMAP_W1 || REGMAP_AC97 || REGMAP_MMIO || REGMAP_IRQ || REGMAP_SCCB || REGMAP_I3C)
 	select IRQ_DOMAIN if REGMAP_IRQ
 	bool
 
-- 
2.20.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] regmap: select CONFIG_REGMAP while REGMAP_SCCB is set
  2019-07-04  9:35 [PATCH] regmap: select CONFIG_REGMAP while REGMAP_SCCB is set YueHaibing
  2019-07-04 12:24 ` Applied "regmap: select CONFIG_REGMAP while REGMAP_SCCB is set" to the regmap tree Mark Brown
@ 2019-07-04 13:49 ` Akinobu Mita
  1 sibling, 0 replies; 3+ messages in thread
From: Akinobu Mita @ 2019-07-04 13:49 UTC (permalink / raw)
  To: YueHaibing
  Cc: Mark Brown, Greg Kroah-Hartman, rafael, wsa+renesas,
	Sakari Ailus, Mauro Carvalho Chehab, Jacopo Mondi, khoroshilov,
	LKML, Linux Media Mailing List

2019年7月4日(木) 18:36 YueHaibing <yuehaibing@huawei.com>:
>
> REGMAP_SCCB is selected by ov772x and ov9650 drivers,
> but CONFIG_REGMAP may not, so building will fails:
>
> rivers/media/i2c/ov772x.c: In function ov772x_probe:
> drivers/media/i2c/ov772x.c:1360:22: error: variable ov772x_regmap_config has initializer but incomplete type
>   static const struct regmap_config ov772x_regmap_config = {
>                       ^~~~~~~~~~~~~
> drivers/media/i2c/ov772x.c:1361:4: error: const struct regmap_config has no member named reg_bits
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 5bbf32217bf9 ("media: ov772x: use SCCB regmap")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/base/regmap/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig
> index c8bbf53..a498413 100644
> --- a/drivers/base/regmap/Kconfig
> +++ b/drivers/base/regmap/Kconfig
> @@ -4,7 +4,7 @@
>  # subsystems should select the appropriate symbols.
>
>  config REGMAP
> -       default y if (REGMAP_I2C || REGMAP_SPI || REGMAP_SPMI || REGMAP_W1 || REGMAP_AC97 || REGMAP_MMIO || REGMAP_IRQ || REGMAP_I3C)
> +       default y if (REGMAP_I2C || REGMAP_SPI || REGMAP_SPMI || REGMAP_W1 || REGMAP_AC97 || REGMAP_MMIO || REGMAP_IRQ || REGMAP_SCCB || REGMAP_I3C)
>         select IRQ_DOMAIN if REGMAP_IRQ
>         bool

Looks good.

Reviewed-by: Akinobu Mita <akinobu.mita@gmail.com>

A similar problem exists for REGMAP_SOUNDWIRE. But I can't find any users
of regmap_init_sdw (i.e. REGMAP_SOUNDWIRE).

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-07-04 13:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-04  9:35 [PATCH] regmap: select CONFIG_REGMAP while REGMAP_SCCB is set YueHaibing
2019-07-04 12:24 ` Applied "regmap: select CONFIG_REGMAP while REGMAP_SCCB is set" to the regmap tree Mark Brown
2019-07-04 13:49 ` [PATCH] regmap: select CONFIG_REGMAP while REGMAP_SCCB is set Akinobu Mita

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).