From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B538C606A7 for ; Mon, 8 Jul 2019 10:04:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0834D20644 for ; Mon, 8 Jul 2019 10:04:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729289AbfGHKE5 (ORCPT ); Mon, 8 Jul 2019 06:04:57 -0400 Received: from gofer.mess.org ([88.97.38.141]:34733 "EHLO gofer.mess.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728596AbfGHKE5 (ORCPT ); Mon, 8 Jul 2019 06:04:57 -0400 Received: by gofer.mess.org (Postfix, from userid 1000) id 44C4760991; Mon, 8 Jul 2019 11:04:55 +0100 (BST) Date: Mon, 8 Jul 2019 11:04:55 +0100 From: Sean Young To: JP Cc: linux-media@vger.kernel.org, Michael Ira Krufky , Antti Palosaari , Frantisek Rysanek Subject: Re: [PATCH 1/2] dvbsky: add support for "Mygica T230C v2" Message-ID: <20190708100454.xwa4f64umoccwvca@gofer.mess.org> References: <20190616003929.GE4518@jpvw.nl> <20190625111615.s5kifm6nb2lafiw4@gofer.mess.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hallo Jan-Pieter, > On 6/25/19 1:16 PM, Sean Young wrote: > > On Sun, Jun 16, 2019 at 02:39:29AM +0200, Jan Pieter van Woerkom wrote: > > > From: Jan Pieter van Woerkom > > > > > > Adds support for the "Mygica T230C v2" into the "dvbsky" driver. > > > A small enhancement is also needed in the si2168 demodulator > > > driver, and a USB device ID in dvb-usb-ids.h . > > > > > > This is v3.3 of the proposed patch, based on feedback from Sean > > > Young and Antti Palosaari. > > > Tested by patch author on a T230C v2. > > > Tested by Frank Rysanek on a T230C v2: can tune into locally > > > available DVB-T and DVB-T2 muxes, video and audio playback works. > > > Applies cleanly against Linux 5.1.10 . > > > > > > The T230C v2 hardware needs a mode of the si2168 chip to be > > > set for which the si2168 driver previously had no support. > > > This patch uses a specific measure to configure this on the > > > T230C v2 hardware only - see the flag passed via the ts_mode > > > attribute and its dependency on USB_PID_MYGICA_T230C2. Other > > > devices using the si2168 demodulator driver are not affected > > > in any way. > > > > > > Signed-off-by: Jan Pieter van Woerkom > > > Tested-by: Frank Rysanek > > > --- > > > diff -ru a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c > > > --- a/drivers/media/dvb-frontends/si2168.c 2019-06-04 07:59:45.000000000 +0200 > > > +++ b/drivers/media/dvb-frontends/si2168.c 2019-06-08 19:47:32.385526558 +0200 > > > @@ -91,8 +91,18 @@ > > > dev_dbg(&client->dev, "%s acquire: %d\n", __func__, acquire); > > > + /* set manual value */ > > > + if (dev->ts_mode | SI2168_TS_CLK_MANUAL) { > > This looks wrong. Should it not be "dev->ts_mode & SI2168_TS_CLK_MANUAL"? > > Now the expression is always true. > You're absolutely right. Silly me. > > What now? Correct and repost? Yes, please. I don't have the hardware to test so it would be great if you could repost a tested version, so we can merged that. Thanks, Sean