From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C865DC76191 for ; Mon, 15 Jul 2019 14:44:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 934C320651 for ; Mon, 15 Jul 2019 14:44:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563201844; bh=UYwo621DI9NLlrTb7Ku5Fm0Q1ZvTUXbC+RpfFF13Y0k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=GF2g0x04/PLjX510rYwnkT6zSkl4k3tU0TCb9Z4BsA6rovliEDP3XLW+yatYkbj3M G1ucYZUHp2jCri/P1x2xz2OD3J2qBzZ1DAvzpT16v5E0Gcw5Wjypcq7Hg1DoUKDSwb 7Gu3uqKvXfjDqbhliJi4zJkhldshspGgp6YJ9Vj4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404315AbfGOOoC (ORCPT ); Mon, 15 Jul 2019 10:44:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:60006 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391938AbfGOOhn (ORCPT ); Mon, 15 Jul 2019 10:37:43 -0400 Received: from sasha-vm.mshome.net (unknown [73.61.17.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BB5D1204FD; Mon, 15 Jul 2019 14:37:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563201462; bh=UYwo621DI9NLlrTb7Ku5Fm0Q1ZvTUXbC+RpfFF13Y0k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bCQc/lRuAid/Q2Kk04WTnc84k829fng3LidJIACyWgJnlEZKeJ+Ik9s4faLQ3vh+y OIQxjXu7w7Y5oFJFR07DtE/5ZAUQZwBk0Dpq2atFx6RxB0Pad0Qooh7wehK2JgIlZ9 ZpN3mgxridYc0zK3Bb87OT4n9i5S2oiZig+Up2+Q= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Hans Verkuil , Hans Verkuil , Sakari Ailus , Mauro Carvalho Chehab , Sasha Levin , linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 19/73] media: mc-device.c: don't memset __user pointer contents Date: Mon, 15 Jul 2019 10:35:35 -0400 Message-Id: <20190715143629.10893-19-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190715143629.10893-1-sashal@kernel.org> References: <20190715143629.10893-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Hans Verkuil [ Upstream commit 518fa4e0e0da97ea2e17c95ab57647ce748a96e2 ] You can't memset the contents of a __user pointer. Instead, call copy_to_user to copy links.reserved (which is zeroed) to the user memory. This fixes this sparse warning: SPARSE:drivers/media/mc/mc-device.c drivers/media/mc/mc-device.c:521:16: warning: incorrect type in argument 1 (different address spaces) Fixes: f49308878d720 ("media: media_device_enum_links32: clean a reserved field") Signed-off-by: Hans Verkuil Reviewed-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/media-device.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c index 6062c0cfa632..73a2dba475d0 100644 --- a/drivers/media/media-device.c +++ b/drivers/media/media-device.c @@ -490,8 +490,9 @@ static long media_device_enum_links32(struct media_device *mdev, if (ret) return ret; - memset(ulinks->reserved, 0, sizeof(ulinks->reserved)); - + if (copy_to_user(ulinks->reserved, links.reserved, + sizeof(ulinks->reserved))) + return -EFAULT; return 0; } -- 2.20.1