From: Ezequiel Garcia <ezequiel@collabora.com>
To: Hans Verkuil <hans.verkuil@cisco.com>
Cc: kernel@collabora.com, linux-media@vger.kernel.org,
Ezequiel Garcia <ezequiel@collabora.com>
Subject: [PATCH 0/6] V4L2 core I2C/SPI code cleanup
Date: Mon, 15 Jul 2019 18:06:41 -0300 [thread overview]
Message-ID: <20190715210649.31681-1-ezequiel@collabora.com> (raw)
Hi Mauro, Hans:
While reading v4l2-common.c, I came across a few ifdefs
that could be cleaned-up with some minor reorganization.
Patch 1 is just cleaning the Makefile, removing ifeq/endif
to make it more readable.
Patch 2 merges v4l2-common.ko into videodev.ko, which
I think it's now possible. Let me know if having
these two modules separated serves a purpose
I'm missing.
The rest of the patches split the I2C and SPI helpers,
so they can be conditionally built.
There are a few checkpatch.pl issues triggered here,
all of them belonging to the already existing code.
Let me know if you want me to clean that as well.
The entire series should not affect any functionality,
but just clean-up the code a bit.
Thanks,
Eze
Ezequiel Garcia (6):
media: v4l2-core: Cleanup Makefile
media: v4l2-core: Module re-organization
media: v4l2-core: move spi helpers out of v4l2-common.c
media: v4l2-core: move i2c helpers out of v4l2-common.c
media: v4l2-core: introduce a helper to unregister a SPI subdev
media: v4l2-core: introduce a helper to unregister a I2C subdev
drivers/media/v4l2-core/Kconfig | 5 +
drivers/media/v4l2-core/Makefile | 15 +-
drivers/media/v4l2-core/v4l2-common.c | 210 --------------------------
drivers/media/v4l2-core/v4l2-device.c | 39 +----
drivers/media/v4l2-core/v4l2-i2c.c | 167 ++++++++++++++++++++
drivers/media/v4l2-core/v4l2-spi.c | 73 +++++++++
include/media/v4l2-common.h | 150 +++++++++++++-----
7 files changed, 366 insertions(+), 293 deletions(-)
create mode 100644 drivers/media/v4l2-core/v4l2-i2c.c
create mode 100644 drivers/media/v4l2-core/v4l2-spi.c
--
2.22.0
next reply other threads:[~2019-07-15 21:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 21:06 Ezequiel Garcia [this message]
2019-07-15 21:06 ` [PATCH 1/6] media: v4l2-core: Cleanup Makefile Ezequiel Garcia
2019-07-15 21:06 ` [PATCH 2/6] media: v4l2-core: Module re-organization Ezequiel Garcia
2019-07-25 16:31 ` Mauro Carvalho Chehab
2019-07-25 16:41 ` Ezequiel Garcia
2019-07-25 17:03 ` Mauro Carvalho Chehab
2019-07-25 17:07 ` Ezequiel Garcia
2019-07-15 21:06 ` [PATCH 3/6] media: v4l2-core: move spi helpers out of v4l2-common.c Ezequiel Garcia
2019-07-15 21:06 ` [PATCH 4/6] media: v4l2-core: move i2c " Ezequiel Garcia
2019-07-15 21:06 ` [PATCH 5/6] media: v4l2-core: introduce a helper to unregister a SPI subdev Ezequiel Garcia
2019-07-15 21:06 ` [PATCH 5/6] media: v4l2-core: introduce an unregister spi subdev helper Ezequiel Garcia
2019-07-15 21:06 ` [PATCH 6/6] media: v4l2-core: introduce a helper to unregister a I2C subdev Ezequiel Garcia
2019-07-15 21:06 ` [PATCH 6/6] media: v4l2-core: introduce unregister subdev i2c helper Ezequiel Garcia
2019-07-25 15:06 ` [PATCH 0/6] V4L2 core I2C/SPI code cleanup Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190715210649.31681-1-ezequiel@collabora.com \
--to=ezequiel@collabora.com \
--cc=hans.verkuil@cisco.com \
--cc=kernel@collabora.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).