linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sean Young <sean@mess.org>
To: Jan Pieter van Woerkom <jp@jpvw.nl>
Cc: linux-media@vger.kernel.org,
	Michael Ira Krufky <mkrufky@linuxtv.org>,
	Antti Palosaari <crope@iki.fi>,
	Frantisek Rysanek <Frantisek.Rysanek@post.cz>
Subject: Re: [PATCH V3.6 2/2] linux-media: dvbsky: add support for Mygica T230C v2
Date: Wed, 17 Jul 2019 20:25:48 +0100	[thread overview]
Message-ID: <20190717192548.6d4jsyfbkj3y2z6w@gofer.mess.org> (raw)
In-Reply-To: <20190717181150.GB5495@jpvw.nl>

On Wed, Jul 17, 2019 at 08:11:50PM +0200, Jan Pieter van Woerkom wrote:
> The T230C v2 hardware needs a mode of the si2168 chip to be
> set for which the si2168 driver previously had no support.
> This patch uses a specific measure to configure this on the
> T230C v2 hardware only - see the flag passed via the ts_mode
> attribute and its dependency on USB_PID_MYGICA_T230C2.
> 
> Signed-off-by: Jan Pieter van Woerkom <jp@jpvw.nl>
> Tested-by: Frank Rysanek <Frantisek.Rysanek@post.cz>
> ---
> diff -ru a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c
> --- a/drivers/media/dvb-frontends/si2168.c	2019-07-08 00:41:56.000000000 +0200
> +++ b/drivers/media/dvb-frontends/si2168.c	2019-07-16 21:21:39.267802750 +0200
> @@ -82,8 +82,18 @@
>  
>  	dev_dbg(&client->dev, "%s acquire: %d\n", __func__, acquire);
>  
> +	/* set manual value */
> +	if (dev->ts_mode & SI2168_TS_CLK_MANUAL) {
> +		memcpy(cmd.args, "\x14\x00\x0d\x10\xe8\x03", 6);
> +		cmd.wlen = 6;
> +		cmd.rlen = 4;
> +		ret = si2168_cmd_execute(client, &cmd);
> +		if (ret)
> +			return ret;
> +	}
>  	/* set TS_MODE property */
>  	memcpy(cmd.args, "\x14\x00\x01\x10\x10\x00", 6);
> +	cmd.args[4] <<= (dev->ts_mode & SI2168_TS_CLK_MANUAL) >> 5;

I'm sorry but this is not very readable. How about:

	if (dev->ts_mode & SI2168_TS_CLK_MANUAL)
		cmd.args[4] = SI2168_TS_CLK_MANUAL;

?

Sean

>  	if (acquire)
>  		cmd.args[4] |= dev->ts_mode;
>  	else
> diff -ru a/drivers/media/dvb-frontends/si2168.h b/drivers/media/dvb-frontends/si2168.h
> --- a/drivers/media/dvb-frontends/si2168.h	2019-07-08 00:41:56.000000000 +0200
> +++ b/drivers/media/dvb-frontends/si2168.h	2019-07-16 06:29:53.913009262 +0200
> @@ -30,6 +30,7 @@
>  #define SI2168_TS_PARALLEL	0x06
>  #define SI2168_TS_SERIAL	0x03
>  #define SI2168_TS_TRISTATE	0x00
> +#define SI2168_TS_CLK_MANUAL	0x20
>  	u8 ts_mode;
>  
>  	/* TS clock inverted */

  reply	other threads:[~2019-07-17 19:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-17 18:05 [PATCH V3.6 0/2] " Jan Pieter van Woerkom
2019-07-17 18:09 ` [PATCH V3.6 1/2] " Jan Pieter van Woerkom
2019-07-17 18:11 ` [PATCH V3.6 2/2] " Jan Pieter van Woerkom
2019-07-17 19:25   ` Sean Young [this message]
2019-07-18  0:29     ` JP
2019-07-18  0:36 ` [PATCH V3.6.1 " Jan Pieter van Woerkom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190717192548.6d4jsyfbkj3y2z6w@gofer.mess.org \
    --to=sean@mess.org \
    --cc=Frantisek.Rysanek@post.cz \
    --cc=crope@iki.fi \
    --cc=jp@jpvw.nl \
    --cc=linux-media@vger.kernel.org \
    --cc=mkrufky@linuxtv.org \
    --subject='Re: [PATCH V3.6 2/2] linux-media: dvbsky: add support for Mygica T230C v2' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).