From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E8B1C433FF for ; Fri, 9 Aug 2019 07:20:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3C51B2166E for ; Fri, 9 Aug 2019 07:20:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405750AbfHIHUj (ORCPT ); Fri, 9 Aug 2019 03:20:39 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:33045 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726212AbfHIHUj (ORCPT ); Fri, 9 Aug 2019 03:20:39 -0400 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hvzCQ-0004x5-V9; Fri, 09 Aug 2019 09:20:30 +0200 Received: from mfe by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1hvzCO-0001q6-FN; Fri, 09 Aug 2019 09:20:28 +0200 Date: Fri, 9 Aug 2019 09:20:28 +0200 From: Marco Felsch To: Hans Verkuil Cc: mchehab@kernel.org, sakari.ailus@linux.intel.com, hans.verkuil@cisco.com, jacopo+renesas@jmondi.org, robh+dt@kernel.org, laurent.pinchart@ideasonboard.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Jacopo Mondi Subject: Re: [PATCH v6 02/13] media: v4l2-fwnode: add v4l2_fwnode_connector Message-ID: <20190809072028.tonmezl4zwg72fwv@pengutronix.de> References: <20190415124413.18456-1-m.felsch@pengutronix.de> <20190415124413.18456-3-m.felsch@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:17:50 up 83 days, 13:35, 55 users, load average: 0.21, 0.10, 0.03 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-media@vger.kernel.org Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On 19-05-06 11:50, Hans Verkuil wrote: > On 4/15/19 2:44 PM, Marco Felsch wrote: > > Currently every driver needs to parse the connector endpoints by it self. > > This is the initial work to make this generic. The generic connector has > > some common fields and some connector specific parts. The generic one > > includes: > > - type > > - label > > - remote_port (the port where the connector is connected to) > > - remote_id (the endpoint where the connector is connected to) > > > > The specific fields are within a union, since only one of them can be > > available at the time. Since this is the initial support the patch adds > > only the analog-connector specific ones. > > > > Signed-off-by: Marco Felsch > > Reviewed-by: Jacopo Mondi > > --- > > [1] https://patchwork.kernel.org/cover/10794703/ > > > > v6: > > - fix some spelling and style issues > > - rm unnecessary comments > > - drop vga and dvi connector > > > > v2-v4: > > - nothing since the patch was squashed from series [1] into this > > series. > > > > include/media/v4l2-connector.h | 30 ++++++++++++++++++++++++++++++ > > include/media/v4l2-fwnode.h | 33 +++++++++++++++++++++++++++++++++ > > 2 files changed, 63 insertions(+) > > create mode 100644 include/media/v4l2-connector.h > > > > diff --git a/include/media/v4l2-connector.h b/include/media/v4l2-connector.h > > new file mode 100644 > > index 000000000000..3a951c54f50e > > --- /dev/null > > +++ b/include/media/v4l2-connector.h > > @@ -0,0 +1,30 @@ > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > +/* > > + * v4l2-connector.h > > + * > > + * V4L2 connector types. > > + * > > + * Copyright 2019 Pengutronix, Marco Felsch > > + */ > > + > > +#ifndef V4L2_CONNECTOR_H > > +#define V4L2_CONNECTOR_H > > + > > +#define V4L2_CONNECTOR_MAX_LABEL 41 > > Where does 41 come from? It's a weird number... What would you suggest? > > > + > > +/** > > + * enum v4l2_connector_type - connector type > > + * @V4L2_CON_UNKNOWN: unknown connector type, no V4L2 connetor configuration > > typo: connetor -> connector > > > + * @V4L2_CON_COMPOSITE: analog composite connector > > + * @V4L2_CON_SVIDEO: analog svideo connector > > + * @V4L2_CON_HDMI: digital hdmi connector > > + */ > > +enum v4l2_connector_type { > > + V4L2_CON_UNKNOWN, > > + V4L2_CON_COMPOSITE, > > + V4L2_CON_SVIDEO, > > + V4L2_CON_HDMI, > > +}; > > + > > +#endif /* V4L2_CONNECTOR_H */ > > + > > Is there a reason to create a new header for this? I think it is perfectly OK to > add this define + enum for v4l2-fwnode.h. Okay, I can squash it. > > > diff --git a/include/media/v4l2-fwnode.h b/include/media/v4l2-fwnode.h > > index 6c07825e18b9..f4df1b95c5ef 100644 > > --- a/include/media/v4l2-fwnode.h > > +++ b/include/media/v4l2-fwnode.h > > @@ -22,6 +22,7 @@ > > #include > > #include > > > > +#include > > #include > > #include > > > > @@ -126,6 +127,38 @@ struct v4l2_fwnode_link { > > unsigned int remote_port; > > }; > > > > +/** > > + * struct v4l2_fwnode_connector_analog - analog connector data structure > > + * @supported_tvnorms: tv norms this connector supports, set to V4L2_STD_ALL > > + * if no restrictions are specified. > > + */ > > +struct v4l2_fwnode_connector_analog { > > + v4l2_std_id supported_tvnorms; > > +}; > > + > > +/** > > + * struct v4l2_fwnode_connector - the connector data structure > > + * @remote_port: identifier of the remote endpoint port the connector connects > > + * to > > + * @remote_id: identifier of the remote endpoint the connector connects to > > + * @label: connetor label > > Same typo. It's probably a good idea to grep for this typo in this patch series :-) I will grep it shortly before I send the new v7 ;-) Regards, Marco > > > + * @type: connector type > > + * @connector: connector configuration > > + * @connector.analog: analog connector configuration > > + * &struct v4l2_fwnode_connector_analog > > + */ > > +struct v4l2_fwnode_connector { > > + unsigned int remote_port; > > + unsigned int remote_id; > > + char label[V4L2_CONNECTOR_MAX_LABEL]; > > + enum v4l2_connector_type type; > > + > > + union { > > + struct v4l2_fwnode_connector_analog analog; > > + /* future connectors */ > > + } connector; > > +}; > > + > > /** > > * v4l2_fwnode_endpoint_parse() - parse all fwnode node properties > > * @fwnode: pointer to the endpoint's fwnode handle > > > > Regards, > > Hans > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |