Re: [PATCH v2 2/3] [media] mceusb: Reword messages referring to "urb"

[Sean Young <sean@mess.org>]

Hi,

On Sun, Jul 21, 2019 at 05:31:55PM -0400, A Sun wrote:
> FYI, I'm in progress on another mceusb patch to fix, and eliminate, the driver's
> TX IR length limits. Limit causes -EINVAL errors for > ~300 pulse/space samples and
> I've seen reports (and patches for) of appliances with IR over 400 pulse/spaces.

This always looked like it needed improvement. Thank you!

> 
> The future patch rewrites:
>   mceusb_tx_ir()
> And revises "write/tx" async I/O to sync I/O to do unlimited multipart TX IR.
> These functions will need rewrite and rename:
>   mce_async_callback() -> mce_tx_callback()
>   mce_request_packet() -> mce_tx()
> The present mce_async_out() name will become misleading. mce_command_out()
> or mce_request_out() (which calls mce_tx()), are probably better names.
> 
> I'm still mulling over whether the more generic "read/write" term
> (e.g. mce_write() and mce_write_callback()) may be a better migration path,
> for future work.

Thanks.

Another thing the mceusb driver could do with is usb wakeup. I've hadn't
had the time to look at that.


Sean