Re: [PATCH 2/2] omap3isp: Don't set streaming state on random subdevs

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Sakari,

Thank you for the patch.

On Mon, Aug 12, 2019 at 11:32:27AM +0300, Sakari Ailus wrote:
> The streaming state should be set to the first upstream sub-device only,
> not everywhere, for a sub-device driver itself knows how to best control
> the streaming state of its own upstream sub-devices.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/media/platform/omap3isp/isp.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c
> index 008933beebe0..52533cdafb47 100644
> --- a/drivers/media/platform/omap3isp/isp.c
> +++ b/drivers/media/platform/omap3isp/isp.c
> @@ -722,6 +722,10 @@ static int isp_pipeline_enable(struct isp_pipeline *pipe,
>  					s_stream, mode);
>  			pipe->do_propagation = true;
>  		}
> +
> +		/* Stop at the first external sub-device. */
> +		if (subdev->dev != isp->dev)
> +			break;
>  	}
>  
>  	return 0;
> @@ -836,6 +840,10 @@ static int isp_pipeline_disable(struct isp_pipeline *pipe)
>  						      &subdev->entity);
>  			failure = -ETIMEDOUT;
>  		}
> +
> +		/* Stop at the first external sub-device. */
> +		if (subdev->dev != isp->dev)
> +			break;
>  	}
>  
>  	return failure;

-- 
Regards,

Laurent Pinchart