linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marco Felsch <m.felsch@pengutronix.de>
To: mchehab@kernel.org, sakari.ailus@linux.intel.com,
	hans.verkuil@cisco.com, jacopo+renesas@jmondi.org,
	robh+dt@kernel.org, laurent.pinchart@ideasonboard.com
Cc: devicetree@vger.kernel.org, kernel@pengutronix.de,
	linux-media@vger.kernel.org, Jacopo Mondi <jacopo@jmondi.org>
Subject: [PATCH v8 13/13] media: tvp5150: make debug output more readable
Date: Wed, 21 Aug 2019 09:31:03 +0200	[thread overview]
Message-ID: <20190821073103.19634-14-m.felsch@pengutronix.de> (raw)
In-Reply-To: <20190821073103.19634-1-m.felsch@pengutronix.de>

The debug output for tvp5150_selmux() isn't really intuitive. Register
values are printed decimal formatted and the input/output driver states
are printed as enum. Even more the "normal" output enum mapps to zero so
a active output will printing output=0 and a inactive output=1.

Change this by brinting the register values hex formatted and the states
as more readable string.

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
---
 drivers/media/i2c/tvp5150.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index b48b08421993..240df920b521 100644
--- a/drivers/media/i2c/tvp5150.c
+++ b/drivers/media/i2c/tvp5150.c
@@ -300,9 +300,12 @@ static void tvp5150_selmux(struct v4l2_subdev *sd)
 		break;
 	}
 
-	dev_dbg_lvl(sd->dev, 1, debug, "Selecting video route: route input=%i, output=%i => tvp5150 input=%i, opmode=%i\n",
-			decoder->input, decoder->output,
-			input, opmode);
+	dev_dbg_lvl(sd->dev, 1, debug,
+		    "Selecting video route: route input=%s, output=%s => tvp5150 input=0x%02x, opmode=0x%02x\n",
+		    decoder->input == 0 ? "aip1a" :
+		    decoder->input == 2 ? "aip1b" : "svideo",
+		    decoder->output == 0 ? "normal" : "black-frame-gen",
+		    input, opmode);
 
 	regmap_write(decoder->regmap, TVP5150_OP_MODE_CTL, opmode);
 	regmap_write(decoder->regmap, TVP5150_VD_IN_SRC_SEL_1, input);
-- 
2.20.1


      parent reply	other threads:[~2019-08-21  7:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-21  7:30 [PATCH v8 00/13] Add TVP5150 features Marco Felsch
2019-08-21  7:30 ` [PATCH v8 01/13] dt-bindings: connector: analog: add sdtv standards property Marco Felsch
2019-08-21  7:30 ` [PATCH v8 02/13] media: v4l2-fwnode: add v4l2_fwnode_connector Marco Felsch
2019-08-21  7:30 ` [PATCH v8 03/13] media: v4l2-fwnode: add initial connector parsing support Marco Felsch
2019-08-21  7:30 ` [PATCH v8 04/13] partial revert of "[media] tvp5150: add HW input connectors support" Marco Felsch
2019-08-21  7:30 ` [PATCH v8 05/13] media: tvp5150: add input source selection of_graph support Marco Felsch
2019-08-21  7:30 ` [PATCH v8 06/13] media: dt-bindings: tvp5150: Add input port connectors DT bindings Marco Felsch
2019-08-21  7:30 ` [PATCH v8 07/13] media: tvp5150: add FORMAT_TRY support for get/set selection handlers Marco Felsch
2019-08-21  7:30 ` [PATCH v8 08/13] media: tvp5150: initialize subdev before parsing device tree Marco Felsch
2019-08-21  7:30 ` [PATCH v8 09/13] media: tvp5150: add s_power callback Marco Felsch
2019-08-21  7:31 ` [PATCH v8 10/13] media: dt-bindings: tvp5150: cleanup bindings stlye Marco Felsch
2019-08-21  7:31 ` [PATCH v8 11/13] media: dt-bindings: tvp5150: add optional sdtv standards documentation Marco Felsch
2019-08-21  7:31 ` [PATCH v8 12/13] media: tvp5150: add support to limit sdtv standards Marco Felsch
2019-08-21  7:31 ` Marco Felsch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190821073103.19634-14-m.felsch@pengutronix.de \
    --to=m.felsch@pengutronix.de \
    --cc=devicetree@vger.kernel.org \
    --cc=hans.verkuil@cisco.com \
    --cc=jacopo+renesas@jmondi.org \
    --cc=jacopo@jmondi.org \
    --cc=kernel@pengutronix.de \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).