From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EE61C3A5A0 for ; Wed, 21 Aug 2019 20:18:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0850D22CF7 for ; Wed, 21 Aug 2019 20:18:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566418684; bh=C0RD8lu1UwnKunJJZa5WPHrF+ZUXqJwm0MHuvEMpfrs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=z+z2acqjCscugseGKVtqXWuP3kLG40mXZnVlP9tyiX3v/TCarIEp3gTkpi4OwfbD1 30UD87XE2KTZMH3WPveVKt8taHw4igMNDpAA8D6xDKhsMnj18W8gKFq8QLNs2R4Lti foWX793zUBemuZPoq/yLXk5r/HiMqhNEjzmWj24w= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730486AbfHUUSB (ORCPT ); Wed, 21 Aug 2019 16:18:01 -0400 Received: from mail-ot1-f68.google.com ([209.85.210.68]:45745 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729467AbfHUUSB (ORCPT ); Wed, 21 Aug 2019 16:18:01 -0400 Received: by mail-ot1-f68.google.com with SMTP id m24so3267102otp.12; Wed, 21 Aug 2019 13:18:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=kOj/75oPZVAZoa0T6jbFRSVm/CkUv/wNYDVG2AOMBQE=; b=bJiKKbKQHXl/KkuUyhEMOmBJtQk7ChBkqcFNbmarkIPEfQ/Af8/iT196JE3wGAjYcH wuOHYTTpPYt9OKWZVquzOStYHeo1EiqCAdlnkBElF5AuEcApGtmAkamZf/tdE2E9AXXn nfVRg67BghOepNsXfCv6Q1HKCnm7HYH4/t/Di6k5J/1PBO7TRnUiufxLPcR+R5IQHBUU iF2z+pVpcfOaVpt6oKs2n1mkwmaaihsF5ERc4ntR3pB6aX1XP+0VBvD6wm8JV77HkTDn vtcTlOiS4CUWaK6RUVYv87h52D0CEagLFPm0pz87nMnaryQ+5oo4XJvNhRV2Lt9EAT3U m7hQ== X-Gm-Message-State: APjAAAUEj5HuMULga7YWd86/WNbuMrO+7/OJgbQugmObiocWZRSUVr44 m60qRjHcCfLVoV4aY7bn1w== X-Google-Smtp-Source: APXvYqyhT+fZw8+BA2kLFIhmDj2KcF/sfupiFmLzB/S7nIb5Y2pzAjhkdaqKQNKE2PeIRMOJepKYUg== X-Received: by 2002:a9d:1ca3:: with SMTP id l35mr27086557ota.106.1566418679785; Wed, 21 Aug 2019 13:17:59 -0700 (PDT) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id z16sm3179143oic.10.2019.08.21.13.17.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Aug 2019 13:17:59 -0700 (PDT) Date: Wed, 21 Aug 2019 15:17:58 -0500 From: Rob Herring To: Jungo Lin Cc: tfiga@chromium.org, hverkuil-cisco@xs4all.nl, laurent.pinchart@ideasonboard.com, matthias.bgg@gmail.com, mchehab@kernel.org, linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, srv_heupstream@mediatek.com, ddavenport@chromium.org, Sean.Cheng@mediatek.com, sj.huang@mediatek.com, frederic.chen@mediatek.com, Jerry-ch.Chen@mediatek.com, frankie.chiu@mediatek.com, ryan.yu@mediatek.com, Rynn.Wu@mediatek.com, yuzhao@chromium.org, zwisler@chromium.org, shik@chromium.org, suleiman@chromium.org Subject: Re: [RFC,v4,1/4] media: dt-bindings: mt8183: Added camera ISP Pass 1 Message-ID: <20190821201758.GB15270@bogus> References: <20190807124803.29884-1-jungo.lin@mediatek.com> <20190807124803.29884-2-jungo.lin@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190807124803.29884-2-jungo.lin@mediatek.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Wed, Aug 07, 2019 at 08:48:00PM +0800, Jungo Lin wrote: > This patch adds DT binding document for the Pass 1 (P1) unit > in Mediatek's camera ISP system. The Pass 1 unit grabs the sensor > data out from the sensor interface, applies ISP image effects > from tuning data and outputs the image data or statistics data to DRAM. > > Signed-off-by: Jungo Lin > --- > .../bindings/media/mediatek,camisp.txt | 73 +++++++++++++++++++ > 1 file changed, 73 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/mediatek,camisp.txt > > diff --git a/Documentation/devicetree/bindings/media/mediatek,camisp.txt b/Documentation/devicetree/bindings/media/mediatek,camisp.txt > new file mode 100644 > index 000000000000..fa2713acceca > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/mediatek,camisp.txt > @@ -0,0 +1,73 @@ > +* Mediatek Image Signal Processor Pass 1 (ISP P1) > + > +The Pass 1 unit of Mediatek's camera ISP system grabs the sensor data out > +from the sensor interface, applies ISP effects from tuning data and outputs > +the image data and statistics data to DRAM. Furthermore, Pass 1 unit has > +the ability to output two different resolutions frames at the same time to > +increase the performance of the camera application. > + > +Required properties: > +- compatible: Must be "mediatek,mt8183-camisp" for MT8183. > +- reg: Physical base address of the camera function block register and > + length of memory mapped region. Must contain an entry for each entry > + in reg-names. > +- reg-names: Must include the following entries: > + "cam_sys": Camera base function block > + "cam_uni": Camera UNI function block > + "cam_a": Camera ISP P1 hardware unit A > + "cam_b": Camera ISP P1 hardware unit B > + "cam_c": Camera ISP P1 hardware unit C > +- interrupts: Must contain an entry for each entry in interrupt-names. > +- interrupt-names : Must include the following entries: > + "cam_uni": Camera UNI interrupt > + "cam_a": Camera unit A interrupt > + "cam_b": Camera unit B interrupt > + "cam_c": Camera unit C interrupt > +- iommus: Shall point to the respective IOMMU block with master port > + as argument, see Documentation/devicetree/bindings/iommu/mediatek,iommu.txt > + for details. > +- clocks: A list of phandle and clock specifier pairs as listed > + in clock-names property, see > + Documentation/devicetree/bindings/clock/clock-bindings.txt for details. > +- clock-names: Must be "camsys_cam_cgpdn" and "camsys_camtg_cgpdn". > +- mediatek,larb: Must contain the local arbiters in the current SoCs, see > + Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.txt > + for details. > +- power-domains: a phandle to the power domain, see > + Documentation/devicetree/bindings/power/power_domain.txt for details. > +- mediatek,scp : The node of system control processor (SCP), see > + Documentation/devicetree/bindings/remoteproc/mtk,scp.txt for details. > + > +Example: > +SoC specific DT entry: > + > + camisp: camisp@1a000000 { Also, you can remove 2 levels of indentation here. > + compatible = "mediatek,mt8183-camisp", "syscon"; > + reg = <0 0x1a000000 0 0x1000>, > + <0 0x1a003000 0 0x1000>, > + <0 0x1a004000 0 0x2000>, > + <0 0x1a006000 0 0x2000>, > + <0 0x1a008000 0 0x2000>; > + reg-names = "cam_sys", > + "cam_uni", > + "cam_a", > + "cam_b", > + "cam_c"; > + interrupts = , > + , > + , > + ; > + interrupt-names = "cam_uni", > + "cam_a", > + "cam_b", > + "cam_c"; > + iommus = <&iommu M4U_PORT_CAM_IMGO>; > + clocks = <&camsys CLK_CAM_CAM>, > + <&camsys CLK_CAM_CAMTG>; > + clock-names = "camsys_cam_cgpdn", > + "camsys_camtg_cgpdn"; > + mediatek,larb = <&larb3>, > + <&larb6>; > + power-domains = <&scpsys MT8183_POWER_DOMAIN_CAM>; > + mediatek,scp = <&scp>; > + }; > -- > 2.18.0 >