From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40AC9C3A5A5 for ; Thu, 5 Sep 2019 12:36:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0D87A22CF6 for ; Thu, 5 Sep 2019 12:36:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Gn6LIRcf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387469AbfIEMgD (ORCPT ); Thu, 5 Sep 2019 08:36:03 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:54848 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387436AbfIEMgD (ORCPT ); Thu, 5 Sep 2019 08:36:03 -0400 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2627F26D; Thu, 5 Sep 2019 14:35:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1567686959; bh=O+TkDwA8NW+ek+tt1rm9zd83y0S+r18jXS9EQh3SZ2o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Gn6LIRcfmEK48dHkllsNoaeF4lM9Y3AojNtJeRSQKOeUvW5wqWaJUbbzEBW7Pvi4a jco/7OVvGqg0/O2cX/OYB5iba09t0un+00XrMV/g7eQ+HUmxhY7CBG/zN/NtthGbIR btlkq67R9y+L8PS8Mr9ql7w9lOcAKoEl4LqCAIj8= Date: Thu, 5 Sep 2019 15:35:52 +0300 From: Laurent Pinchart To: Tomasz Figa Cc: "Enrico Weigelt, metux IT consult" , Jerry-ch Chen , Hans Verkuil , Sakari Ailus , "matthias.bgg@gmail.com" , "mchehab@kernel.org" , "shik@chromium.org" , "devicetree@vger.kernel.org" , Sean Cheng =?utf-8?B?KOmEreaYh+W8mCk=?= , Rynn Wu =?utf-8?B?KOWQs+iCsuaBqSk=?= , srv_heupstream , Po-Yang Huang =?utf-8?B?KOm7g+afj+mZvSk=?= , "suleiman@chromium.org" , Jungo Lin =?utf-8?B?KOael+aYjuS/iik=?= , Sj Huang =?utf-8?B?KOm7g+S/oeeSiyk=?= , "yuzhao@chromium.org" , "linux-mediatek@lists.infradead.org" , "zwisler@chromium.org" , Christie Yu =?utf-8?B?KOa4uOmbheaDoCk=?= , Frederic Chen =?utf-8?B?KOmZs+S/iuWFgyk=?= , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" , "laurent.pinchart+renesas@ideasonboard.com" , "hans.verkuil@cisco.com" Subject: Re: [RFC PATCH V2 4/4] platform: mtk-isp: Add Mediatek FD driver Message-ID: <20190905123552.GM5035@pendragon.ideasonboard.com> References: <1562661672-22439-1-git-send-email-Jerry-Ch.chen@mediatek.com> <1562661672-22439-5-git-send-email-Jerry-Ch.chen@mediatek.com> <1564380061.15267.383.camel@mtksdccf07> <1564401491.15267.405.camel@mtksdccf07> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hello, On Fri, Aug 09, 2019 at 05:07:21PM +0900, Tomasz Figa wrote: > On Mon, Jul 29, 2019 at 8:58 PM Jerry-ch Chen wrote: > > On Mon, 2019-07-29 at 17:57 +0800, Tomasz Figa wrote: > >> On Mon, Jul 29, 2019 at 3:01 PM Jerry-ch Chen wrote: > >>> On Tue, 2019-07-09 at 18:56 +0800, Enrico Weigelt, metux IT consult wrote: > >>>> On 09.07.19 10:41, Jerry-ch Chen wrote: > >>>>> diff --git a/drivers/media/platform/mtk-isp/fd/mtk_fd.h b/drivers/media/platform/mtk-isp/fd/mtk_fd.h > >>>>> new file mode 100644 > >>>>> index 0000000..289999b > >>>>> --- /dev/null > >>>>> +++ b/drivers/media/platform/mtk-isp/fd/mtk_fd.h > >>>>> @@ -0,0 +1,157 @@ > >>>>> +/* SPDX-License-Identifier: GPL-2.0 */ > >>>>> +// > >>>>> +// Copyright (c) 2018 MediaTek Inc. > >>>>> + > >>>>> +#ifndef __MTK_FD_HW_H__ > >>>>> +#define __MTK_FD_HW_H__ > >>>>> + > >>>>> +#include > >>>>> +#include > >>>>> +#include > >>>>> +#include > >>>>> +#include > >>>>> +#include > >>>>> + > >>>>> +#define MTK_FD_OUTPUT_MIN_WIDTH 26U > >>>>> +#define MTK_FD_OUTPUT_MIN_HEIGHT 26U > >>>>> +#define MTK_FD_OUTPUT_MAX_WIDTH 640U > >>>>> +#define MTK_FD_OUTPUT_MAX_HEIGHT 480U > >>>>> + > >>>>> +/* Control the user defined image widths and heights > >>>>> + * to be scaled and performed face detection in FD HW. > >>>>> + * MTK FD support up to 14 user defined image sizes to perform face detection. > >>>>> + */ > >>>>> +#define V4L2_CID_MTK_FD_SCALE_IMG_WIDTH (V4L2_CID_USER_MTK_FD_BASE + 1) > >>>>> +#define V4L2_CID_MTK_FD_SCALE_IMG_HEIGHT (V4L2_CID_USER_MTK_FD_BASE + 2) > >>>> > >>>> I've got a *really* bad feeling about introducing chip specific > >>>> uapi stuff. (by the way: uapi stuff belongs into include/uapi/...) > >>> > >>> Thanks for your comments, > >>> > >>> If we remain chip-specific control IDs, I will move the uapi stuff into > >>> inlcude/uapi/mtk_fd.h (filename TBD) > >>> > >>>> Maybe you could tell us what that's *really* about, so we can find some > >>>> standard / chip-independent api for these things. That's one of the > >>>> major point of the kernel: hardware abstraction. > >>> > >>> I am not sure if it is possible for us to add some standard > >>> v4l2-controls for face detection, a further explanations of controls are > >>> listed below. > >>> > >>> In v4l2-controls, there exists V4L2_CID_DETECT_CLASS, but I haven't > >>> found the standards or api that can be used for face detection yet. > >>> https://elixir.bootlin.com/linux/latest/source/include/uapi/linux/v4l2-controls.h#L1092 > >>> > >>> For detecting certain face angle and head direction, we would need > >>> V4L2_CID_DETECT_ANGLE, V4L2_CID_DETECT_DIRECTION controls for user to > >>> specify the angle and direction to be detected. > >>> In MTK FD driver, we support the following angles and directions to be > >>> selected by user, and they are both multiple selected . > >>> FD_angle_table[] = {-90, -45, 0 , 45, 90} > >>> FD_direction_table[] = {0, 30, 60, 90, 120, 150, ..., 330} > >>> > >>> Assuming these v4l2-controls are array of V4L2_CTRL_TYPE_U16 with > >>> dimension 5 and 12. > >>> User can select the desired angle and directions to be detected into > >>> arrays and bring it to driver by these controls, however, the more they > >>> select, the longer execution time needed by HW. > >> > >> Sounds like we need some kind of a menu bitmask control here, but I > >> don't see V4L2 having anything like that. > >> > >> Hans, Sakari, any ideas? > >> > >>> For detecting different sizes of faces and increase the detection speed, > >>> FD driver might need to scales down the input image into different > >>> smaller sizes > >> > >> Do you mean the FD hardware would do the scaling or the driver code > >> itself? It would be undesirable to do such scaling in a kernel driver, > >> so if that's not something handled by the hardware, the downscaled > >> image might need to be provided from the userspace. > > > > Thanks for your comments. > > > > Yes, FD hardware will do the scaling itself, so driver could set the > > sizes. > > > >> >, besides driver default values, user or proprietary > >>> algorithm library can manually set the desired image sizes, therefore, > >>> we would need the following controls: > >>> V4L2_CID_DETECT_SCALE_DOWN_IMG_WIDTH and > >>> V4L2_CID_DETECT_SCALE_DOWN_IMG_HEIGHT. > >>> In MTK FD driver, we implement these controls as array of > >>> V4L2_CTRL_TYPE_U16 with the dimension 15. > >> > >> Why 15? > > > > It consists of one input image size and 14 down-scaled image sizes, > > the amount 15 (or say 14) is defined by the MTK FD algo library, > > therefore I remain the number of 15 here for communicate with the > > library. > > Maybe it should be defined as following? > > MTK_FD_MAX_SCALE_SIZE_NUM 14 > > and > > MTK_FD_SCALE_ARR_NUM 15 > > > >>> For controlling detection speed, we would need the > >>> V4L2_CID_DETECT_SPEED, the faster speedup implies the lower accuracy of > >>> detection, In MTK FD driver, the max level of speedup is 7, and default > >>> value is 0. > >>> > >>> For MTK FD algorithm user library, they would need select extra > >>> detection features(models) used in HW, we need > >>> V4L2_CID_MTK_FD_EXTRA_MODEL, this will be set to 1 for using extra > >>> model. However, we are considering make this control more > >>> chip-independent and can be added into standard. > >>> for example, V4L2_CID_DETECTION_FD_MODEL or ...FD_ALGO, > >>> drivers can define the detection algorithm or detection model to be used > >>> for users to select. How do you think? > >> > >> Sounds like something that could be a menu control, so it could vary > >> between drivers. > > > > Ok, and maybe it should be created by v4l2_ctrl_new_int_menu(...)? > > > >>> In short, I summery the control IDs as following: > >>> V4L2_CID_DETECT_ANGLE: set the angle of face in degrees. 90 ~ -90 > >>> degrees. > >>> V4L2_CID_DETECT_DIRECTION: set the rotation of the head in degrees. > >>> 0~330 degrees. > >>> V4L2_CID_DETECT_SCALE_DOWN_IMG_WIDTH: set the image widths for an input > >>> image to be scaled down for face detection > >>> V4L2_CID_DETECT_SCALE_DOWN_IMG_HEIGHT: set the image heights for an > >>> input image to be scaled down for face detection > >>> V4L2_CID_DETECT_SPEED: set the detection speed, usually reducing > >>> accuracy. > >>> V4L2_CID_DETECTION_FD_MODEL: select the detection model or algorithm to > >>> be used by face detection driver. > >>> > >>>>> +#define ENABLE_FD 0x111 > >>>>> +#define FD_HW_ENABLE 0x4 > >>>>> +#define FD_INT_EN 0x15c > >>>>> +#define FD_INT 0x168 > >>>>> +#define FD_RESULT 0x178 > >>>>> +#define FD_IRQ_MASK 0x001 > >>>>> + > >>>>> +#define RS_MAX_BUF_SIZE 2288788 > >>>>> +#define FD_MAX_SPEEDUP 7 > >>>>> +#define FD_MAX_POSE_VAL 0xfffffffffffffff > >>>>> +#define FD_DEF_POSE_VAL 0x3ff > >>>>> +#define MAX_FD_SEL_NUM 1026 > >>>> > >>>> If that file is supposed to be included by anything beyond the driver > >>>> itself, we need proper prefixing. (same for anything else in here) > >>> > >>> I will fix it as following: > >>> > >>> #define FD_ENABLE 0x111 > >>> > >>> #define FD_REG_OFFSET_HW_ENABLE 0x4 > >>> #define FD_REG_OFFSET_INT_EN 0x15c > >>> #define FD_REG_OFFSET_INT_VAL 0x168 > >>> #define FD_REG_OFFSET_RESULT 0x178 > >>> > >>> #define FD_IRQ_MASK 1 > >>> #define FD_MAX_RS_BUF_SIZE 2288788 > >>> #define FD_MAX_SPEEDUP 7 > >>> #define FD_MAX_RESULT_NUM 1026 > >> > >> I'd suggest the MTK_FD_ prefix. > > > > Ok, I will use MTK_FD_ prefix. > > > >>>>> diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h > >>>>> index 3dcfc61..eae876e 100644 > >>>>> --- a/include/uapi/linux/v4l2-controls.h > >>>>> +++ b/include/uapi/linux/v4l2-controls.h > >>>>> @@ -192,6 +192,10 @@ enum v4l2_colorfx { > >>>>> * We reserve 16 controls for this driver. */ > >>>>> #define V4L2_CID_USER_IMX_BASE (V4L2_CID_USER_BASE + 0x10b0) > >>>>> > >>>>> +/* The base for the mediatek FD driver controls */ > >>>>> +/* We reserve 16 controls for this driver. */ > >>>>> +#define V4L2_CID_USER_MTK_FD_BASE (V4L2_CID_USER_BASE + 0x10d0) > >>>> > >>>> Why only the base, but not the actual IDs in uapi ? > >>>> > >>> I will put actual IDs in uapi/ for user to reference. > > Enrico, any thoughts on the explanation that Jerry provided and > further discussion above? I agree with Enrico that standardising the face detection API is the way to go. -- Regards, Laurent Pinchart