From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EBAFC43331 for ; Thu, 5 Sep 2019 16:05:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C9CE520825 for ; Thu, 5 Sep 2019 16:05:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388180AbfIEQFT (ORCPT ); Thu, 5 Sep 2019 12:05:19 -0400 Received: from mga06.intel.com ([134.134.136.31]:22094 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731857AbfIEQFT (ORCPT ); Thu, 5 Sep 2019 12:05:19 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Sep 2019 09:05:18 -0700 X-IronPort-AV: E=Sophos;i="5.64,470,1559545200"; d="scan'208";a="184277240" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Sep 2019 09:05:15 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id D4FA92069D; Thu, 5 Sep 2019 19:05:12 +0300 (EEST) Date: Thu, 5 Sep 2019 19:05:12 +0300 From: Sakari Ailus To: Tomasz Figa Cc: Dongchun Zhu , Mauro Carvalho Chehab , Rob Herring , Mark Rutland , Nicolas Boichat , Matthias Brugger , Cao Bing Bu , srv_heupstream , "moderated list:ARM/Mediatek SoC support" , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , Sj Huang , Linux Media Mailing List , devicetree@vger.kernel.org, Louis Kuo , shengnan.wang@mediatek.com Subject: Re: [V3, 2/2] media: i2c: Add Omnivision OV02A10 camera sensor driver Message-ID: <20190905160512.GG5475@paasikivi.fi.intel.com> References: <20190819034331.13098-1-dongchun.zhu@mediatek.com> <20190819034331.13098-3-dongchun.zhu@mediatek.com> <20190819083009.GC6133@paasikivi.fi.intel.com> <1567676465.21623.100.camel@mhfsdcap03> <20190905104546.GA5475@paasikivi.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Thu, Sep 05, 2019 at 07:53:37PM +0900, Tomasz Figa wrote: > On Thu, Sep 5, 2019 at 7:45 PM Sakari Ailus > wrote: > > > > Hi Dongchun, > > > > On Thu, Sep 05, 2019 at 05:41:05PM +0800, Dongchun Zhu wrote: > > > > ... > > > > > > > + ret = regulator_bulk_enable(OV02A10_NUM_SUPPLIES, ov02a10->supplies); > > > > > + if (ret < 0) { > > > > > + dev_err(dev, "Failed to enable regulators\n"); > > > > > + goto disable_clk; > > > > > + } > > > > > + msleep_range(7); > > > > > > > > This has some potential of clashing with more generic functions in the > > > > future. Please use usleep_range directly, or msleep. > > > > > > > > > > Did you mean using usleep_range(7*1000, 8*1000), as used in patch v1? > > > https://patchwork.kernel.org/patch/10957225/ > > > > Yes, please. > > Why not just msleep()? msleep() is usually less accurate. I'm not sure it makes a big different in this case. Perhaps, if someone wants that the sensor is powered on and streaming as soon as possible. -- Sakari Ailus sakari.ailus@linux.intel.com