linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: dongchun.zhu@mediatek.com
Cc: kbuild-all@01.org, mchehab@kernel.org,
	andriy.shevchenko@linux.intel.com, robh+dt@kernel.org,
	mark.rutland@arm.com, sakari.ailus@linux.intel.com,
	drinkcat@chromium.org, tfiga@chromium.org,
	matthias.bgg@gmail.com, bingbu.cao@intel.com,
	srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, sj.huang@mediatek.com,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	sam.hung@mediatek.com, shengnan.wang@mediatek.com,
	dongchun.zhu@mediatek.com
Subject: Re: [V2, 2/2] media: i2c: Add DW9768 VCM driver
Date: Sun, 8 Sep 2019 06:12:50 +0800	[thread overview]
Message-ID: <201909080620.3L1t3Gn4%lkp@intel.com> (raw)
In-Reply-To: <20190905072142.14606-3-dongchun.zhu@mediatek.com>

[-- Attachment #1: Type: text/plain, Size: 1958 bytes --]

Hi,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[cannot apply to v5.3-rc7 next-20190904]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/dongchun-zhu-mediatek-com/media-i2c-dw9768-Add-DT-support-and-MAINTAINERS-entry/20190908-044622
base:   git://linuxtv.org/media_tree.git master
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   drivers/media/i2c/dw9768.c: In function 'dw9768_write_smbus':
>> drivers/media/i2c/dw9768.c:82:9: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
     return ret;
            ^~~

vim +/ret +82 drivers/media/i2c/dw9768.c

    70	
    71	static int dw9768_write_smbus(struct dw9768 *dw9768, unsigned char reg,
    72				      unsigned char value)
    73	{
    74		struct i2c_client *client = v4l2_get_subdevdata(&dw9768->sd);
    75		int ret;
    76	
    77		if (reg == DW9768_CMD_DELAY  && value == DW9768_CMD_DELAY)
    78			usleep_range(DW9768_CTRL_DELAY_US,
    79				     DW9768_CTRL_DELAY_US + 100);
    80		else
    81			ret = i2c_smbus_write_byte_data(client, reg, value);
  > 82		return ret;
    83	}
    84	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 51779 bytes --]

  parent reply	other threads:[~2019-09-07 22:13 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-05  7:21 [V2, 0/2] media: i2c: add support for " dongchun.zhu
2019-09-05  7:21 ` [V2, 1/2] media: i2c: dw9768: Add DT support and MAINTAINERS entry dongchun.zhu
2019-09-05 10:14   ` Andy Shevchenko
2019-09-05 10:48     ` Sakari Ailus
2019-09-05 11:35       ` Andy Shevchenko
2019-09-05 11:49         ` Javier Martinez Canillas
2019-09-05 12:00           ` Sakari Ailus
2019-09-05 12:24             ` Andy Shevchenko
2019-09-17 20:47               ` Rob Herring
2019-09-05  7:21 ` [V2, 2/2] media: i2c: Add DW9768 VCM driver dongchun.zhu
2019-09-05  8:21   ` Sakari Ailus
2019-09-05 10:19     ` Andy Shevchenko
2019-09-05 10:40       ` Sakari Ailus
2019-09-05 10:57         ` Javier Martinez Canillas
2019-09-05 11:36           ` Andy Shevchenko
2019-09-05  8:28   ` Tomasz Figa
2019-09-05 10:26   ` Andy Shevchenko
     [not found]     ` <e8b59857e39744a6acfe5d862f3ac8d5@mtkmbs05n2.mediatek.inc>
2020-01-20  8:34       ` Dongchun Zhu
2019-09-07 22:12   ` kbuild test robot [this message]
2019-10-09  4:40   ` Tomasz Figa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201909080620.3L1t3Gn4%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bingbu.cao@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dongchun.zhu@mediatek.com \
    --cc=drinkcat@chromium.org \
    --cc=kbuild-all@01.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=sam.hung@mediatek.com \
    --cc=shengnan.wang@mediatek.com \
    --cc=sj.huang@mediatek.com \
    --cc=srv_heupstream@mediatek.com \
    --cc=tfiga@chromium.org \
    --subject='Re: [V2, 2/2] media: i2c: Add DW9768 VCM driver' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox