From: Maxime Ripard <mripard@kernel.org>
To: Jernej Skrabec <jernej.skrabec@siol.net>
Cc: wens@csie.org, robh+dt@kernel.org, mark.rutland@arm.com,
mchehab@kernel.org, hverkuil@xs4all.nl,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH 5/6] media: sun4i: Add H3 deinterlace driver
Date: Thu, 12 Sep 2019 22:26:47 +0200 [thread overview]
Message-ID: <20190912202647.wfcjur7yxhlelvd6@localhost.localdomain> (raw)
In-Reply-To: <20190912175132.411-6-jernej.skrabec@siol.net>
Hi,
On Thu, Sep 12, 2019 at 07:51:31PM +0200, Jernej Skrabec wrote:
> + dev->regmap = devm_regmap_init_mmio(dev->dev, dev->base,
> + &deinterlace_regmap_config);
> + if (IS_ERR(dev->regmap)) {
> + dev_err(dev->dev, "Couldn't create deinterlace regmap\n");
> +
> + return PTR_ERR(dev->regmap);
> + }
> +
> + ret = clk_prepare_enable(dev->bus_clk);
> + if (ret) {
> + dev_err(dev->dev, "Failed to enable bus clock\n");
> +
> + return ret;
> + }
Do you need to keep the bus clock enabled all the time? Usually, for
the SoCs that have a reset line, you only need it to read / write to
the registers, not to have the controller actually running.
If you don't, then regmap_init_mmio_clk will take care of that for
you.
> + clk_set_rate(dev->mod_clk, 300000000);
> +
> + ret = clk_prepare_enable(dev->mod_clk);
> + if (ret) {
> + dev_err(dev->dev, "Failed to enable mod clock\n");
> +
> + goto err_bus_clk;
> + }
> +
> + ret = clk_prepare_enable(dev->ram_clk);
> + if (ret) {
> + dev_err(dev->dev, "Failed to enable ram clock\n");
> +
> + goto err_mod_clk;
> + }
> +
> + ret = reset_control_reset(dev->rstc);
> + if (ret) {
> + dev_err(dev->dev, "Failed to apply reset\n");
> +
> + goto err_ram_clk;
> + }
This could be moved to a runtime_pm hook, with get_sync called in the
open. That way you won't leave the device powered on if it's unused.
> +struct deinterlace_dev {
> + struct v4l2_device v4l2_dev;
> + struct video_device vfd;
> + struct device *dev;
> + struct v4l2_m2m_dev *m2m_dev;
> +
> + /* Device file mutex */
> + struct mutex dev_mutex;
> +
> + void __iomem *base;
> + struct regmap *regmap;
Do you need to store the base address in that structure if you're
using the regmap?
Maxime
next prev parent reply other threads:[~2019-09-12 20:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 17:51 [PATCH 0/6] media: Introduce Allwinner H3 deinterlace driver Jernej Skrabec
2019-09-12 17:51 ` [PATCH 1/6] dt-bindings: bus: sunxi: Add H3 MBUS compatible Jernej Skrabec
2019-09-12 17:51 ` [PATCH 2/6] clk: sunxi-ng: h3: Export MBUS clock Jernej Skrabec
2019-09-12 17:51 ` [PATCH 3/6] ARM: dts: sunxi: h3/h5: Add MBUS controller node Jernej Skrabec
2019-09-12 20:20 ` Maxime Ripard
2019-09-12 20:28 ` Jernej Škrabec
2019-09-12 20:34 ` Maxime Ripard
2019-09-12 20:46 ` Jernej Škrabec
2019-09-13 7:57 ` Maxime Ripard
2019-09-12 17:51 ` [PATCH 4/6] dt-bindings: media: Add Allwinner H3 Deinterlace binding Jernej Skrabec
2019-09-12 20:22 ` Maxime Ripard
2019-09-12 17:51 ` [PATCH 5/6] media: sun4i: Add H3 deinterlace driver Jernej Skrabec
2019-09-12 20:26 ` Maxime Ripard [this message]
2019-09-12 20:43 ` Jernej Škrabec
2019-09-13 9:11 ` Maxime Ripard
2019-09-13 20:06 ` Jernej Škrabec
2019-09-14 6:42 ` Jernej Škrabec
2019-09-18 14:30 ` Maxime Ripard
2019-09-29 13:18 ` Jernej Škrabec
2019-09-12 17:51 ` [PATCH 6/6] dts: arm: sun8i: h3: Enable deinterlace unit Jernej Skrabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190912202647.wfcjur7yxhlelvd6@localhost.localdomain \
--to=mripard@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).