From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEBCEC49ED7 for ; Fri, 13 Sep 2019 06:50:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C98982054F for ; Fri, 13 Sep 2019 06:50:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726891AbfIMGux (ORCPT ); Fri, 13 Sep 2019 02:50:53 -0400 Received: from mga17.intel.com ([192.55.52.151]:53638 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725446AbfIMGux (ORCPT ); Fri, 13 Sep 2019 02:50:53 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Sep 2019 23:50:52 -0700 X-IronPort-AV: E=Sophos;i="5.64,489,1559545200"; d="scan'208";a="386302958" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Sep 2019 23:50:52 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id 04C3720BD1; Fri, 13 Sep 2019 09:50:49 +0300 (EEST) Date: Fri, 13 Sep 2019 09:50:49 +0300 From: Sakari Ailus To: Hans Verkuil Cc: linux-media@vger.kernel.org Subject: Re: [PATCH 6/6] smiapp: Avoid fall-through in switch Message-ID: <20190913065049.GK5781@paasikivi.fi.intel.com> References: <20190819124728.10511-1-sakari.ailus@linux.intel.com> <20190819124728.10511-7-sakari.ailus@linux.intel.com> <74b049a8-9f03-c7c0-94db-0a1e5db4d07a@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <74b049a8-9f03-c7c0-94db-0a1e5db4d07a@xs4all.nl> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Thu, Sep 12, 2019 at 03:17:54PM +0200, Hans Verkuil wrote: > On 8/19/19 2:47 PM, Sakari Ailus wrote: > > Remove switch fall-through cases in the driver. > > > > Signed-off-by: Sakari Ailus > > --- > > drivers/media/i2c/smiapp/smiapp-core.c | 11 +++++------ > > 1 file changed, 5 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/media/i2c/smiapp/smiapp-core.c b/drivers/media/i2c/smiapp/smiapp-core.c > > index 76d7d204ec17..61de8cdccc4b 100644 > > --- a/drivers/media/i2c/smiapp/smiapp-core.c > > +++ b/drivers/media/i2c/smiapp/smiapp-core.c > > @@ -1674,13 +1674,12 @@ static void smiapp_propagate(struct v4l2_subdev *subdev, > > sensor->binning_vertical = 1; > > } > > } > > - /* Fall through */ > > - case V4L2_SEL_TGT_COMPOSE: > > This doesn't look right: for this target you now enter the default case. > > You probably want to do: > > break; > case V4L2_SEL_TGT_COMPOSE: > break; Yes; thanks. I've just sent v2. -- Sakari Ailus sakari.ailus@linux.intel.com