From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03DB3C4CEC5 for ; Fri, 13 Sep 2019 23:55:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D1BDC2083B for ; Fri, 13 Sep 2019 23:55:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="u+ggpLTc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390705AbfIMXzP (ORCPT ); Fri, 13 Sep 2019 19:55:15 -0400 Received: from mail-io1-f68.google.com ([209.85.166.68]:40735 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390695AbfIMXzO (ORCPT ); Fri, 13 Sep 2019 19:55:14 -0400 Received: by mail-io1-f68.google.com with SMTP id h144so66265154iof.7; Fri, 13 Sep 2019 16:55:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=3VViACYA451Huc+LtS7zi8sLCA8aVNyRPy9i0iM2GDI=; b=u+ggpLTcaq339c2+f3rAkLb54fKQpdkq3J6sVCXOqfGhelJxp2mCB8bAEBNzC7FH8o P8crxVpK13Nsp577LkLXyKaW2JJjz1OwcoICYOGPj3LNVO2Ath+NI60FjJpPWJ38JL8m p324Omsau/Be646rkyZpswvsPYOgWeGFsIU8/JNTbrnCvBlSlTLJK5hJvzegJILcN7mx m8kT5JwtTA+m8LJUZQfvpHit/UeP26CgqjQljfasFqss1kQ5wWXFlHe4tiObzhxZqxnp UQd9L0o94P5palf14PIxjKxCOjPQFrDqlMj84BvliGEcbB24ZjE87nIwV1CQLaCwIXpj YN9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=3VViACYA451Huc+LtS7zi8sLCA8aVNyRPy9i0iM2GDI=; b=SAbbPV7da3xXyuuVPrFgWL2Po8KhClOZywCdu53H+0JWwDciRszlO38NeSbjG8Yh6S DTotrRLjuIfs9KFFTK/3Nvpa2xjWOVhqPGG6El7egCbZ7jwb7T2bYZvwhSeCHq03YC5A bnuAKbiER+gdgbs/nRSpT9KGu4gF6BkbEi2UUpQgKr0YGAoA3wI1zzYMKv5xcDOeaXzH TZiy+HfJGeAotXc28UbPwImzuVqYTN3K2TfINYBE0jJJmxmniDCKZE9NcaI/TRMkED6F JESpWRTQ9u1gnN5PMBRzklH7KcxeI6SMwM72io/OF/xK16SXDEqtkFJoOGUdoe+R2POr M60Q== X-Gm-Message-State: APjAAAUDYFXH15fauIv02QCfr8F0fq91EN16m9onZ8shBrOFnKTiHJAz JH2XIKC3ZyD/RYkJN5wSYdU= X-Google-Smtp-Source: APXvYqxkKUUtkwic4jRqCz27WVubjYpWonkpiAPsJeQd45CS9E9tD5VtULCBx/wyK4xtoT0vEOKphQ== X-Received: by 2002:a5e:9509:: with SMTP id r9mr3154422ioj.100.1568418913865; Fri, 13 Sep 2019 16:55:13 -0700 (PDT) Received: from cs-dulles.cs.umn.edu (cs-dulles.cs.umn.edu. [128.101.35.54]) by smtp.googlemail.com with ESMTPSA id q74sm44394874iod.72.2019.09.13.16.55.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Sep 2019 16:55:13 -0700 (PDT) From: Navid Emamdoost Cc: emamd001@umn.edu, smccaman@umn.edu, kjlu@umn.edu, Navid Emamdoost , Mauro Carvalho Chehab , Greg Kroah-Hartman , Thomas Gleixner , Richard Fontana , Kate Stewart , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: usb: fix memory leak in af9005_identify_state Date: Fri, 13 Sep 2019 18:55:02 -0500 Message-Id: <20190913235505.9164-1-navid.emamdoost@gmail.com> X-Mailer: git-send-email 2.17.1 To: unlisted-recipients:; (no To-header on input) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org In af9005_identify_state when returning -EIO the allocated buffer should be released. Signed-off-by: Navid Emamdoost --- drivers/media/usb/dvb-usb/af9005.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/dvb-usb/af9005.c b/drivers/media/usb/dvb-usb/af9005.c index 02697d86e8c1..aee500beaab6 100644 --- a/drivers/media/usb/dvb-usb/af9005.c +++ b/drivers/media/usb/dvb-usb/af9005.c @@ -975,8 +975,10 @@ static int af9005_identify_state(struct usb_device *udev, *cold = 1; else if (reply == 0x02) *cold = 0; - else + else { + kfree(buf); return -EIO; + } deb_info("Identify state cold = %d\n", *cold); err: -- 2.17.1