From: Benoit Parrot <bparrot@ti.com>
To: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-media <linux-media@vger.kernel.org>,
<devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [Patch 3/6] media: dt-bindings: ov2659: add powerdown-gpios optional property
Date: Sun, 15 Sep 2019 15:21:33 -0500 [thread overview]
Message-ID: <20190915202133.5ijfgm4akegumbpq@ti.com> (raw)
In-Reply-To: <CA+V-a8vo2ddxdDEBefTErsTB43tPAFNy-94xhQN1Yhb64jr_Aw@mail.gmail.com>
Lad, Prabhakar <prabhakar.csengg@gmail.com> wrote on Sat [2019-Sep-14 11:11:02 +0100]:
> Hi Benoit,
>
> Thank you for the patch.
>
> On Thu, Sep 12, 2019 at 1:58 PM Benoit Parrot <bparrot@ti.com> wrote:
> >
> > Add powerdown-gpios to the list of optional properties for the OV2659
> > camera sensor.
> >
> > Signed-off-by: Benoit Parrot <bparrot@ti.com>
> > ---
> > Documentation/devicetree/bindings/media/i2c/ov2659.txt | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/ov2659.txt b/Documentation/devicetree/bindings/media/i2c/ov2659.txt
> > index cabc7d827dfb..f55204cce0cd 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/ov2659.txt
> > +++ b/Documentation/devicetree/bindings/media/i2c/ov2659.txt
> > @@ -12,6 +12,10 @@ Required Properties:
> > - clock-names: should be "xvclk".
> > - link-frequencies: target pixel clock frequency.
> >
> > +Optional Properties:
> > +- powerdown-gpios: reference to the GPIO connected to the pwdn pin, if any.
> > + Active is low.
> > +
> as per the datasheet this should be active high with pull-down resistor.
Ahhh, yes I'll fix that.
>
> Cheers,
> --Prabhakar Lad
next prev parent reply other threads:[~2019-09-15 20:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 13:00 [Patch 0/6] media: i2c: ov2659: maintenance series Benoit Parrot
2019-09-12 13:00 ` [Patch 1/6] media: i2c: ov2659: Fix for image wrap-around in lower resolution Benoit Parrot
2019-09-12 13:00 ` [Patch 2/6] media: i2c: ov2659: Fix sensor detection to actually fail when device is not present Benoit Parrot
2019-09-12 13:00 ` [Patch 3/6] media: dt-bindings: ov2659: add powerdown-gpios optional property Benoit Parrot
2019-09-14 10:11 ` Lad, Prabhakar
2019-09-15 20:21 ` Benoit Parrot [this message]
2019-09-12 13:00 ` [Patch 4/6] media: i2c: ov2659: Add optional powerdown gpio handling Benoit Parrot
2019-09-14 10:33 ` Lad, Prabhakar
2019-09-15 20:27 ` Benoit Parrot
2019-09-12 13:00 ` [Patch 5/6] media: i2c: ov2659: Fix missing 720p register config Benoit Parrot
2019-09-12 13:00 ` [Patch 6/6] media: i2c: ov2659: Switch to SPDX Licensing Benoit Parrot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190915202133.5ijfgm4akegumbpq@ti.com \
--to=bparrot@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=prabhakar.csengg@gmail.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).