From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: mjpeg-users@lists.sourceforge.net, linux-media@vger.kernel.org,
mchehab@kernel.org, laurent.pinchart@ideasonboard.com,
linux-kernel@vger.kernel.org
Subject: Re: bringing back media/zoran driver
Date: Mon, 23 Sep 2019 10:36:47 +0200 [thread overview]
Message-ID: <20190923083647.GB1599@Red> (raw)
In-Reply-To: <8db38daf-74eb-8218-1cc6-ea9036afac3d@xs4all.nl>
On Mon, Sep 23, 2019 at 10:05:09AM +0200, Hans Verkuil wrote:
> On 9/21/19 7:03 PM, Corentin Labbe wrote:
> > hello
> >
> > I am the owner of a zoran based DC10+ card.
> > I am in the need of using it since yesterday and I found that its driver was removed.
> >
> > Reverting the removing patch made to a temporary working situation.
> >
> > If I understand correctly, it was removed due to lack of vb2 convertion.
> > If I am able to do this vb2 conversion, does bring it back in mainline will be posssible ?
> > In that case I am ready to assume to be the maintainer if needed.
>
> It would be nice to get it back. The conversion to vb2 is the main requirement, but in
> general this driver needed some TLC in general: it's a very old driver and the coding
> standards were quite a bit lower than they are today.
>
> But the vb2 conversion is the most important part.
>
> It's unfortunately not the easiest thing to do (if it was, we'd have done it already!),
> and it is also a 'big bang' patch, i.e. one very large patch that converts the driver
> to vb2. It's all or nothing, you can't have half a vb2 conversion, so that makes it hard
> to review.
Hello
Yes I started a bit to do it by using other conversion patch as helper and I saw this "one big step" problem.
>
> The easiest way is to use the v4l2-compliance utility to verify the conversion. Running
> 'v4l2-compliance -s' is a good way of verifying this.
>
> My recommended approach is to:
>
> 1) first revert the removal patch (commit 8dce4b265a53)
> 2) clean up the coding style. Probably easiest to create one patch per source.
> Use 'checkpatch.pl --strict -f <source>' for this. Doing this should make the
> source code easier to understand/review.
> 3) Run v4l2-compliance (without the -s option) and fix any failures it finds.
> 4) Convert to vb2, using 'v4l2-compliance -s' to test.
>
> Be aware that the code is messy compared to modern standards. Do not be afraid
> to create cleanup patches, it's probably needed.
>
> The v4l2-compliance utility is part of https://git.linuxtv.org/v4l-utils.git/.
> See the README on how to build. Always use the v4l2-compliance version from this
> git repo since that's always the latest and greatest.
>
> I recommend that you join the #v4l irc channel on freenode.org. Most core devs that
> can help with advice are there during office hours (and often outside of office hours
> as well). That's for the European timezones since most devs are based in Europe.
>
Thanks, I has planned to ask this question about the priority between v4l2-compliance and vb2.
Regards
next prev parent reply other threads:[~2019-09-23 8:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-21 17:03 bringing back media/zoran driver Corentin Labbe
2019-09-21 17:17 ` Mauro Carvalho Chehab
2019-09-21 17:29 ` Laurent Pinchart
2019-09-23 8:05 ` Hans Verkuil
2019-09-23 8:36 ` Corentin Labbe [this message]
2019-09-26 17:43 ` [Mjpeg-users] " Bernhard Praschinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190923083647.GB1599@Red \
--to=clabbe.montjoie@gmail.com \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mjpeg-users@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).