From: Jacopo Mondi <jacopo@jmondi.org>
To: Ricardo Ribalda Delgado <ricardo@ribalda.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Ricardo Ribalda Delgado <ribalda@kernel.org>
Subject: Re: [PATCH v6 4/7] Documentation: media: Document V4L2_CTRL_TYPE_AREA
Date: Wed, 25 Sep 2019 10:34:21 +0200 [thread overview]
Message-ID: <20190925083421.ronwsvmqeu5quxpx@uno.localdomain> (raw)
In-Reply-To: <20190920135137.10052-5-ricardo@ribalda.com>
[-- Attachment #1: Type: text/plain, Size: 1481 bytes --]
Hi Ricardo,
On Fri, Sep 20, 2019 at 03:51:34PM +0200, Ricardo Ribalda Delgado wrote:
> From: Ricardo Ribalda Delgado <ribalda@kernel.org>
>
> A struct v4l2_area containing the width and the height of a rectangular
> area.
>
> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
> Signed-off-by: Ricardo Ribalda Delgado <ribalda@kernel.org>
> ---
> Documentation/media/uapi/v4l/vidioc-queryctrl.rst | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/media/uapi/v4l/vidioc-queryctrl.rst b/Documentation/media/uapi/v4l/vidioc-queryctrl.rst
> index a3d56ffbf4cc..33aff21b7d11 100644
> --- a/Documentation/media/uapi/v4l/vidioc-queryctrl.rst
> +++ b/Documentation/media/uapi/v4l/vidioc-queryctrl.rst
> @@ -443,6 +443,12 @@ See also the examples in :ref:`control`.
> - n/a
> - A struct :c:type:`v4l2_ctrl_mpeg2_quantization`, containing MPEG-2
> quantization matrices for stateless video decoders.
> + * - ``V4L2_CTRL_TYPE_AREA``
> + - n/a
> + - n/a
> + - n/a
> + - A struct :c:type:`v4l2_area`, containing the width and the height
> + of a rectangular area. Units depend on the use case.
I recall Hans too was in favour of having min, max and step defined
(and applied to both width and height).
Really a minor issue from my side, feel free to keep it the way it is
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Thanks
j
> * - ``V4L2_CTRL_TYPE_H264_SPS``
> - n/a
> - n/a
> --
> 2.23.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-09-25 8:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 13:51 [PATCH v6 0/7] Implement UNIT_CELL_SIZE control Ricardo Ribalda Delgado
2019-09-20 13:51 ` [PATCH v6 1/7] media: v4l2-core: Implement v4l2_ctrl_new_std_compound Ricardo Ribalda Delgado
2019-09-25 8:19 ` Jacopo Mondi
2019-09-25 20:55 ` Ricardo Ribalda Delgado
2019-09-20 13:51 ` [PATCH v6 2/7] Documentation: v4l2_ctrl_new_std_compound Ricardo Ribalda Delgado
2019-09-25 8:22 ` Jacopo Mondi
2019-09-25 21:00 ` Ricardo Ribalda Delgado
2019-09-20 13:51 ` [PATCH v6 3/7] media: add V4L2_CTRL_TYPE_AREA control type Ricardo Ribalda Delgado
2019-09-25 8:30 ` Jacopo Mondi
2019-09-20 13:51 ` [PATCH v6 4/7] Documentation: media: Document V4L2_CTRL_TYPE_AREA Ricardo Ribalda Delgado
2019-09-25 8:34 ` Jacopo Mondi [this message]
2019-09-25 21:08 ` Ricardo Ribalda Delgado
2019-09-20 13:51 ` [PATCH v6 5/7] media: add V4L2_CID_UNIT_CELL_SIZE control Ricardo Ribalda Delgado
2019-09-20 13:51 ` [PATCH v6 6/7] Documentation: media: Describe V4L2_CID_UNIT_CELL_SIZE Ricardo Ribalda Delgado
2019-09-20 13:51 ` [PATCH v6 7/7] media: imx214: Add new control with V4L2_CID_UNIT_CELL_SIZE Ricardo Ribalda Delgado
2019-09-25 9:25 ` Jacopo Mondi
2019-09-25 21:15 ` Ricardo Ribalda Delgado
2019-09-27 7:14 ` Hans Verkuil
2019-09-27 7:33 ` Ricardo Ribalda Delgado
2019-09-27 7:52 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190925083421.ronwsvmqeu5quxpx@uno.localdomain \
--to=jacopo@jmondi.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=ribalda@kernel.org \
--cc=ricardo@ribalda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).