From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Johan Korsnes <jkorsnes@cisco.com>
Cc: dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org
Subject: Re: [PATCH] drivers: video: hdmi: log ext colorimetry applicability
Date: Thu, 3 Oct 2019 16:44:17 +0300 [thread overview]
Message-ID: <20191003134417.GF1208@intel.com> (raw)
In-Reply-To: <20191003071549.31272-1-jkorsnes@cisco.com>
On Thu, Oct 03, 2019 at 09:15:49AM +0200, Johan Korsnes wrote:
> When logging the AVI InfoFrame, clearly indicate whether or not the
> extended colorimetry attribute is active. This is only the case when
> the AVI InfoFrame colorimetry attribute is set to extended. [0]
>
> [0] CTA-861-G section 6.4 page 57
>
> Signed-off-by: Johan Korsnes <jkorsnes@cisco.com>
> ---
> drivers/video/hdmi.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c
> index f29db728ff29..a709e38a53ca 100644
> --- a/drivers/video/hdmi.c
> +++ b/drivers/video/hdmi.c
> @@ -682,8 +682,14 @@ static void hdmi_avi_infoframe_log(const char *level,
> hdmi_log(" active aspect: %s\n",
> hdmi_active_aspect_get_name(frame->active_aspect));
> hdmi_log(" itc: %s\n", frame->itc ? "IT Content" : "No Data");
> - hdmi_log(" extended colorimetry: %s\n",
> +
> + if (frame->colorimetry == HDMI_COLORIMETRY_EXTENDED)
> + hdmi_log(" extended colorimetry: %s\n",
> hdmi_extended_colorimetry_get_name(frame->extended_colorimetry));
> + else
> + hdmi_log(" extended colorimetry: N/A (0x%x)\n",
> + frame->extended_colorimetry);
Yeah, seems fine. Might make the logs a bit less confusing at least.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
PS. would be nice it someone were to extend this code to deal with the
ACE bits too. Do you have plans/interest in doing that?
> +
> hdmi_log(" quantization range: %s\n",
> hdmi_quantization_range_get_name(frame->quantization_range));
> hdmi_log(" nups: %s\n", hdmi_nups_get_name(frame->nups));
> --
> 2.20.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2019-10-03 13:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 7:15 [PATCH] drivers: video: hdmi: log ext colorimetry applicability Johan Korsnes
2019-10-03 13:44 ` Ville Syrjälä [this message]
2019-10-03 14:53 ` Johan Korsnes (jkorsnes)
2019-10-03 15:02 ` Hans Verkuil
2019-10-03 14:59 ` Hans Verkuil
2019-10-03 15:03 ` Johan Korsnes (jkorsnes)
-- strict thread matches above, loose matches on Subject: below --
2019-10-02 12:42 Johan Korsnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191003134417.GF1208@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jkorsnes@cisco.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).