From: Sakari Ailus <sakari.ailus@iki.fi>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: mchehab@kernel.org, robh+dt@kernel.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
c.barrett@framos.com, a.brela@framos.com
Subject: Re: [PATCH v4 2/2] media: i2c: Add IMX290 CMOS image sensor driver
Date: Fri, 4 Oct 2019 12:23:36 +0300 [thread overview]
Message-ID: <20191004092336.GL896@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <20191003095503.12614-3-manivannan.sadhasivam@linaro.org>
Hi Manivannan,
On Thu, Oct 03, 2019 at 03:25:03PM +0530, Manivannan Sadhasivam wrote:
> Add driver for Sony IMX290 CMOS image sensor driver. The driver only
> supports I2C interface for programming and MIPI CSI-2 for sensor output.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Could you remove the unneeded ret variable from imx290_power_on() and
unneeded goto in the same function?
The MAINTAINERS entry belongs to the first patch adding new files.
Then I think this is good.
--
Regards,
Sakari Ailus
next prev parent reply other threads:[~2019-10-04 9:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 9:55 [PATCH v4 0/2] Add IMX290 CMOS image sensor support Manivannan Sadhasivam
2019-10-03 9:55 ` [PATCH v4 1/2] dt-bindings: media: i2c: Add IMX290 CMOS sensor binding Manivannan Sadhasivam
2019-10-03 9:55 ` [PATCH v4 2/2] media: i2c: Add IMX290 CMOS image sensor driver Manivannan Sadhasivam
2019-10-04 9:23 ` Sakari Ailus [this message]
2019-10-04 10:19 ` Manivannan Sadhasivam
2019-10-04 10:59 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191004092336.GL896@valkosipuli.retiisi.org.uk \
--to=sakari.ailus@iki.fi \
--cc=a.brela@framos.com \
--cc=c.barrett@framos.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).