From: Benoit Parrot <bparrot@ti.com>
To: Colin King <colin.king@canonical.com>
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
<linux-media@vger.kernel.org>, <kernel-janitors@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][next] media: ti-vpe: vpe: use r2y instead of y2r, copy-paste error
Date: Fri, 11 Oct 2019 09:18:23 -0500 [thread overview]
Message-ID: <20191011141823.kyxz32c2p24rr3d3@ti.com> (raw)
In-Reply-To: <20191011132940.8995-1-colin.king@canonical.com>
Colin King <colin.king@canonical.com> wrote on Fri [2019-Oct-11 14:29:40 +0100]:
> From: Colin Ian King <colin.king@canonical.com>
>
> There appears to be a copy-paste error on the access of
> csc_coeffs.y2r.r601.full.coeff, I believe csc_coeffs.2yr.r601.full.coeff
> should be used instead. This is a moot point as the code is never
> reached, but at least use the correct structure element.
>
> Addresses-Coverity: ("Copy-paste error")
> Fixes: 3ff3a712a9ea ("media: ti-vpe: vpe: don't rely on colorspace member for conversion")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/media/platform/ti-vpe/csc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/ti-vpe/csc.c b/drivers/media/platform/ti-vpe/csc.c
> index bd923bee4a31..834114a4eebe 100644
> --- a/drivers/media/platform/ti-vpe/csc.c
> +++ b/drivers/media/platform/ti-vpe/csc.c
> @@ -238,7 +238,7 @@ void csc_set_coeff(struct csc_data *csc, u32 *csc_reg0,
> coeff = csc_coeffs.r2y.r709.limited.coeff;
> } else {
> /* Should never reach this, but it keeps gcc happy */
> - coeff = csc_coeffs.y2r.r601.full.coeff;
> + coeff = csc_coeffs.r2y.r601.full.coeff;
> }
> } else {
> *csc_reg5 |= CSC_BYPASS;
Reviewed-by: Benoit Parrot <bparrot.ti.com>
> --
> 2.20.1
>
prev parent reply other threads:[~2019-10-11 14:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 13:29 [PATCH][next] media: ti-vpe: vpe: use r2y instead of y2r, copy-paste error Colin King
2019-10-11 14:18 ` Benoit Parrot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011141823.kyxz32c2p24rr3d3@ti.com \
--to=bparrot@ti.com \
--cc=colin.king@canonical.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).