linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Jacopo Mondi <jacopo@jmondi.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	tfiga@google.com, pavel@ucw.cz,
	"open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)" 
	<linux-media@vger.kernel.org>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v4 01/11] dt-bindings: video-interfaces: Document 'location' property
Date: Fri, 18 Oct 2019 22:40:33 +0300	[thread overview]
Message-ID: <20191018194033.GF3712@kekkonen.localdomain> (raw)
In-Reply-To: <20191007162913.250743-2-jacopo@jmondi.org>

Hi Jacopo,

(Cc'ing the devicetree list.)

On Mon, Oct 07, 2019 at 06:29:03PM +0200, Jacopo Mondi wrote:
> Add the 'location' device property, used to specify a device mounting
> position. The property is particularly meaningful for mobile devices
> with a well defined usage orientation.
> 
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> ---
>  .../devicetree/bindings/media/video-interfaces.txt    | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt b/Documentation/devicetree/bindings/media/video-interfaces.txt
> index f884ada0bffc..1211bdf80722 100644
> --- a/Documentation/devicetree/bindings/media/video-interfaces.txt
> +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt
> @@ -89,6 +89,17 @@ Optional properties
>    but a number of degrees counter clockwise. Typical values are 0 and 180
>    (upside down).
>  
> +- location: The mount location of a device (typically an image sensor or a flash
> +  LED) expressed as a position relative to the usage orientation of the system
> +  where the device is installed on.
> +  Possible values are:
> +  0 - Front. The device is mounted on the front facing side of the system.

How about starting from 1? Then 0 can remain "undefined" value, i.e. the
caller can initialise the value to zero without the need to figure out
whether reading a given property was successful or not.

> +  For mobile devices such as smartphones, tablets and laptops the front side is
> +  the user facing side.
> +  1 - Back. The device is mounted on the back side of the system, which is
> +  defined as the opposite side of the front facing one.
> +  2 - External. The device is not attached directly to the system but is
> +  attached in a way that allows it to move freely.
>  
>  Optional endpoint properties
>  ----------------------------

-- 
Sakari Ailus
sakari.ailus@linux.intel.com

  parent reply	other threads:[~2019-10-18 19:44 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-07 16:29 [PATCH v4 00/11] media: Report camera sensor properties Jacopo Mondi
2019-10-07 16:29 ` [PATCH v4 01/11] dt-bindings: video-interfaces: Document 'location' property Jacopo Mondi
2019-10-08  7:40   ` Pavel Machek
2019-10-08  7:58     ` Jacopo Mondi
2019-10-08  8:06       ` Pavel Machek
2019-10-08  8:20         ` Jacopo Mondi
2019-10-22 14:27           ` Hans Verkuil
2019-10-23 14:27             ` Pavel Machek
2019-10-25  6:29               ` Tomasz Figa
2019-10-26 20:48                 ` Laurent Pinchart
2019-11-18 11:32                   ` Tomasz Figa
2019-11-21 16:02                     ` Jacopo Mondi
2019-11-22  4:53                       ` Tomasz Figa
2019-10-26 11:23               ` Jacopo Mondi
2019-10-18 19:40   ` Sakari Ailus [this message]
2019-10-07 16:29 ` [PATCH v4 02/11] media: v4l2-ctrl: Document V4L2_CID_CAMERA_SENSOR_LOCATION Jacopo Mondi
2019-10-07 16:29 ` [PATCH v4 03/11] dt-bindings: video-interface: Expand rotation description Jacopo Mondi
2019-10-07 16:29 ` [PATCH v4 04/11] media: v4l2-ctrl: Document V4L2_CID_CAMERA_SENSOR_ROTATION Jacopo Mondi
2019-10-22 14:14   ` Hans Verkuil
2019-10-07 16:29 ` [PATCH v4 05/11] media: v4l2-ctrls: Add camera location and rotation Jacopo Mondi
2019-10-07 16:29 ` [PATCH v4 06/11] media: v4l2-fwnode: Add helper to parse device properties Jacopo Mondi
2019-10-18 19:36   ` Sakari Ailus
2019-11-08  9:20     ` Jacopo Mondi
2019-10-07 16:29 ` [PATCH v4 07/11] include: v4l2-ctrl: Sort forward declarations Jacopo Mondi
2019-10-07 16:29 ` [PATCH v4 08/11] media: v4l2-ctrls: Sort includes alphabetically Jacopo Mondi
2019-10-07 16:29 ` [PATCH v4 09/11] media: v4l2-ctrls: Add helper to register properties Jacopo Mondi
2019-10-07 16:29 ` [PATCH v4 10/11] media: i2c: ov5670: Parse and " Jacopo Mondi
2019-10-07 16:29 ` [PATCH v4 11/11] media: i2c: ov13858: " Jacopo Mondi
2019-10-18 19:10 ` [PATCH v4 00/11] media: Report camera sensor properties Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191018194033.GF3712@kekkonen.localdomain \
    --to=sakari.ailus@linux.intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=jacopo@jmondi.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=pavel@ucw.cz \
    --cc=tfiga@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).