From: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
To: linux-media@vger.kernel.org
Cc: dafna.hirschfeld@collabora.com, helen.koike@collabora.com,
skhan@linuxfoundation.org, hverkuil@xs4all.nl,
kernel@collabora.com, dafna3@gmail.com
Subject: [PATCH v5 0/2] upon streaming, check that the pipeline starts with a source entity
Date: Thu, 24 Oct 2019 16:15:52 +0200 [thread overview]
Message-ID: <20191024141554.15248-1-dafna.hirschfeld@collabora.com> (raw)
The first patch in this patchset moves the dev field of each
entity struct to the common struct vimc_ent_device.
The second patch fixes a crashing bug when the pipeline does not start with a
source entity.
Fixes from v4:
- NO changes in the first patch since v4
- The function vimc_streamer_pipeline_init now gets the media_entity
as parameter and I changed the while loop to "while(ent)" since this the
valid behaviour: loop until the source of the pipeline.
All other cases should return from the while loop with "goto err".
Also, after calling v4l2_subdev_call, if 'ret' is ENOIOCTCMD then
it is set to 0 to make sure that ret is 0 when no error occurred.
Dafna Hirschfeld (2):
media: vimc: move the dev field of each entity to vimc_ent_dev
media: vimc: upon streaming, check that the pipeline starts with a
source entity
drivers/media/platform/vimc/vimc-capture.c | 7 +-
drivers/media/platform/vimc/vimc-common.c | 10 +++
drivers/media/platform/vimc/vimc-common.h | 7 ++
drivers/media/platform/vimc/vimc-debayer.c | 15 ++---
drivers/media/platform/vimc/vimc-scaler.c | 11 ++--
drivers/media/platform/vimc/vimc-sensor.c | 5 +-
drivers/media/platform/vimc/vimc-streamer.c | 73 +++++++++++++--------
7 files changed, 78 insertions(+), 50 deletions(-)
--
2.20.1
next reply other threads:[~2019-10-24 14:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 14:15 Dafna Hirschfeld [this message]
2019-10-24 14:15 ` [PATCH v5 1/2] media: vimc: move the dev field of each entity to vimc_ent_dev Dafna Hirschfeld
2019-11-10 10:58 ` Hans Verkuil
2019-10-24 14:15 ` [PATCH v5 2/2] media: vimc: upon streaming, check that the pipeline starts with a source entity Dafna Hirschfeld
2019-10-27 14:13 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024141554.15248-1-dafna.hirschfeld@collabora.com \
--to=dafna.hirschfeld@collabora.com \
--cc=dafna3@gmail.com \
--cc=helen.koike@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=kernel@collabora.com \
--cc=linux-media@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).