From: Takashi Iwai <tiwai@suse.de>
To: linux-media@vger.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: [PATCH 2/2] media: tw686x: audio: Avoid non-standard macro usage
Date: Fri, 8 Nov 2019 17:36:49 +0100 [thread overview]
Message-ID: <20191108163649.32590-3-tiwai@suse.de> (raw)
In-Reply-To: <20191108163649.32590-1-tiwai@suse.de>
Pass the device pointer from the PCI pointer directly, instead of a
non-standard macro. The macro didn't give any better readability.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
drivers/media/pci/tw686x/tw686x-audio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/tw686x/tw686x-audio.c b/drivers/media/pci/tw686x/tw686x-audio.c
index 40373bd23381..7786e51d19ae 100644
--- a/drivers/media/pci/tw686x/tw686x-audio.c
+++ b/drivers/media/pci/tw686x/tw686x-audio.c
@@ -300,7 +300,7 @@ static int tw686x_snd_pcm_init(struct tw686x_dev *dev)
snd_pcm_lib_preallocate_pages_for_all(pcm,
SNDRV_DMA_TYPE_DEV,
- snd_dma_pci_data(dev->pci_dev),
+ &dev->pci_dev->dev,
TW686X_AUDIO_PAGE_MAX * AUDIO_DMA_SIZE_MAX,
TW686X_AUDIO_PAGE_MAX * AUDIO_DMA_SIZE_MAX);
return 0;
--
2.16.4
next prev parent reply other threads:[~2019-11-08 16:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 16:36 [PATCH 0/2] media: ALSA memalloc cleanups Takashi Iwai
2019-11-08 16:36 ` [PATCH 1/2] media: solo6x10: Remove superfluous snd_dma_continuous_data() Takashi Iwai
2019-11-10 10:04 ` Hans Verkuil
2019-11-08 16:36 ` Takashi Iwai [this message]
2019-11-10 10:04 ` [PATCH 2/2] media: tw686x: audio: Avoid non-standard macro usage Hans Verkuil
2019-11-10 10:05 ` [PATCH 0/2] media: ALSA memalloc cleanups Hans Verkuil
2019-11-11 8:14 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191108163649.32590-3-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).