From: Wolfram Sang <wsa@the-dreams.de>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org, Michael Krufky <mkrufky@linuxtv.org>,
Brad Love <brad@nextdimension.cc>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sean Young <sean@mess.org>
Subject: Re: Seeking help for getting rid of i2c_clients_command()
Date: Mon, 11 Nov 2019 20:15:39 +0100 [thread overview]
Message-ID: <20191111191539.GA1608@kunai> (raw)
In-Reply-To: <5209c59d-f0f6-c2c3-5f5a-eedef500eb39@xs4all.nl>
[-- Attachment #1: Type: text/plain, Size: 1083 bytes --]
Hi Hans!
> TUNER_SET_CONFIG is called whenever the TV or radio frequency is
> changed, and when that happens the demod needs to update its configuration
> as well. So the tuner_i2c_xfer_send(&priv->i2c_props, buffer, 4); is for the
> tuner itself (whose i2c address is known), but i2c_clients_command is
> basically broadcasting to anyone on the bus, and only the tda9987 will
> actually act on the TUNER_SET_CONFIG command.
I see. Thanks for the heads up.
> This should make it possible for tuner-simple.c to actually lookup the
> i2c address of the demod from that global list and use a direct call.
Sounds awesome!
> I've CC-ed a bunch of people who know more about DVB than I do, so
> I hope they can double-check that I am on the right track.
Their help would be much appreciated.
> Wolfram, do you just want to get rid of i2c_clients_command or the i2c
> command() callback as well?
I'd like to get rid of the callback as well. tuner is again the only
in-tree user. And this whole mechanism looks so 2.4ish... I think it can
go now.
Thanks for your help,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-11-11 19:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-10 15:05 Seeking help for getting rid of i2c_clients_command() Wolfram Sang
2019-11-11 12:26 ` Hans Verkuil
2019-11-11 19:15 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111191539.GA1608@kunai \
--to=wsa@the-dreams.de \
--cc=brad@nextdimension.cc \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mkrufky@linuxtv.org \
--cc=sean@mess.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).