From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
To: linux-media@vger.kernel.org
Cc: Michael Tretter <m.tretter@pengutronix.de>
Subject: [PATCH 0/5] Stateful Encoding: final bits
Date: Tue, 19 Nov 2019 12:34:52 +0100 [thread overview]
Message-ID: <20191119113457.57833-1-hverkuil-cisco@xs4all.nl> (raw)
This series adds support for fractions in the control framework,
and a way to obtain the min and max values of compound controls
such as v4l2_fract.
Next it adds the V4L2_CID_MPEG_VIDEO_ENC_FRAME_RATE control to
set the framerate for the encoder.
The next patch adds support for the V4L2_BUF_FLAG_TOO_SMALL flag
to signal that the capture buffer was too small.
The final patch adds the encoder spec (unchanged from v3).
Michael, can you add support for V4L2_CID_MPEG_VIDEO_ENC_FRAME_RATE
to your encoder driver? Let me know if something isn't working.
I need to add a test control for this to vivid as well and add support
for this to v4l2-ctl, that's on my TODO list.
Open questions:
1) Existing encoder drivers use S_PARM to signal the frameperiod,
but as discussed in Lyon this should be the rate at which frames are
submitted for encoding, which can be different from
V4L2_CID_MPEG_VIDEO_ENC_FRAME_RATE. But given the current use-cases
I was wondering if calling S_PARM should set the ENC_FRAME_RATE
control as well, and you would need to explicitly set the control
after S_PARM if the two are not the same. This would mean that
existing applications that don't know about the control can keep working.
2) I do believe that we need a RELEASE/DEL/DESTROY_BUFS ioctl in
order to do proper handling of the V4L2_BUF_FLAG_TOO_SMALL case.
I am inclined to postpone adding this flag until we have that ioctl.
We can still merge the stateful encoder spec if we mention that that
is work in progress.
Regards,
Hans
Hans Verkuil (4):
v4l2-ctrls: add support for v4l2_fract types
v4l2-ctrls: add support for V4L2_CTRL_WHICH_MIN/MAX_VAL
v4l2-controls.h: add V4L2_CID_MPEG_VIDEO_ENC_FRAME_RATE
videodev2.h: add V4L2_BUF_FLAG_TOO_SMALL flag
Tomasz Figa (1):
media: docs-rst: Document memory-to-memory video encoder interface
Documentation/media/uapi/v4l/buffer.rst | 9 +
Documentation/media/uapi/v4l/dev-encoder.rst | 608 ++++++++++++++++++
Documentation/media/uapi/v4l/dev-mem2mem.rst | 1 +
.../media/uapi/v4l/ext-ctrls-codec.rst | 8 +
Documentation/media/uapi/v4l/pixfmt-v4l2.rst | 5 +
Documentation/media/uapi/v4l/v4l2.rst | 2 +
.../media/uapi/v4l/vidioc-encoder-cmd.rst | 51 +-
.../media/uapi/v4l/vidioc-g-ext-ctrls.rst | 15 +-
.../media/uapi/v4l/vidioc-queryctrl.rst | 6 +
.../media/videodev2.h.rst.exceptions | 3 +
.../media/common/videobuf2/videobuf2-core.c | 12 +-
.../media/common/videobuf2/videobuf2-v4l2.c | 4 +
drivers/media/i2c/imx214.c | 4 +-
drivers/media/v4l2-core/v4l2-ctrls.c | 222 ++++++-
include/media/v4l2-ctrls.h | 72 ++-
include/media/videobuf2-core.h | 4 +
include/uapi/linux/v4l2-controls.h | 1 +
include/uapi/linux/videodev2.h | 6 +
18 files changed, 980 insertions(+), 53 deletions(-)
create mode 100644 Documentation/media/uapi/v4l/dev-encoder.rst
--
2.23.0
next reply other threads:[~2019-11-19 11:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 11:34 Hans Verkuil [this message]
2019-11-19 11:34 ` [PATCH 1/5] v4l2-ctrls: add support for v4l2_fract types Hans Verkuil
2019-11-19 11:34 ` [PATCH 2/5] v4l2-ctrls: add support for V4L2_CTRL_WHICH_MIN/MAX_VAL Hans Verkuil
2019-11-19 11:34 ` [PATCH 3/5] v4l2-controls.h: add V4L2_CID_MPEG_VIDEO_ENC_FRAME_RATE Hans Verkuil
2019-11-19 11:34 ` [PATCH 4/5] videodev2.h: add V4L2_BUF_FLAG_TOO_SMALL flag Hans Verkuil
2019-11-19 14:36 ` Hans Verkuil
2019-11-19 11:34 ` [PATCH 5/5] media: docs-rst: Document memory-to-memory video encoder interface Hans Verkuil
2019-11-19 16:15 ` [PATCH 0/5] Stateful Encoding: final bits Michael Tretter
2019-12-20 13:47 ` Michael Tretter
2019-12-20 13:48 ` [RFC PATCH] media: allegro: implement V4L2_CID_MPEG_VIDEO_ENC_FRAME_RATE Michael Tretter
2020-01-06 15:02 ` [PATCH 0/5] Stateful Encoding: final bits Hans Verkuil
2020-01-18 13:14 ` Nicolas Dufresne
2020-03-11 15:16 ` Nicolas Dufresne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119113457.57833-1-hverkuil-cisco@xs4all.nl \
--to=hverkuil-cisco@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=m.tretter@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).