From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09047C432C3 for ; Fri, 22 Nov 2019 07:58:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB3F620659 for ; Fri, 22 Nov 2019 07:58:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GnqUaOqh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726703AbfKVH6V (ORCPT ); Fri, 22 Nov 2019 02:58:21 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:37118 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726554AbfKVH6V (ORCPT ); Fri, 22 Nov 2019 02:58:21 -0500 Received: by mail-wr1-f65.google.com with SMTP id t1so7455440wrv.4 for ; Thu, 21 Nov 2019 23:58:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=w67p8xtPdt4/A9arfHNMFL65WBSDvCsMKuFi+DGBUsw=; b=GnqUaOqhAGPj1mSB54UkQHX4DC7zQbAMKGlzXTenoyFS7SJHIG7SkYKpS3E591jesy icCdTroOZhl3lQG0MC4noVz3GcrSdZ3Q0UiheNxmIgcCRphi4DzocgH6+akJKPMp54rE Zs9Tj8Bf38qwZUAhUiOtHylkX7OAbM9jDrZB5FWjgT724BNcW6t+rVhc+VS8nys/Yq+k X83hu5TH1/dV5m34mQ8wWV4jNtwESzBy6NBTfIFEUeVfVZCMG1ar96ADpDaRKm2evh/s wU/EBeaQJwE6HVdRYf8a3cY4MJpP0lZ+WrIwOTf4uiILzOSMn/yTgbEWMC2AfBJNxcrp x3+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=w67p8xtPdt4/A9arfHNMFL65WBSDvCsMKuFi+DGBUsw=; b=WsKrDnJ5Iy+R/oCpcq5ldWubJIUwX9YH1ePiJkMzm/EKkFXE8FIYrBojJd5+K37zX0 VOSwsQRUUJUYAAJ1HymvtRhWcwRU36lv/fz2Ec1+PjrUzQB1s/OWrw/dxPdWcsjgCaV4 3br1k5AYjzVFiY3ikAHB66TkeUCStuFBgMtgJ/ZIh8zOCn2vfQO8Ddlc+LZIrR2MJPz/ V3j6R9e2p3VRuw7Q2qZnFPfHNjzwzkS06kLUueL6Fdoyd3AGGxvfAiMBQjY4voo77m30 HFMBU1SFP3oD8tDTxOErElkQqjjEcDJPJb5EUo8IULGKw2rW+nA6YqAKR/5n9yZuAytU W6Kw== X-Gm-Message-State: APjAAAVn7IbZrHAv7/CWrBYPBBNVCLd4iwc9TpIRySyHI44pUWZUO+XD 0d2pFXB9RC4Bs3XiblsmwDRLQw== X-Google-Smtp-Source: APXvYqzcaOQ0bWkk1yg8dpRwylAawt7qFh0J8UP4pvucZ/KaMyU92DHdCC4aa6RA4P2POZCfKVRT4Q== X-Received: by 2002:adf:f50b:: with SMTP id q11mr16206077wro.343.1574409498689; Thu, 21 Nov 2019 23:58:18 -0800 (PST) Received: from dell ([2.27.35.135]) by smtp.gmail.com with ESMTPSA id j67sm2673521wmb.43.2019.11.21.23.58.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Nov 2019 23:58:18 -0800 (PST) Date: Fri, 22 Nov 2019 07:58:04 +0000 From: Lee Jones To: Raul E Rangel Cc: enric.balletbo@collabora.com, Mauro Carvalho Chehab , Alessandro Zummo , linux-iio@vger.kernel.org, Fabien Lahoudere , Alexandre Belloni , linux-i2c@vger.kernel.org, Enrico Granata , linux-rtc@vger.kernel.org, Chanwoo Choi , Benjamin Tissoires , Benson Leung , "Gustavo A. R. Silva" , Sebastian Reichel , Douglas Anderson , Dmitry Torokhov , Jonathan Cameron , Peter Meerwald-Stadler , linux-media@vger.kernel.org, linux-pm@vger.kernel.org, Wolfram Sang , Hartmut Knaack , Alexandru M Stan , Gwendal Grignou , Akshu Agrawal , Guenter Roeck , linux-kernel@vger.kernel.org, Neil Armstrong , Lars-Peter Clausen , Hans Verkuil Subject: Re: [PATCH] platform/chrome: cros_ec: Rename cros_ec_dev to cros_ec_mfd_dev Message-ID: <20191122075804.GB3296@dell> References: <20191121164458.1.Ie5c276b95210779fc2ca5651e46552236795b6b9@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191121164458.1.Ie5c276b95210779fc2ca5651e46552236795b6b9@changeid> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Thu, 21 Nov 2019, Raul E Rangel wrote: > It's very confusing having cros_ec_dev and cros_ec_device. This makes it > clear you are dealing with the mfd device. An MFD isn't really a thing. It's a Linuxisum that doesn't really describe anything meaningful. IMHO it would make more sense to follow the same hierarchical structure that platform devices use: s/cros_ec_mfd_dev/cros_ec_parent/ > Signed-off-by: Raul E Rangel > --- > This is based on top of the i2c acpi tunnel patches: > https://lore.kernel.org/patchwork/project/lkml/list/?series=419791 > > drivers/i2c/busses/i2c-cros-ec-tunnel.c | 2 +- > drivers/iio/accel/cros_ec_accel_legacy.c | 2 +- > .../common/cros_ec_sensors/cros_ec_sensors.c | 2 +- > .../cros_ec_sensors/cros_ec_sensors_core.c | 2 +- > .../cros_ec_sensors/cros_ec_sensors_ring.c | 2 +- > drivers/iio/light/cros_ec_light_prox.c | 2 +- > drivers/iio/pressure/cros_ec_baro.c | 2 +- > .../media/platform/cros-ec-cec/cros-ec-cec.c | 2 +- > drivers/mfd/cros_ec_dev.c | 14 ++++----- > drivers/platform/chrome/cros_ec_chardev.c | 21 +++++++------- > drivers/platform/chrome/cros_ec_debugfs.c | 16 +++++----- > drivers/platform/chrome/cros_ec_lightbar.c | 29 ++++++++++--------- > drivers/platform/chrome/cros_ec_pd_sysfs.c | 6 ++-- > drivers/platform/chrome/cros_ec_pd_update.c | 20 ++++++------- > drivers/platform/chrome/cros_ec_sysfs.c | 16 +++++----- > drivers/platform/chrome/cros_ec_vbc.c | 8 ++--- > drivers/platform/chrome/cros_usbpd_logger.c | 6 ++-- > drivers/power/supply/cros_usbpd-charger.c | 6 ++-- > drivers/rtc/rtc-cros-ec.c | 2 +- > include/linux/mfd/cros_ec.h | 8 ++--- > .../linux/platform_data/cros_ec_pd_update.h | 4 +-- > 21 files changed, 87 insertions(+), 85 deletions(-) -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog