From: Daniel Vetter <daniel@ffwll.ch>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
Daniel Vetter <daniel.vetter@intel.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH] udmabuf: Remove deleted map/unmap handlers.
Date: Tue, 26 Nov 2019 15:36:33 +0100 [thread overview]
Message-ID: <20191126143633.GX29965@phenom.ffwll.local> (raw)
In-Reply-To: <20191126142516.630200-1-maarten.lankhorst@linux.intel.com>
On Tue, Nov 26, 2019 at 03:25:16PM +0100, Maarten Lankhorst wrote:
> Commit 7f0de8d80816 ("dma-buf: Drop dma_buf_k(un)map") removed map/unmap
> handlers, but they still existed in udmabuf. Remove them there as well
>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Fixes: 7f0de8d80816 ("dma-buf: Drop dma_buf_k(un)map")
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: Daniel Vetter <daniel.vetter@intel.com>
> Cc: linux-media@vger.kernel.org
> Cc: linaro-mm-sig@lists.linaro.org
> Cc: dri-devel@lists.freedesktop.org
/me puts on brown paper bag
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/dma-buf/udmabuf.c | 16 ----------------
> 1 file changed, 16 deletions(-)
>
> diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c
> index 9635897458a0..9de539c1def4 100644
> --- a/drivers/dma-buf/udmabuf.c
> +++ b/drivers/dma-buf/udmabuf.c
> @@ -93,26 +93,10 @@ static void release_udmabuf(struct dma_buf *buf)
> kfree(ubuf);
> }
>
> -static void *kmap_udmabuf(struct dma_buf *buf, unsigned long page_num)
> -{
> - struct udmabuf *ubuf = buf->priv;
> - struct page *page = ubuf->pages[page_num];
> -
> - return kmap(page);
> -}
> -
> -static void kunmap_udmabuf(struct dma_buf *buf, unsigned long page_num,
> - void *vaddr)
> -{
> - kunmap(vaddr);
> -}
> -
> static const struct dma_buf_ops udmabuf_ops = {
> .map_dma_buf = map_udmabuf,
> .unmap_dma_buf = unmap_udmabuf,
> .release = release_udmabuf,
> - .map = kmap_udmabuf,
> - .unmap = kunmap_udmabuf,
> .mmap = mmap_udmabuf,
> };
>
> --
> 2.24.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2019-11-26 14:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 14:25 [PATCH] udmabuf: Remove deleted map/unmap handlers Maarten Lankhorst
2019-11-26 14:36 ` Daniel Vetter [this message]
2019-11-26 14:44 ` Maarten Lankhorst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191126143633.GX29965@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-media@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).