From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46954C432C0 for ; Fri, 29 Nov 2019 15:40:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0499C2075C for ; Fri, 29 Nov 2019 15:40:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="F82YmRMv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727124AbfK2Pk0 (ORCPT ); Fri, 29 Nov 2019 10:40:26 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:37437 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727008AbfK2PkZ (ORCPT ); Fri, 29 Nov 2019 10:40:25 -0500 Received: by mail-wr1-f66.google.com with SMTP id w15so4757285wru.4 for ; Fri, 29 Nov 2019 07:40:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=d1qlPGKEub2zxKrCwvu7wl5sgPz0ycWM4uVqvybEP3o=; b=F82YmRMvls0MB5LUz2QLPFzl3BfaxgxvnOVCEJhs1lPCNqRLd1ALGX/cWTwx/odPIW IemIWncQEOpg+J/XVdmZD8pa932RyfoOZV4pOcjVYPzCUl6MH1uJfvVchf6zsgyCwhxG bCPE7pnQMnBdKE05ualTzpbl3MPA+ESEs8cyw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=d1qlPGKEub2zxKrCwvu7wl5sgPz0ycWM4uVqvybEP3o=; b=T7RsUZaLZ/ntJcdVUqQYgprhAYQeBsU6bllgt166Yf3ZZd6mx3fqLAZOcsdsFf0RDD DRs+XNZ+loJZHO2KobqK28ql/gMKZGvz0POoZerspIHsxxQzoNW69UNCOf0py5mslABD AQ0JtFCIx6I6hteIXjz7CJf3WgInJEoSOR/g78ekYtTTAJchlzHeob6nQEeBqWazlPx9 XgBq1njV6eZhKSqjOv7at1+tpCluhGFom4jtgMIFXtuEdZPDRLi9ZeI9BVxpj4/tZXZY lnpIXVh3X08P1PqcPWiNfIGxYWygSdVaqCe/tVdxIxP1uDD6DgSEhdWmR2sLmnu3wNUm 3Yuw== X-Gm-Message-State: APjAAAXItwRtn4+JSs3rtWGW3StGiSOACIdYq0+JHrKUOavOXiYKbAnk jHgEJUcw6RWa441E1Db28JDhdQ== X-Google-Smtp-Source: APXvYqyOcTZwJaF1yb8C5yGqGrIDeDIxvzOnil0vbT94pRF4zJdnCm1UYhNHwa7P+mD1vwCUSOZm1A== X-Received: by 2002:adf:fa87:: with SMTP id h7mr44553361wrr.172.1575042022285; Fri, 29 Nov 2019 07:40:22 -0800 (PST) Received: from phenom.ffwll.local (212-51-149-96.fiber7.init7.net. [212.51.149.96]) by smtp.gmail.com with ESMTPSA id e16sm13723160wme.35.2019.11.29.07.40.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Nov 2019 07:40:21 -0800 (PST) Date: Fri, 29 Nov 2019 16:40:19 +0100 From: Daniel Vetter To: Jani Nikula Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, ville.syrjala@linux.intel.com, Andy Walls , Bernie Thompson , Bruno =?iso-8859-1?Q?Pr=E9mont?= , Daniel Vetter , Hans Verkuil , Jaya Kumar , Kirti Wankhede , Miguel Ojeda Sandonis , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , Robin van der Gracht , Steve Glendinning , ivtv-devel@ivtvdriver.org, kvm@vger.kernel.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH v2 00/14] video, drm, etc: constify fbops in struct fb_info Message-ID: <20191129154019.GI624164@phenom.ffwll.local> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Operating-System: Linux phenom 5.3.0-2-amd64 User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Fri, Nov 29, 2019 at 12:29:30PM +0200, Jani Nikula wrote: > This is v2 of https://patchwork.freedesktop.org/series/70119/ > > I wanted to make our struct fb_ops const because we don't modify > it... and this is what I ended up with to fix it and a bunch of others. > > I would appreciate acks to merge all this via the drm-misc tree. This is > especially important for patches 1-8 to reasonably get the job > done. Patches 9-14 are somewhat easier to merge at leisure afterwards, > but there really isn't much conflict potential IMO. Only patches 11-14 need acks, drivers/video is already officially maintained in drm-misc. > Daniel, please double-check me adding your Reviewed-by on the later > patches wasn't overzealous. Yeah, looks all neat&tidy. -Daniel > > BR, > Jani. > > > Cc: Andy Walls > Cc: Bernie Thompson > Cc: Bruno Prémont > Cc: Daniel Vetter > Cc: Hans Verkuil > Cc: Jaya Kumar > Cc: Kirti Wankhede > Cc: Miguel Ojeda Sandonis > Cc: Noralf Trønnes > Cc: Robin van der Gracht > Cc: Steve Glendinning > Cc: Ville Syrjälä > Cc: dri-devel@lists.freedesktop.org > Cc: ivtv-devel@ivtvdriver.org > Cc: kvm@vger.kernel.org > Cc: linux-fbdev@vger.kernel.org > Cc: linux-input@vger.kernel.org > Cc: linux-media@vger.kernel.org > Cc: linux-omap@vger.kernel.org > > > Jani Nikula (14): > video: fb_defio: preserve user fb_ops > drm/fb-helper: don't preserve fb_ops across deferred IO use > video: smscufx: don't restore fb_mmap after deferred IO cleanup > video: udlfb: don't restore fb_mmap after deferred IO cleanup > video: fbdev: vesafb: modify the static fb_ops directly > video: fbmem: use const pointer for fb_ops > video: omapfb: use const pointer for fb_ops > video: fbdev: make fbops member of struct fb_info a const pointer > drm: constify fb ops across all drivers > video: constify fb ops across all drivers > HID: picoLCD: constify fb ops > media: constify fb ops across all drivers > samples: vfio-mdev: constify fb ops > auxdisplay: constify fb ops > > drivers/auxdisplay/cfag12864bfb.c | 2 +- > drivers/auxdisplay/ht16k33.c | 2 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 2 +- > drivers/gpu/drm/armada/armada_fbdev.c | 2 +- > drivers/gpu/drm/drm_fb_helper.c | 27 +++---------------- > drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 2 +- > .../gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c | 2 +- > drivers/gpu/drm/i915/display/intel_fbdev.c | 2 +- > drivers/gpu/drm/msm/msm_fbdev.c | 2 +- > drivers/gpu/drm/nouveau/nouveau_fbcon.c | 4 +-- > drivers/gpu/drm/omapdrm/omap_fbdev.c | 2 +- > drivers/gpu/drm/radeon/radeon_fb.c | 2 +- > drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 2 +- > drivers/gpu/drm/tegra/fb.c | 2 +- > drivers/gpu/drm/vmwgfx/vmwgfx_fb.c | 2 +- > drivers/hid/hid-picolcd_fb.c | 3 +-- > drivers/media/pci/ivtv/ivtvfb.c | 3 +-- > drivers/media/platform/vivid/vivid-osd.c | 3 +-- > drivers/video/fbdev/68328fb.c | 2 +- > drivers/video/fbdev/acornfb.c | 2 +- > drivers/video/fbdev/amba-clcd.c | 2 +- > drivers/video/fbdev/amifb.c | 2 +- > drivers/video/fbdev/arcfb.c | 2 +- > drivers/video/fbdev/arkfb.c | 2 +- > drivers/video/fbdev/asiliantfb.c | 2 +- > drivers/video/fbdev/atmel_lcdfb.c | 2 +- > drivers/video/fbdev/aty/aty128fb.c | 2 +- > drivers/video/fbdev/aty/atyfb_base.c | 2 +- > drivers/video/fbdev/aty/radeon_base.c | 2 +- > drivers/video/fbdev/au1100fb.c | 2 +- > drivers/video/fbdev/au1200fb.c | 2 +- > drivers/video/fbdev/broadsheetfb.c | 2 +- > drivers/video/fbdev/bw2.c | 2 +- > drivers/video/fbdev/carminefb.c | 2 +- > drivers/video/fbdev/cg14.c | 2 +- > drivers/video/fbdev/cg3.c | 2 +- > drivers/video/fbdev/cg6.c | 2 +- > drivers/video/fbdev/chipsfb.c | 2 +- > drivers/video/fbdev/cirrusfb.c | 2 +- > drivers/video/fbdev/clps711x-fb.c | 2 +- > drivers/video/fbdev/cobalt_lcdfb.c | 2 +- > drivers/video/fbdev/controlfb.c | 2 +- > drivers/video/fbdev/core/fb_defio.c | 3 --- > drivers/video/fbdev/core/fbmem.c | 19 ++++++++----- > drivers/video/fbdev/cyber2000fb.c | 2 +- > drivers/video/fbdev/da8xx-fb.c | 2 +- > drivers/video/fbdev/dnfb.c | 2 +- > drivers/video/fbdev/efifb.c | 2 +- > drivers/video/fbdev/ep93xx-fb.c | 2 +- > drivers/video/fbdev/fb-puv3.c | 2 +- > drivers/video/fbdev/ffb.c | 2 +- > drivers/video/fbdev/fm2fb.c | 2 +- > drivers/video/fbdev/fsl-diu-fb.c | 2 +- > drivers/video/fbdev/g364fb.c | 2 +- > drivers/video/fbdev/gbefb.c | 2 +- > drivers/video/fbdev/geode/gx1fb_core.c | 2 +- > drivers/video/fbdev/geode/gxfb_core.c | 2 +- > drivers/video/fbdev/geode/lxfb_core.c | 2 +- > drivers/video/fbdev/goldfishfb.c | 2 +- > drivers/video/fbdev/grvga.c | 2 +- > drivers/video/fbdev/gxt4500.c | 2 +- > drivers/video/fbdev/hecubafb.c | 2 +- > drivers/video/fbdev/hgafb.c | 2 +- > drivers/video/fbdev/hitfb.c | 2 +- > drivers/video/fbdev/hpfb.c | 2 +- > drivers/video/fbdev/hyperv_fb.c | 2 +- > drivers/video/fbdev/i740fb.c | 2 +- > drivers/video/fbdev/imsttfb.c | 2 +- > drivers/video/fbdev/imxfb.c | 2 +- > drivers/video/fbdev/intelfb/intelfbdrv.c | 2 +- > drivers/video/fbdev/kyro/fbdev.c | 2 +- > drivers/video/fbdev/leo.c | 2 +- > drivers/video/fbdev/macfb.c | 2 +- > drivers/video/fbdev/matrox/matroxfb_crtc2.c | 2 +- > drivers/video/fbdev/maxinefb.c | 2 +- > drivers/video/fbdev/mb862xx/mb862xxfbdrv.c | 2 +- > drivers/video/fbdev/mbx/mbxfb.c | 2 +- > drivers/video/fbdev/metronomefb.c | 2 +- > drivers/video/fbdev/mmp/fb/mmpfb.c | 2 +- > drivers/video/fbdev/mx3fb.c | 5 ++-- > drivers/video/fbdev/neofb.c | 2 +- > drivers/video/fbdev/nvidia/nvidia.c | 2 +- > drivers/video/fbdev/ocfb.c | 2 +- > drivers/video/fbdev/offb.c | 2 +- > drivers/video/fbdev/omap/omapfb_main.c | 2 +- > .../video/fbdev/omap2/omapfb/omapfb-main.c | 2 +- > drivers/video/fbdev/p9100.c | 2 +- > drivers/video/fbdev/platinumfb.c | 2 +- > drivers/video/fbdev/pm2fb.c | 2 +- > drivers/video/fbdev/pm3fb.c | 2 +- > drivers/video/fbdev/pmag-aa-fb.c | 2 +- > drivers/video/fbdev/pmag-ba-fb.c | 2 +- > drivers/video/fbdev/pmagb-b-fb.c | 2 +- > drivers/video/fbdev/ps3fb.c | 2 +- > drivers/video/fbdev/pvr2fb.c | 2 +- > drivers/video/fbdev/pxa168fb.c | 2 +- > drivers/video/fbdev/pxafb.c | 4 +-- > drivers/video/fbdev/q40fb.c | 2 +- > drivers/video/fbdev/riva/fbdev.c | 2 +- > drivers/video/fbdev/s3c-fb.c | 2 +- > drivers/video/fbdev/s3c2410fb.c | 2 +- > drivers/video/fbdev/s3fb.c | 2 +- > drivers/video/fbdev/sa1100fb.c | 2 +- > drivers/video/fbdev/savage/savagefb_driver.c | 2 +- > drivers/video/fbdev/sh7760fb.c | 2 +- > drivers/video/fbdev/sh_mobile_lcdcfb.c | 4 +-- > drivers/video/fbdev/simplefb.c | 2 +- > drivers/video/fbdev/sis/sis_main.c | 2 +- > drivers/video/fbdev/skeletonfb.c | 2 +- > drivers/video/fbdev/sm712fb.c | 2 +- > drivers/video/fbdev/smscufx.c | 3 +-- > drivers/video/fbdev/ssd1307fb.c | 2 +- > drivers/video/fbdev/sstfb.c | 2 +- > drivers/video/fbdev/stifb.c | 2 +- > drivers/video/fbdev/sunxvr1000.c | 2 +- > drivers/video/fbdev/sunxvr2500.c | 2 +- > drivers/video/fbdev/sunxvr500.c | 2 +- > drivers/video/fbdev/tcx.c | 2 +- > drivers/video/fbdev/tdfxfb.c | 2 +- > drivers/video/fbdev/tgafb.c | 2 +- > drivers/video/fbdev/tmiofb.c | 2 +- > drivers/video/fbdev/tridentfb.c | 2 +- > drivers/video/fbdev/udlfb.c | 1 - > drivers/video/fbdev/uvesafb.c | 2 +- > drivers/video/fbdev/valkyriefb.c | 2 +- > drivers/video/fbdev/vesafb.c | 6 ++--- > drivers/video/fbdev/vfb.c | 2 +- > drivers/video/fbdev/vga16fb.c | 2 +- > drivers/video/fbdev/vt8500lcdfb.c | 2 +- > drivers/video/fbdev/vt8623fb.c | 2 +- > drivers/video/fbdev/w100fb.c | 2 +- > drivers/video/fbdev/wm8505fb.c | 2 +- > drivers/video/fbdev/xen-fbfront.c | 2 +- > drivers/video/fbdev/xilinxfb.c | 2 +- > include/linux/fb.h | 2 +- > samples/vfio-mdev/mdpy-fb.c | 2 +- > 136 files changed, 156 insertions(+), 175 deletions(-) > > -- > 2.20.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch