Linux-Media Archive on
 help / color / Atom feed
From: Adam Ford <>
Cc:, Adam Ford <>,
	Jacopo Mondi <>,
	Steve Longerbeam <>,
	Mauro Carvalho Chehab <>,
Subject: [PATCH V2] media: ov5640: Fix check for PLL1 exceeding max allowed rate
Date: Wed,  4 Dec 2019 07:09:07 -0600
Message-ID: <> (raw)

The PLL calculation routine checks the wrong variable name 'rate'
when it should be called '_rate' when checking to see whether or
not the PLL1 output frequency exceeds 1GHz.

This patch changes it to the correct variable '_rate'

Acked-by: Jacopo Mondi <>
Signed-off-by: Adam Ford <>
V2:  No code change.  Only change commit description to be less confusing.

diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
index 5e495c833d32..bb968e764f31 100644
--- a/drivers/media/i2c/ov5640.c
+++ b/drivers/media/i2c/ov5640.c
@@ -874,7 +874,7 @@ static unsigned long ov5640_calc_sys_clk(struct ov5640_dev *sensor,
 			 * We have reached the maximum allowed PLL1 output,
 			 * increase sysdiv.
-			if (!rate)
+			if (!_rate)

             reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-04 13:09 Adam Ford [this message]
2019-12-04 13:21 ` Fabio Estevam
2019-12-04 13:25 ` Jacopo Mondi
2019-12-04 13:37   ` Adam Ford

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Media Archive on

Archives are clonable:
	git clone --mirror linux-media/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-media linux-media/ \
	public-inbox-index linux-media

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone