Linux-Media Archive on lore.kernel.org
 help / color / Atom feed
From: Jacopo Mondi <jacopo@jmondi.org>
To: Adam Ford <aford173@gmail.com>
Cc: linux-media@vger.kernel.org, adam.ford@logicpd.com,
	Steve Longerbeam <slongerbeam@gmail.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] media: ov5640: Fix check for PLL1 exceeding max allowed rate
Date: Wed, 4 Dec 2019 14:25:57 +0100
Message-ID: <20191204132557.pl6rwfprtcwewato@uno.localdomain> (raw)
In-Reply-To: <20191204130907.19799-1-aford173@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1196 bytes --]

Hi Adam,

On Wed, Dec 04, 2019 at 07:09:07AM -0600, Adam Ford wrote:
> The PLL calculation routine checks the wrong variable name 'rate'
> when it should be called '_rate' when checking to see whether or
> not the PLL1 output frequency exceeds 1GHz.
>
> This patch changes it to the correct variable '_rate'
>
> Acked-by: Jacopo Mondi <jacopo@jmondi.org>
> Signed-off-by: Adam Ford <aford173@gmail.com>

Why have you dropped the fixes tag you had in v1?

Fixes: aa2882481cad ("media: ov5640: Adjust the clock based on the expected rate")

I'm not the one who collects patches, so maybe wait for Sakari or Hans
to tell you if you need to resend or not :)

Thanks
   j

> ---
> V2:  No code change.  Only change commit description to be less confusing.
>
> diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
> index 5e495c833d32..bb968e764f31 100644
> --- a/drivers/media/i2c/ov5640.c
> +++ b/drivers/media/i2c/ov5640.c
> @@ -874,7 +874,7 @@ static unsigned long ov5640_calc_sys_clk(struct ov5640_dev *sensor,
>  			 * We have reached the maximum allowed PLL1 output,
>  			 * increase sysdiv.
>  			 */
> -			if (!rate)
> +			if (!_rate)
>  				break;
>
>  			/*
> --
> 2.20.1
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-04 13:09 Adam Ford
2019-12-04 13:21 ` Fabio Estevam
2019-12-04 13:25 ` Jacopo Mondi [this message]
2019-12-04 13:37   ` Adam Ford

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191204132557.pl6rwfprtcwewato@uno.localdomain \
    --to=jacopo@jmondi.org \
    --cc=adam.ford@logicpd.com \
    --cc=aford173@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=slongerbeam@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Media Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-media/0 linux-media/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-media linux-media/ https://lore.kernel.org/linux-media \
		linux-media@vger.kernel.org
	public-inbox-index linux-media

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-media


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git