From: Sean Young <sean@mess.org>
To: "Uwe Kleine-König" <uwe@kleine-koenig.org>
Cc: Antti Palosaari <crope@iki.fi>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org
Subject: Re: [PATCH] [media] af9035: issue an error message when i2c stuff fails
Date: Tue, 31 Dec 2019 09:37:33 +0000 [thread overview]
Message-ID: <20191231093733.GC24469@gofer.mess.org> (raw)
In-Reply-To: <20190707205933.23059-1-uwe@kleine-koenig.org>
Hello Uwe,
First apologies for taking so long to get to your patch.
On Sun, Jul 07, 2019 at 10:59:33PM +0200, Uwe Kleine-König wrote:
> Instead of failing silent give a hint what went wrong.
>
> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
> ---
> drivers/media/usb/dvb-usb-v2/af9035.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/dvb-usb-v2/af9035.c b/drivers/media/usb/dvb-usb-v2/af9035.c
> index de52309eaaab..f5701fab192c 100644
> --- a/drivers/media/usb/dvb-usb-v2/af9035.c
> +++ b/drivers/media/usb/dvb-usb-v2/af9035.c
> @@ -211,13 +211,19 @@ static int af9035_add_i2c_dev(struct dvb_usb_device *d, const char *type,
>
> /* register I2C device */
> client = i2c_new_device(adapter, &board_info);
> - if (client == NULL || client->dev.driver == NULL) {
> + if (client == NULL) {
> + dev_err(&intf->dev, "failed to register i2c device\n");
> + ret = -ENODEV;
> + goto err;
> + } else if (client->dev.driver == NULL) {
> + dev_err(&intf->dev, "no driver for i2c device (type=%s)\n", type);
> ret = -ENODEV;
> goto err;
> }
i2c_new_device() calls i2c_new_client_device(), which in every error path
does a dev_err(). I suspect that this patch has become obsolete because
of fixes in i2c.
Thanks,
Sean
>
> /* increase I2C driver usage count */
> if (!try_module_get(client->dev.driver->owner)) {
> + dev_err(&intf->dev, "failed to get module for i2c driver\n");
> i2c_unregister_device(client);
> ret = -ENODEV;
> goto err;
> --
> 2.20.1
prev parent reply other threads:[~2019-12-31 9:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-07 20:59 [PATCH] [media] af9035: issue an error message when i2c stuff fails Uwe Kleine-König
2019-12-31 9:37 ` Sean Young [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191231093733.GC24469@gofer.mess.org \
--to=sean@mess.org \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=uwe@kleine-koenig.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).