From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7408CC33CA1 for ; Mon, 20 Jan 2020 08:11:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3EF172077C for ; Mon, 20 Jan 2020 08:11:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579507873; bh=D54k3tLswJ+Y8Gx/Mn1k731v0sbKOgu4bKgpR3iVqiI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=HQhPypr+nBSJKKgbpCZC0DwuGmmQ7Mhjr8EvSTVa3eZleO6OaCwSyv7ahAS+1Ab/n Xi1KjW7TFGEvxBNwJXl1GPnvd3/EtqE85HON0UZH3yBTG31VhRY4bb4lPiN/HONL0s GNMo1wq0+Wn3szAQs23tPF5kUmPVq/X4e4EqZlXo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726584AbgATILM (ORCPT ); Mon, 20 Jan 2020 03:11:12 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:41498 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726039AbgATILM (ORCPT ); Mon, 20 Jan 2020 03:11:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Sender:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=tfnr7fgwUzY0661lGsqsca78ntQOx3kYCD8AbDmh97I=; b=cioTpemugEnAmmctrZODuxm5/ s65pdNxpMaD19a79SmIp/2bv445UqvB83Q/GnSNwfkqYLwoYZShJag/REWd+MR9JN5J/KSrO3EvzD E9SCPOFedoVrfsox0Rc9VgqEqrZv0NRKGtXfLTmOETDyZe+zFe/EBF+a6C5dYil2qhLKwVbaXsjPR 9f9uP7UnDz8b0KXvUbAsgsbs7AZLYUPKYxO9myCaSn57n8b+TG4nPUfLpw2BXfQRMIiRtPPUSB7xD vq/SMTGx1m7Fl3h3UF4cfXKtDIva9hUhPsai/7ksru3pgVtIlKwiIsBUN9E4AWjvq5XQ3RlDJ4+us 5kEVEGOrQ==; Received: from [179.179.33.167] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1itS9M-00067O-G3; Mon, 20 Jan 2020 08:11:09 +0000 Date: Mon, 20 Jan 2020 09:10:50 +0100 From: Mauro Carvalho Chehab To: Zhang Xiaoxu Cc: , , Subject: Re: [PATCH v2] media: staging: rkisp1: The rkisp1 should be depended on CONFIG_OF Message-ID: <20200120091050.490a4910@kernel.org> In-Reply-To: <20200114021720.30826-1-zhangxiaoxu5@huawei.com> References: <20200114021720.30826-1-zhangxiaoxu5@huawei.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Em Tue, 14 Jan 2020 10:17:20 +0800 Zhang Xiaoxu escreveu: > If 'CONFIG_VIDEO_ROCKCHIP_ISP1' configured but no 'CONFIG_OF', the > default configuration maybe: > # CONFIG_OF is not set > CONFIG_PHY_ROCKCHIP_DPHY_RX0=y > CONFIG_VIDEO_ROCKCHIP_ISP1=y > > This will cause the following compilation errors: > drivers/staging/media/rkisp1/rkisp1-isp.o: > In function `rkisp1_mipi_csi2_start.isra.5': > rkisp1-isp.c:(.text+0x1238): > undefined reference to `phy_mipi_dphy_get_default_config' > make: *** [vmlinux] Error 1 > > Signed-off-by: Zhang Xiaoxu > --- > drivers/staging/media/rkisp1/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/rkisp1/Kconfig b/drivers/staging/media/rkisp1/Kconfig > index b859a493caba..23080b7f07a6 100644 > --- a/drivers/staging/media/rkisp1/Kconfig > +++ b/drivers/staging/media/rkisp1/Kconfig > @@ -3,7 +3,7 @@ > config VIDEO_ROCKCHIP_ISP1 > tristate "Rockchip Image Signal Processing v1 Unit driver" > depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API > - depends on ARCH_ROCKCHIP || COMPILE_TEST > + depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF Makes sense. Yet, I would prefer to have this as: depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API && OF depends on ARCH_ROCKCHIP || COMPILE_TEST Just to let the arch-specific/compile test dependency line clearer. > select VIDEOBUF2_DMA_CONTIG > select VIDEOBUF2_VMALLOC > select V4L2_FWNODE Cheers, Mauro